New issue
Advanced search Search tips

Issue 768180 link

Starred by 1 user
Status: Fixed
Owner:
yuweih@chromium.org
Closed: Sep 2017
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

[CRD iOS] Use AppIconset for app icon

Project Member Reported by yuweih@chromium.org, Sep 24 2017 
Looks like apps built under iOS 11 SDK are required to use AppIconset in order to be able to upload to iTunes Connect. We should migrate to use AppIconset for app icons, just like how Chrome is doing so.

Comment 1 by yuweih@chromium.org, Sep 24 2017

Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 25 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/3c1a409c081e247ea26e315e05e29f2ddc533860

commit 3c1a409c081e247ea26e315e05e29f2ddc533860
Author: Yuwei Huang <yuweih@chromium.org>
Date: Mon Sep 25 20:49:12 2017
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d5450531558afa879811b803689d6e98c3b7d6f

commit 9d5450531558afa879811b803689d6e98c3b7d6f
Author: Yuwei Huang <yuweih@chromium.org>
Date: Mon Sep 25 22:03:02 2017

[CRD iOS] Use AppIconset for Chromium app icons

This migrates the Chromium version of the CRD app icons to AppIconset.

Bug:  768180 
Change-Id: I2f369a93c617877be5d1f970cdbcd26f88ca5cfc
Reviewed-on: https://chromium-review.googlesource.com/680275
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Scott Nichols <nicholss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504178}
[modify] https://crrev.com/9d5450531558afa879811b803689d6e98c3b7d6f/remoting/ios/app/resources/BUILD.gn
[modify] https://crrev.com/9d5450531558afa879811b803689d6e98c3b7d6f/remoting/ios/app/resources/Info.plist
[add] https://crrev.com/9d5450531558afa879811b803689d6e98c3b7d6f/remoting/ios/app/resources/chromium/AppIcon.appiconset/Contents.json
[rename] https://crrev.com/9d5450531558afa879811b803689d6e98c3b7d6f/remoting/ios/app/resources/chromium/AppIcon.appiconset/Icon-120.png
[rename] https://crrev.com/9d5450531558afa879811b803689d6e98c3b7d6f/remoting/ios/app/resources/chromium/AppIcon.appiconset/Icon-152.png
[rename] https://crrev.com/9d5450531558afa879811b803689d6e98c3b7d6f/remoting/ios/app/resources/chromium/AppIcon.appiconset/Icon-167.png
[rename] https://crrev.com/9d5450531558afa879811b803689d6e98c3b7d6f/remoting/ios/app/resources/chromium/AppIcon.appiconset/Icon-180.png
[rename] https://crrev.com/9d5450531558afa879811b803689d6e98c3b7d6f/remoting/ios/app/resources/chromium/AppIcon.appiconset/Icon-29.png
[rename] https://crrev.com/9d5450531558afa879811b803689d6e98c3b7d6f/remoting/ios/app/resources/chromium/AppIcon.appiconset/Icon-40.png
[rename] https://crrev.com/9d5450531558afa879811b803689d6e98c3b7d6f/remoting/ios/app/resources/chromium/AppIcon.appiconset/Icon-58.png
[rename] https://crrev.com/9d5450531558afa879811b803689d6e98c3b7d6f/remoting/ios/app/resources/chromium/AppIcon.appiconset/Icon-76.png
[rename] https://crrev.com/9d5450531558afa879811b803689d6e98c3b7d6f/remoting/ios/app/resources/chromium/AppIcon.appiconset/Icon-80.png
[rename] https://crrev.com/9d5450531558afa879811b803689d6e98c3b7d6f/remoting/ios/app/resources/chromium/AppIcon.appiconset/Icon-87.png

Comment 4 by yuweih@chromium.org, Sep 25 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment