Issue metadata
Sign in to add a comment
|
JS files not showing in Dev Tools' Sources tab when extension uses tabs.create().
Reported by
dtev...@gmail.com,
Sep 23 2017
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.113 Safari/537.36 Steps to reproduce the problem: 1. Load following extension 2. Open the extension. 3. Click on the "tabs.create()" button. 4. On new window (tab) open Developer tools. 5. Go to Developer tools "Sources" tab. Note that only file showing is "popup.html" 6. Go to Developer tools "Console" tab. Enter "location reload(true)" without the quotes and press enter key. 7. Go to Developer tools "Sources" tab. Note that file "main.js" has been added What is the expected behavior? The Sources tab should show the the js files without needing to type "location reload(true) in the console window. What went wrong? Need to type "location reload(true) in the console window to make js files appear Did this work before? N/A Chrome version: 60.0.3112.113 Channel: n/a OS Version: 10.0 Flash Version: It's also probably worth noting that if you 1. Load following extension 2. Open the extension. 3. On the popup window open Developer tools. (i.e. Don't click the "tabs.create()" button) 4. Go to Developer tools "Sources" tab. Note that it shows files "popup.html" and "main.js".
,
Sep 24 2017
Bisect info: 387924 (good) - 387928 (bad) https://chromium.googlesource.com/chromium/src/+log/a06a5668..5f50385e?pretty=fuller Suspecting r387925 "Update V8 to version 5.2.53" Landed in 52.0.2712.0 In V8 log I can only randomly guess two cache-related CL: https://crrev.com/1900483002 "Produce a code cache if the embedder asks for one" https://crrev.com/1901573002 "Reland of Immediately cache compiled scripts" Note: zip in #0 is locked to Chrome 54+ so I'm attaching an unlocked one here.
,
Sep 24 2017
Note2: instead of location.reload mentioned in the original StR, you can simply press F5 key to reload devtools.
,
Sep 25 2017
,
Sep 25 2017
Assigning to jochen@ as per the bisects in #2.
,
Sep 26 2017
Yang, can you help to triage please? Maybe devtools doesn't get a signal about a file being used if we get the entire file out of the internal cache?
,
Sep 26 2017
Indeed we do not call Debug::OnAfterCompile (in Compiler::GetSharedFunctionInfoForScript) if we get it from the in-process compilation cache. Is that what is being triggered in this case? I'm not sure whether it's safe to call OnAfterCompile a second time here, since we are not really compiling a new script. In fact we just return an existing script.
,
Oct 16 2017
,
Jun 20 2018
For what it's worth, problem is not showing in Chrome Version 67.0.3396.87 (Official Build) (64-bit)
,
Oct 4
I can not reproduce it in ToT as well. Thanks for your report and feel free to file another issue if it will happen again.
,
Oct 4
Reverse-bisect info: Fixed in 66.0.3358.0 via r539740 Tentatively 910f45fa8d1270909ef84908504ccba3b54e1f44 "Reland: [Compiler] Use CompilationCache for StreamedScript compilation." |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dtev...@gmail.com
, Sep 23 2017