New issue
Advanced search Search tips

Issue 768149 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

pobfuzz: drawRRect generates an invalid SkPathRef assert

Project Member Reported by ClusterFuzz, Sep 23 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4603826643664896

Fuzzer: libFuzzer_paint_op_buffer_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Abrt
Crash Address: 0x03e900006263
Crash State:
  sk_abort_no_print
  SkPathRef::validate
  SkPath::addRRect
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=496919:496954

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4603826643664896

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Components: Internals>Skia

Comment 2 by enne@chromium.org, Sep 25 2017

Labels: -Pri-1 Pri-2
Owner: enne@chromium.org
Status: Assigned (was: Untriaged)
Summary: pobfuzz: drawRRect generates an invalid SkPathRef assert (was: Abrt in sk_abort_no_print)
Project Member

Comment 3 by ClusterFuzz, Oct 1 2017

Labels: Test-Predator-AutoComponents
Automatically applying components based on information from OWNERS files. If this seems incorrect, please apply the Test-Predator-Wrong-Components label.
Labels: -Test-Predator-AutoComponents
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 2 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/74a8296d7c47efc6e23bd978efd1fdf4dbe29eb9

commit 74a8296d7c47efc6e23bd978efd1fdf4dbe29eb9
Author: Adrienne Walker <enne@chromium.org>
Date: Mon Oct 02 20:50:38 2017

Fix SkRRect validation for negative types

SkRRect::fType is an int, so needs to be checked to see if it's
negative.

Bug: chromium: 768149
Change-Id: I6a9a019c736806d35dc1bd627fb4ddc735a0ac86
Reviewed-on: https://skia-review.googlesource.com/54024
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Reed <reed@google.com>

[modify] https://crrev.com/74a8296d7c47efc6e23bd978efd1fdf4dbe29eb9/src/core/SkRRect.cpp

Project Member

Comment 6 by ClusterFuzz, Oct 3 2017

ClusterFuzz has detected this issue as fixed in range 505840:505918.

Detailed report: https://clusterfuzz.com/testcase?key=4603826643664896

Fuzzer: libFuzzer_paint_op_buffer_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Abrt
Crash Address: 0x03e900006263
Crash State:
  sk_abort_no_print
  SkPathRef::validate
  SkPath::addRRect
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=496919:496954
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=505840:505918

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4603826643664896

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Oct 3 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 4603826643664896 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment