New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 768120 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Feature

Blocking:
issue 767116
issue 589943



Sign in to add a comment

Motion spec for new 'download complete' animation

Project Member Reported by bettes@chromium.org, Sep 23 2017

Issue description

Comment 1 by sdy@chromium.org, Oct 6 2017

Blocking: 589943

Comment 2 by sdy@chromium.org, Oct 6 2017

Blocking: 767116

Comment 3 by sdy@chromium.org, Oct 6 2017

Blockedon: -767116

Comment 4 by sdy@chromium.org, Oct 6 2017

Labels: -M-63 M-64

Comment 5 by sdy@chromium.org, Oct 13 2017

Status: Started (was: Assigned)
https://chromium-review.googlesource.com/c/chromium/src/+/704211

Comment 6 by sdy@chromium.org, Oct 16 2017

Status: Fixed (was: Started)
This should be in tomorrow's Canary. Take a look!
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e416ac9c6cef242f3368c9ac65b0611fbb91995

commit 8e416ac9c6cef242f3368c9ac65b0611fbb91995
Author: Sidney San Martín <sdy@chromium.org>
Date: Mon Oct 16 19:39:48 2017

New animations for MD downloads.

Much of the complexity is related to:

- Transitions being requested before others finish: Using cmd+S to save
  a page can go through indeterminate progress, determinate progress,
  and completion within a fraction of a second.

- Making sure things happen at the right moments: The completion
  animation shouldn't happen before progress finishes animating to 100%,
  and the filename should drop down in sync with the completion
  animation regardless of whether it waited for progress to change.

Bug:  768120 ,  767223 
Change-Id: I3881a48853ca002378a2fc86187ecc75b33469e5
Reviewed-on: https://chromium-review.googlesource.com/704211
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509141}
[modify] https://crrev.com/8e416ac9c6cef242f3368c9ac65b0611fbb91995/chrome/browser/ui/cocoa/download/download_shelf_controller.mm
[modify] https://crrev.com/8e416ac9c6cef242f3368c9ac65b0611fbb91995/chrome/browser/ui/cocoa/download/md_download_item_progress_indicator.h
[modify] https://crrev.com/8e416ac9c6cef242f3368c9ac65b0611fbb91995/chrome/browser/ui/cocoa/download/md_download_item_progress_indicator.mm
[modify] https://crrev.com/8e416ac9c6cef242f3368c9ac65b0611fbb91995/chrome/browser/ui/cocoa/download/md_download_item_view.mm
[modify] https://crrev.com/8e416ac9c6cef242f3368c9ac65b0611fbb91995/ui/base/BUILD.gn
[delete] https://crrev.com/ec3d9ebab41efcfdcea80a45d639848daf1b2161/ui/base/cocoa/quartzcore_additions.h
[delete] https://crrev.com/ec3d9ebab41efcfdcea80a45d639848daf1b2161/ui/base/cocoa/quartzcore_additions.mm

The animation looks perfect! thank you Sidney! :D

Comment 9 by sdy@chromium.org, Oct 17 2017

Great! I noticed an issue with themed windows ( issue 775618 ), take a look when you have a chance?

Sign in to add a comment