New issue
Advanced search Search tips

Issue 768109 link

Starred by 1 user
Status: Fixed
Owner:
yhanada@chromium.org
Closed: Sep 2017
Cc:
shuchen@chromium.org
lgcheng@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

M-61 debug build for Chrome OS is broken

Project Member Reported by yhanada@chromium.org, Sep 23 2017 
Due to http://crrev.com/c/660938.
The change uses operator<< for base::FilePath, but it's not exported in M-61 branch.

I've uploaded a fix(http://crrev.com/c/679376) for it.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bfc521be486382153ebe7a4397ad332b3f1fe8f8

commit bfc521be486382153ebe7a4397ad332b3f1fe8f8
Author: Yuichiro Hanada <yhanada@chromium.org>
Date: Sat Sep 23 04:30:42 2017

Fix the build breakage in M-61 debug build.

Test: Debug build passes.
Bug:  768109 
Change-Id: I843deff241fac0de117b6575697a745527a3d86e
Reviewed-on: https://chromium-review.googlesource.com/679376
Reviewed-by: Shu Chen <shuchen@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503936}
[modify] https://crrev.com/bfc521be486382153ebe7a4397ad332b3f1fe8f8/chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc

Comment 2 by yhanada@chromium.org, Sep 24 2017

Labels: Merge-Request-61
Requesting merge the change to M-61.

Comment 3 by keta...@chromium.org, Sep 25 2017

Labels: -Merge-Request-61 Merge-Approved-61
Approving merge to M61.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 26 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66c0210b06637f38883ab24669d36a8751d1ffc9

commit 66c0210b06637f38883ab24669d36a8751d1ffc9
Author: Yuichiro Hanada <yhanada@chromium.org>
Date: Tue Sep 26 03:51:25 2017

Fix the build breakage in M-61 debug build.

TBR=yhanada@chromium.org

(cherry picked from commit bfc521be486382153ebe7a4397ad332b3f1fe8f8)

Test: Debug build passes.
Bug:  768109 
Change-Id: I843deff241fac0de117b6575697a745527a3d86e
Reviewed-on: https://chromium-review.googlesource.com/679376
Reviewed-by: Shu Chen <shuchen@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#503936}
Reviewed-on: https://chromium-review.googlesource.com/683775
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#1281}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/66c0210b06637f38883ab24669d36a8751d1ffc9/chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc

Comment 5 by yhanada@chromium.org, Sep 26 2017

Status: Fixed (was: Started)
Thanks for approving!

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 7 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
►

Sign in to add a comment