New issue
Advanced search Search tips

Issue 768104 link

Starred by 1 user
Status: Fixed
Owner:
minch@chromium.org
Closed: Sep 2017
Cc:
xiy...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Shelf items have no reactions to touch events after click with mouse to show the context menu

Project Member Reported by minch@chromium.org, Sep 23 2017 
Chrome Version: 63.0.3223
OS: (e.g. Win7, OSX 10.9.5, etc...)

What steps will reproduce the problem?
(1) Right click the shelf item with mouse will open the corresponding context menu of the item.
(2) Release the mouse click.
(3) Touch the shelf item, or drag it, or any touch gestures.

What is the expected result?
Shelf item should response the corresponding touch events.

What happens instead?
Shelf item kept still, nothing happened with touch events.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebd65079fd07b9d9b793a3f96e5fd6656667ccd4

commit ebd65079fd07b9d9b793a3f96e5fd6656667ccd4
Author: MinChen <minch@chromium.org>
Date: Mon Sep 25 17:51:50 2017

Only to transfer events from shelf item to its context menu for MENU_SOURCE_TOUCH type.

The flag |send_gesture_events_to_owner_| is used to transfer gesture events
from shelf item to its context menu. And will only be reset in
MenuController::OnGestureEvent. Should check the MenuSourceType before set
the flag.

Bug:  768104 
Change-Id: Iec542bbad1c0ed277591caad82f874b54c756a6b
Reviewed-on: https://chromium-review.googlesource.com/679926
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: min c <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504097}
[modify] https://crrev.com/ebd65079fd07b9d9b793a3f96e5fd6656667ccd4/ash/shelf/shelf_view.cc

Comment 2 by minch@chromium.org, Sep 25 2017

Status: Fixed (was: Started)
►

Sign in to add a comment