New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 768094 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

v8's unittests fail with to link with undefined symbol v8::internal::GetRandomMmapAddr on mac

Project Member Reported by lgar...@chromium.org, Sep 23 2017

Issue description

macOS 10.12.6

What steps will reproduce the problem?
(1) Build
(2)
(3)

What is the expected result?
Builds

What happens instead?

FAILED: unittests
export DEVELOPER_DIR=/Users/lgarron/chromium/src/build/mac_files/Xcode.app;  TOOL_VERSION=1479496253 ../../build/toolchain/mac/linker_driver.py ../../third_party/llvm-build/Release+Asserts/bin/clang++  -stdlib=libc++ -arch x86_64 -Werror -isysroot ../../build/mac_files/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk -mmacosx-version-min=10.9.0 -Wl,-ObjC -Wl,-rpath,@loader_path/. -Wl,-rpath,@loader_path/../../.. -Wl,-pie -o "./unittests" -Wl,-filelist,"./unittests.rsp" ./libv8_for_testing.dylib ./libv8_libbase.dylib ./libv8_libplatform.dylib ./libicui18n.dylib ./libicuuc.dylib
Undefined symbols for architecture x86_64:
  "v8::internal::GetRandomMmapAddr()", referenced from:
      v8::internal::HeapTest_ASLR_Test::TestBody() in heap-unittest.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Traceback (most recent call last):
  File "../../build/toolchain/mac/linker_driver.py", line 229, in <module>
    Main(sys.argv)
  File "../../build/toolchain/mac/linker_driver.py", line 79, in Main
    subprocess.check_call(compiler_driver_args)
  File "/Users/lgarron/local/homebrew/Cellar/python/2.7.13/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 186, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['../../third_party/llvm-build/Release+Asserts/bin/clang++', '-stdlib=libc++', '-arch', 'x86_64', '-Werror', '-isysroot', '../../build/mac_files/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk', '-mmacosx-version-min=10.9.0', '-Wl,-ObjC', '-Wl,-rpath,@loader_path/.', '-Wl,-rpath,@loader_path/../../..', '-Wl,-pie', '-o', './unittests', '-Wl,-filelist,./unittests.rsp', './libv8_for_testing.dylib', './libv8_libbase.dylib', './libv8_libplatform.dylib', './libicui18n.dylib', './libicuuc.dylib']' returned non-zero exit status 1

Happened to me on two computers around the same time.
 
Components: -Infra>Client>V8
To me this looks like a compilation problem, not an infra problem. Feel free to move back to the infra component if this is not the case.

Comment 2 by h...@chromium.org, Sep 25 2017

Cc: thakis@chromium.org
 Issue 768398  has been merged into this issue.

Comment 3 by h...@chromium.org, Sep 25 2017

Cc: phoglund@chromium.org
 Issue 768299  has been merged into this issue.

Comment 4 by h...@chromium.org, Sep 25 2017

Owner: u...@chromium.org
Status: Assigned (was: Untriaged)
Summary: v8's unittests fail with to link with undefined symbol v8::internal::GetRandomMmapAddr on mac (was: `ninja -C out/Release` fails on macOS)
Ulan, do you know if something changed here recently, and who might be a good person to take a look?

Comment 5 by h...@chromium.org, Sep 25 2017

Cc: u...@chromium.org
Owner: bbudge@chromium.org
Oh, grunell identified it as https://chromium.googlesource.com/v8/v8/+/d607f1e72d082c9c4dac4d6359858e20a10f16b6 in one of the dupes

Comment 6 by bbudge@chromium.org, Sep 25 2017

Status: Started (was: Assigned)
Looking...

Comment 8 by bbudge@chromium.org, Sep 25 2017

Owner: h...@chromium.org
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/72484a6a82c1044e37d68964244fefa1f6dca557

commit 72484a6a82c1044e37d68964244fefa1f6dca557
Author: Hans Wennborg <hans@chromium.org>
Date: Mon Sep 25 16:52:44 2017

Add V8_EXPORT_PRIVATE to v8::internal::GetRandomMmapAddr()

To unbreak the component build of unittests on Mac after #48124.

Bug:  chromium:768094 
Change-Id: I0e0f4ade0e19a71554f68e7050c525376f125ae5
Reviewed-on: https://chromium-review.googlesource.com/682094
Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#48146}
[modify] https://crrev.com/72484a6a82c1044e37d68964244fefa1f6dca557/src/allocation.h

Comment 10 by a...@chromium.org, Sep 25 2017

Cc: erikc...@chromium.org
 Issue 768524  has been merged into this issue.

Comment 11 by h...@chromium.org, Sep 26 2017

Status: Fixed (was: Started)

Sign in to add a comment