v8's unittests fail with to link with undefined symbol v8::internal::GetRandomMmapAddr on mac |
||||||
Issue description
macOS 10.12.6
What steps will reproduce the problem?
(1) Build
(2)
(3)
What is the expected result?
Builds
What happens instead?
FAILED: unittests
export DEVELOPER_DIR=/Users/lgarron/chromium/src/build/mac_files/Xcode.app; TOOL_VERSION=1479496253 ../../build/toolchain/mac/linker_driver.py ../../third_party/llvm-build/Release+Asserts/bin/clang++ -stdlib=libc++ -arch x86_64 -Werror -isysroot ../../build/mac_files/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk -mmacosx-version-min=10.9.0 -Wl,-ObjC -Wl,-rpath,@loader_path/. -Wl,-rpath,@loader_path/../../.. -Wl,-pie -o "./unittests" -Wl,-filelist,"./unittests.rsp" ./libv8_for_testing.dylib ./libv8_libbase.dylib ./libv8_libplatform.dylib ./libicui18n.dylib ./libicuuc.dylib
Undefined symbols for architecture x86_64:
"v8::internal::GetRandomMmapAddr()", referenced from:
v8::internal::HeapTest_ASLR_Test::TestBody() in heap-unittest.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Traceback (most recent call last):
File "../../build/toolchain/mac/linker_driver.py", line 229, in <module>
Main(sys.argv)
File "../../build/toolchain/mac/linker_driver.py", line 79, in Main
subprocess.check_call(compiler_driver_args)
File "/Users/lgarron/local/homebrew/Cellar/python/2.7.13/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 186, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['../../third_party/llvm-build/Release+Asserts/bin/clang++', '-stdlib=libc++', '-arch', 'x86_64', '-Werror', '-isysroot', '../../build/mac_files/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk', '-mmacosx-version-min=10.9.0', '-Wl,-ObjC', '-Wl,-rpath,@loader_path/.', '-Wl,-rpath,@loader_path/../../..', '-Wl,-pie', '-o', './unittests', '-Wl,-filelist,./unittests.rsp', './libv8_for_testing.dylib', './libv8_libbase.dylib', './libv8_libplatform.dylib', './libicui18n.dylib', './libicuuc.dylib']' returned non-zero exit status 1
Happened to me on two computers around the same time.
,
Sep 25 2017
,
Sep 25 2017
,
Sep 25 2017
Ulan, do you know if something changed here recently, and who might be a good person to take a look?
,
Sep 25 2017
Oh, grunell identified it as https://chromium.googlesource.com/v8/v8/+/d607f1e72d082c9c4dac4d6359858e20a10f16b6 in one of the dupes
,
Sep 25 2017
Looking...
,
Sep 25 2017
,
Sep 25 2017
,
Sep 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/72484a6a82c1044e37d68964244fefa1f6dca557 commit 72484a6a82c1044e37d68964244fefa1f6dca557 Author: Hans Wennborg <hans@chromium.org> Date: Mon Sep 25 16:52:44 2017 Add V8_EXPORT_PRIVATE to v8::internal::GetRandomMmapAddr() To unbreak the component build of unittests on Mac after #48124. Bug: chromium:768094 Change-Id: I0e0f4ade0e19a71554f68e7050c525376f125ae5 Reviewed-on: https://chromium-review.googlesource.com/682094 Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#48146} [modify] https://crrev.com/72484a6a82c1044e37d68964244fefa1f6dca557/src/allocation.h
,
Sep 25 2017
,
Sep 26 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by serg...@chromium.org
, Sep 25 2017