Investigate local id and mapped id matches after transfer |
||
Issue descriptionAs commented in https://chromium-review.googlesource.com/c/chromium/src/+/672012/4/cc/test/render_pass_test_utils.cc#429, use the unmapped id in the DisplayResourceProvider passes the unittests. But intention is to use mapped id in DisplayResourceProvider. We need to "make DisplayRP start at 2 instead of 1 so tests catch this sort of mistake?"
,
Oct 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b56fd2c9eb1422c8890b7f0450c306c0ff32bdf1 commit b56fd2c9eb1422c8890b7f0450c306c0ff32bdf1 Author: Xu Xing <xing.xu@intel.com> Date: Fri Oct 27 22:42:22 2017 Use different initial resource id in Display and LayerTree Intention is to use mapped id in DisplayResourceProvider. Currently the unmapped id is used by DisplayResourceProvider in some unittests, and related unittests got passed. This is not correct. The reason is resource id in both the Display and LayerTree start from 1. In this CL, made two changes to make sure Resource id is correctly used by unittests: 1), change the initial Resource id in Display to 2. 2), DisplayResourceProvider refers mapped Resource id only. BUG= 768075 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I795e51deec286c128eea8b25d400fa7d16383fd9 Reviewed-on: https://chromium-review.googlesource.com/738844 Reviewed-by: danakj <danakj@chromium.org> Commit-Queue: Xing Xu <xing.xu@intel.com> Cr-Commit-Position: refs/heads/master@{#512332} [modify] https://crrev.com/b56fd2c9eb1422c8890b7f0450c306c0ff32bdf1/cc/resources/display_resource_provider.cc [modify] https://crrev.com/b56fd2c9eb1422c8890b7f0450c306c0ff32bdf1/cc/resources/layer_tree_resource_provider.cc [modify] https://crrev.com/b56fd2c9eb1422c8890b7f0450c306c0ff32bdf1/cc/resources/resource_provider.cc [modify] https://crrev.com/b56fd2c9eb1422c8890b7f0450c306c0ff32bdf1/cc/resources/resource_provider.h [modify] https://crrev.com/b56fd2c9eb1422c8890b7f0450c306c0ff32bdf1/cc/resources/resource_provider_unittest.cc [modify] https://crrev.com/b56fd2c9eb1422c8890b7f0450c306c0ff32bdf1/cc/test/fake_resource_provider.h [modify] https://crrev.com/b56fd2c9eb1422c8890b7f0450c306c0ff32bdf1/cc/test/render_pass_test_utils.cc [modify] https://crrev.com/b56fd2c9eb1422c8890b7f0450c306c0ff32bdf1/components/viz/service/display/gl_renderer_unittest.cc [modify] https://crrev.com/b56fd2c9eb1422c8890b7f0450c306c0ff32bdf1/components/viz/service/display/overlay_unittest.cc
,
Oct 27 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by danakj@chromium.org
, Sep 25 2017