New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 768073 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 735489
issue 832184



Sign in to add a comment

Replace paper-toggle-button usages with cr-toggle

Project Member Reported by dpa...@chromium.org, Sep 22 2017

Issue description

At https://chromium-review.googlesource.com/c/chromium/src/+/666126, a new simpler cr-toggle element wants introduced. Currently only used in MD Extensions.

We should replace all usage of paper-toggle-button with cr-toggle and eventually remove paper-toggle-button from third_party/polymer/

I'll start with Settings. Feel free to help with other pages, and also please report any issues you might find on cr-toggle.
 

Comment 1 by dpa...@chromium.org, Sep 25 2017

So, as I am plugging in cr-toggle within Settings, I discovered a Chrome bug (filed as  issue 768555 ), which is causing some complications.

Specifically, in some cases, an accidental click/tap event reaches the cr-toggle's container (settings-toggle-button) and since we want the whole container to be able to be clickable, it accidentally toggles the control. 
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7d01a9411eb0d469d152f770e67b8adc32dcfbf

commit e7d01a9411eb0d469d152f770e67b8adc32dcfbf
Author: Mike West <mkwst@chromium.org>
Date: Fri Sep 29 07:51:15 2017

Revert "MD Settings: Migrate settings-toggle-button to use cr-toggle."

This reverts commit 4981992a59666d142faee96f400a01b6fdb73f02.

Reason for revert: 

It appears that this patch caused `browser_test` failures on 'Linux
ChromiumOS Tests (dbg)', starting at [build 30664][1]. The [errors][2]
read `[8882:8882:0928/213724.538975:ERROR:CONSOLE(48)] "Uncaught TypeError: Cannot read property '_createRipple' of undefined", source: chrome://resources/cr_elements/cr_link_row/cr_link_row.js (48)`, which
this patch alters.

[1]: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/30664
[2]: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chromiumos%2FLinux_ChromiumOS_Tests__dbg__1_%2F30664%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FPasswordsAndFormsBrowserTest.uiTests%2F0

Original change's description:
> MD Settings: Migrate settings-toggle-button to use cr-toggle.
> 
> Bug:  768073 
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: If3efa3993d9ff75cce73eb48d583adb0ea5db543
> Reviewed-on: https://chromium-review.googlesource.com/686041
> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
> Reviewed-by: Scott Chen <scottchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#505269}

TBR=dpapad@chromium.org,scottchen@chromium.org

Change-Id: I6e7e68d3a2989898df9aac3364de489fd5b05cd3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  768073 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/691794
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505321}
[modify] https://crrev.com/e7d01a9411eb0d469d152f770e67b8adc32dcfbf/chrome/browser/resources/settings/controls/compiled_resources2.gyp
[modify] https://crrev.com/e7d01a9411eb0d469d152f770e67b8adc32dcfbf/chrome/browser/resources/settings/controls/settings_toggle_button.html
[modify] https://crrev.com/e7d01a9411eb0d469d152f770e67b8adc32dcfbf/chrome/browser/resources/settings/controls/settings_toggle_button.js
[modify] https://crrev.com/e7d01a9411eb0d469d152f770e67b8adc32dcfbf/ui/webui/resources/cr_elements/cr_toggle/cr_toggle.js

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f423bc1ae49988cc5be11c16fd7fd137b84da587

commit f423bc1ae49988cc5be11c16fd7fd137b84da587
Author: dpapad <dpapad@chromium.org>
Date: Sat Oct 14 03:08:12 2017

Reland "MD Settings: Migrate settings-toggle-button to use cr-toggle."

This is a reland of 4981992a59666d142faee96f400a01b6fdb73f02
Original change's description:
> MD Settings: Migrate settings-toggle-button to use cr-toggle.
> 
> Bug:  768073 
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: If3efa3993d9ff75cce73eb48d583adb0ea5db543
> Reviewed-on: https://chromium-review.googlesource.com/686041
> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
> Reviewed-by: Scott Chen <scottchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#505269}

Bug:  768073 
Change-Id: I1926a5763c4331008f3734b4a977c5ecf3aedd82
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/709874
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508919}
[modify] https://crrev.com/f423bc1ae49988cc5be11c16fd7fd137b84da587/chrome/browser/resources/settings/controls/compiled_resources2.gyp
[modify] https://crrev.com/f423bc1ae49988cc5be11c16fd7fd137b84da587/chrome/browser/resources/settings/controls/settings_toggle_button.html
[modify] https://crrev.com/f423bc1ae49988cc5be11c16fd7fd137b84da587/chrome/browser/resources/settings/controls/settings_toggle_button.js
[modify] https://crrev.com/f423bc1ae49988cc5be11c16fd7fd137b84da587/ui/webui/resources/cr_elements/cr_toggle/cr_toggle.js

Comment 5 by dpa...@chromium.org, Nov 18 2017

Status: Started (was: Assigned)
Some more migrations are at https://chromium-review.googlesource.com/c/chromium/src/+/778081.

After that CL lands, the remaining usages of paper-toggle-button will be:
chromeos/emulator/input_device_settings.html
chromeos/login/oobe_a11y_option.html
chromeos/login/oobe_a11y_option.css
chromeos/login/oobe_a11y_option.js
settings/internet_page/network_summary_item.html
settings/internet_page/internet_subpage.html
settings/internet_page/internet_detail_page.html
settings/settings_shared_css.html
settings/bluetooth_page/bluetooth_page.html
settings/bluetooth_page/bluetooth_subpage.html

So getting much closer.
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00df3e9c3dc77b99352ba5927725d5bcda58e9c3

commit 00df3e9c3dc77b99352ba5927725d5bcda58e9c3
Author: dpapad <dpapad@chromium.org>
Date: Tue Nov 21 01:37:16 2017

Settings WebUI: Migrate more paper-toggle-button to cr-toggle.

This is in preparation of removing paper-toggle-button from third_party/polymer.

Bug:  768073 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I78953704df46ea3f209b0cccc7e550e9338ab882
Reviewed-on: https://chromium-review.googlesource.com/778081
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518041}
[modify] https://crrev.com/00df3e9c3dc77b99352ba5927725d5bcda58e9c3/chrome/browser/resources/settings/date_time_page/date_time_page.html
[modify] https://crrev.com/00df3e9c3dc77b99352ba5927725d5bcda58e9c3/chrome/browser/resources/settings/device_page/display.html
[modify] https://crrev.com/00df3e9c3dc77b99352ba5927725d5bcda58e9c3/chrome/browser/resources/settings/device_page/stylus.html
[modify] https://crrev.com/00df3e9c3dc77b99352ba5927725d5bcda58e9c3/chrome/browser/resources/settings/languages_page/languages_page.html
[modify] https://crrev.com/00df3e9c3dc77b99352ba5927725d5bcda58e9c3/chrome/browser/resources/settings/people_page/manage_profile.html
[modify] https://crrev.com/00df3e9c3dc77b99352ba5927725d5bcda58e9c3/chrome/browser/resources/settings/people_page/sync_page.html
[modify] https://crrev.com/00df3e9c3dc77b99352ba5927725d5bcda58e9c3/chrome/browser/resources/settings/site_settings/protocol_handlers.html
[modify] https://crrev.com/00df3e9c3dc77b99352ba5927725d5bcda58e9c3/chrome/test/data/webui/settings/languages_page_tests.js
[modify] https://crrev.com/00df3e9c3dc77b99352ba5927725d5bcda58e9c3/chrome/test/data/webui/settings/people_page_sync_page_test.js

Comment 7 by dpa...@chromium.org, Apr 12 2018

Blocking: 832184
Blocking: 735489
Project Member

Comment 9 by bugdroid1@chromium.org, May 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79985f94e043bd4de3f3652a19f4b7698291cdd7

commit 79985f94e043bd4de3f3652a19f4b7698291cdd7
Author: dpapad <dpapad@chromium.org>
Date: Fri May 04 01:09:23 2018

WebUI: Simplify cr-toggle case of finishing drag gesture outside element.

Previous code was working around crbug.com/689158 and  crbug.com/768555 .
New code still works around them, but without requiring JS logic to do so,
achieved by wrapping the cr-toggle contents with a <button>.

Bug:  768073 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I435f6a44979a934b8548b13bdbd947d324eab5c5
Reviewed-on: https://chromium-review.googlesource.com/1040683
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555944}
[modify] https://crrev.com/79985f94e043bd4de3f3652a19f4b7698291cdd7/chrome/browser/resources/md_extensions/toggle_row.html
[modify] https://crrev.com/79985f94e043bd4de3f3652a19f4b7698291cdd7/chrome/browser/resources/md_extensions/toggle_row.js
[modify] https://crrev.com/79985f94e043bd4de3f3652a19f4b7698291cdd7/chrome/browser/resources/settings/controls/settings_toggle_button.js
[modify] https://crrev.com/79985f94e043bd4de3f3652a19f4b7698291cdd7/chrome/test/data/webui/cr_elements/cr_toggle_test.js
[modify] https://crrev.com/79985f94e043bd4de3f3652a19f4b7698291cdd7/chrome/test/data/webui/extensions/a11y/extensions_a11y_test.js
[modify] https://crrev.com/79985f94e043bd4de3f3652a19f4b7698291cdd7/chrome/test/data/webui/settings/a11y/basic_a11y_test.js
[modify] https://crrev.com/79985f94e043bd4de3f3652a19f4b7698291cdd7/chrome/test/data/webui/settings/a11y/edit_dictionary_a11y_test.js
[modify] https://crrev.com/79985f94e043bd4de3f3652a19f4b7698291cdd7/chrome/test/data/webui/settings/a11y/manage_profile_a11y_test.js
[modify] https://crrev.com/79985f94e043bd4de3f3652a19f4b7698291cdd7/chrome/test/data/webui/settings/a11y/passwords_a11y_test.js
[modify] https://crrev.com/79985f94e043bd4de3f3652a19f4b7698291cdd7/chrome/test/data/webui/settings/a11y/settings_accessibility_test.js
[modify] https://crrev.com/79985f94e043bd4de3f3652a19f4b7698291cdd7/ui/webui/resources/cr_elements/cr_toggle/cr_toggle.html
[modify] https://crrev.com/79985f94e043bd4de3f3652a19f4b7698291cdd7/ui/webui/resources/cr_elements/cr_toggle/cr_toggle.js

Project Member

Comment 10 by bugdroid1@chromium.org, May 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e094a6f4cf4d8d7f7570aacfbb315f01b0745faf

commit e094a6f4cf4d8d7f7570aacfbb315f01b0745faf
Author: dpapad <dpapad@chromium.org>
Date: Sat May 05 02:29:13 2018

CrOS Settings: Migrate internet_page/ from paper-toggle-button to cr-toggle.

This is in preparation of updating cr-toggle's style for MD refresh, as well
as removing paper-toggle-button from third_party/polymer.

Bug:  768073 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie9433c5789baeefdeed21e6d5f81fad80608e8d3
Reviewed-on: https://chromium-review.googlesource.com/1043049
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556295}
[modify] https://crrev.com/e094a6f4cf4d8d7f7570aacfbb315f01b0745faf/chrome/browser/resources/settings/internet_page/internet_detail_page.html
[modify] https://crrev.com/e094a6f4cf4d8d7f7570aacfbb315f01b0745faf/chrome/browser/resources/settings/internet_page/internet_subpage.html
[modify] https://crrev.com/e094a6f4cf4d8d7f7570aacfbb315f01b0745faf/chrome/browser/resources/settings/internet_page/internet_subpage.js
[modify] https://crrev.com/e094a6f4cf4d8d7f7570aacfbb315f01b0745faf/chrome/browser/resources/settings/internet_page/network_summary_item.html
[modify] https://crrev.com/e094a6f4cf4d8d7f7570aacfbb315f01b0745faf/chrome/browser/resources/settings/internet_page/network_summary_item.js

Project Member

Comment 11 by bugdroid1@chromium.org, May 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7aaf8265a31b470f8c587d083c928358acc8e05f

commit 7aaf8265a31b470f8c587d083c928358acc8e05f
Author: dpapad <dpapad@chromium.org>
Date: Sat May 05 05:55:38 2018

CrOS Settings: Migrate bluetooth_page/ from paper-toggle-button to cr-toggle.

This is in preparation of updating cr-toggle's style for MD refresh, as well
as removing paper-toggle-button from third_party/polymer.

Bug:  768073 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic26a8cd965319e5be453398e68eb49fec556910a
Reviewed-on: https://chromium-review.googlesource.com/1043448
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556307}
[modify] https://crrev.com/7aaf8265a31b470f8c587d083c928358acc8e05f/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html
[modify] https://crrev.com/7aaf8265a31b470f8c587d083c928358acc8e05f/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.js
[modify] https://crrev.com/7aaf8265a31b470f8c587d083c928358acc8e05f/chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.html
[modify] https://crrev.com/7aaf8265a31b470f8c587d083c928358acc8e05f/chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.js

Status update: Remaining usages of paper-toggle-button are at

chrome/browser/resources/chromeos/login/oobe_eula.html
chrome/browser/resources/chromeos/emulator/input_device_settings.html
ui/webui/resources/cr_components/chromeos/network/network_siminfo.html
ui/webui/resources/cr_components/chromeos/network/network_proxy.html
ui/webui/resources/cr_components/chromeos/network/network_config.html
ui/webui/resources/cr_components/chromeos/network/network_ip_config.html

I'll give it a shot to convert these, so that paper-toggle-button can be fully removed from third_party/polymer.
Project Member

Comment 14 by bugdroid1@chromium.org, May 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49544f4c979f84da35d0add6d006609e481c887e

commit 49544f4c979f84da35d0add6d006609e481c887e
Author: dpapad <dpapad@chromium.org>
Date: Mon May 07 22:13:16 2018

CrOS Device emulator: Replace usage of paper-toggle-button with cr-toggle.

Bug:  768073 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id56c5c360e17d09d0f4f806da9a18c43a25a6e6b
Reviewed-on: https://chromium-review.googlesource.com/1048032
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556585}
[modify] https://crrev.com/49544f4c979f84da35d0add6d006609e481c887e/chrome/browser/resources/chromeos/emulator/input_device_settings.html

Project Member

Comment 15 by bugdroid1@chromium.org, May 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e8093de88920a27ac3e3c2a1c0330ac3124de33

commit 4e8093de88920a27ac3e3c2a1c0330ac3124de33
Author: dpapad <dpapad@chromium.org>
Date: Tue May 08 21:59:50 2018

OOBE WebUI: Replace paper-toggle-button with cr-toggle in oobe-a11y-option.

This is in preparation of updating cr-toggle's style for MD refresh, as well
as removing paper-toggle-button from third_party/polymer.

Bug:  768073 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9deb661359b3e61de873f46d0ab201c2d3ff1502
Reviewed-on: https://chromium-review.googlesource.com/1050579
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556976}
[modify] https://crrev.com/4e8093de88920a27ac3e3c2a1c0330ac3124de33/chrome/browser/resources/chromeos/login/oobe_a11y_option.css
[modify] https://crrev.com/4e8093de88920a27ac3e3c2a1c0330ac3124de33/chrome/browser/resources/chromeos/login/oobe_a11y_option.html
[modify] https://crrev.com/4e8093de88920a27ac3e3c2a1c0330ac3124de33/chrome/browser/resources/chromeos/login/oobe_a11y_option.js

Cc: wzang@chromium.org
Status update for OOBE:

 1) Landed: https://chromium-review.googlesource.com/1050579
 2) In review: https://chromium-review.googlesource.com/1051046

Note that 1 caused a temporary regression, reveasing that OOBE is relying on implicit HTML imports (which is very fragile BTW and should be fixed regardless). 2 is updating the last paper-toggle-button usage and as a result also fixes the regression caused by 1.
Project Member

Comment 17 by bugdroid1@chromium.org, May 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c564fe39f7c22d1de25874927d14cd0158bb772

commit 5c564fe39f7c22d1de25874927d14cd0158bb772
Author: dpapad <dpapad@chromium.org>
Date: Wed May 09 19:30:44 2018

CrOS Settings: Migrate remaining paper-toggle-button to cr-toggle.

This is effectively applying MD refresh toggle style, as well
as preparing for removing paper-toggle-button from third_party/polymer.

Bug:  768073 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I90c3eb4098304b3ca707665d52bb6b54e67bdce6
Reviewed-on: https://chromium-review.googlesource.com/1048167
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557271}
[modify] https://crrev.com/5c564fe39f7c22d1de25874927d14cd0158bb772/chrome/browser/resources/settings/settings_shared_css.html
[modify] https://crrev.com/5c564fe39f7c22d1de25874927d14cd0158bb772/ui/webui/resources/cr_components/chromeos/network/network_config.html
[modify] https://crrev.com/5c564fe39f7c22d1de25874927d14cd0158bb772/ui/webui/resources/cr_components/chromeos/network/network_ip_config.html
[modify] https://crrev.com/5c564fe39f7c22d1de25874927d14cd0158bb772/ui/webui/resources/cr_components/chromeos/network/network_proxy.html
[modify] https://crrev.com/5c564fe39f7c22d1de25874927d14cd0158bb772/ui/webui/resources/cr_components/chromeos/network/network_siminfo.html
[delete] https://crrev.com/b1bb32f529ca2271028c164fc563f945e5d6100e/ui/webui/resources/cr_elements/paper_toggle_style_css.html
[modify] https://crrev.com/5c564fe39f7c22d1de25874927d14cd0158bb772/ui/webui/resources/cr_elements_resources.grdp

Project Member

Comment 18 by bugdroid1@chromium.org, May 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9cf01c9f387de2ab7b3a0780f7993715eabd5946

commit 9cf01c9f387de2ab7b3a0780f7993715eabd5946
Author: dpapad <dpapad@chromium.org>
Date: Wed May 09 20:51:45 2018

OOBE WebUI: Replace paper-toggle-button with cr-toggle in oobe-eula-md.

This is in preparation of updating cr-toggle's style for MD refresh, as well
as removing paper-toggle-button from third_party/polymer.

Bug:  768073 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I52690906a1f73778358cde1da605e762a44b4f78
Reviewed-on: https://chromium-review.googlesource.com/1051046
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557310}
[modify] https://crrev.com/9cf01c9f387de2ab7b3a0780f7993715eabd5946/chrome/browser/resources/chromeos/login/oobe_a11y_option.html
[modify] https://crrev.com/9cf01c9f387de2ab7b3a0780f7993715eabd5946/chrome/browser/resources/chromeos/login/oobe_eula.css
[modify] https://crrev.com/9cf01c9f387de2ab7b3a0780f7993715eabd5946/chrome/browser/resources/chromeos/login/oobe_eula.html
[delete] https://crrev.com/ed353509d36e0c2dc2df427861f70bd2f5e12b5c/chrome/browser/resources/chromeos/login/oobe_toggle_button.css

Final CL removing paper-toggle-button from third_party is at https://chromium-review.googlesource.com/c/chromium/src/+/1053416.
Cc: dpa...@chromium.org bettes@chromium.org hdodda@chromium.org tbuck...@chromium.org
 Issue 735489  has been merged into this issue.
Project Member

Comment 21 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87c70f1d6fadfcbd580641d3769ea520ca352924

commit 87c70f1d6fadfcbd580641d3769ea520ca352924
Author: dpapad <dpapad@chromium.org>
Date: Thu May 10 18:48:31 2018

WebUI Polymer: Remove paper-toggle-button from third_party/polymer.

The element is no longer used. All usages have been migrated to cr-toggle.

Bug:  768073 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia02580497b901732defdbc7e75fc4eaedf2b0413
Reviewed-on: https://chromium-review.googlesource.com/1053416
Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557603}
[modify] https://crrev.com/87c70f1d6fadfcbd580641d3769ea520ca352924/chrome/browser/resources/settings/settings_shared_css.html
[modify] https://crrev.com/87c70f1d6fadfcbd580641d3769ea520ca352924/third_party/polymer/v1_0/bower.json
[delete] https://crrev.com/3269695c3d558a1d7b886418c996d4e2ff77fc5d/third_party/polymer/v1_0/components-chromium/paper-toggle-button/BUILD.gn
[delete] https://crrev.com/3269695c3d558a1d7b886418c996d4e2ff77fc5d/third_party/polymer/v1_0/components-chromium/paper-toggle-button/bower.json
[delete] https://crrev.com/3269695c3d558a1d7b886418c996d4e2ff77fc5d/third_party/polymer/v1_0/components-chromium/paper-toggle-button/compiled_resources2.gyp
[delete] https://crrev.com/3269695c3d558a1d7b886418c996d4e2ff77fc5d/third_party/polymer/v1_0/components-chromium/paper-toggle-button/paper-toggle-button-extracted.js
[delete] https://crrev.com/3269695c3d558a1d7b886418c996d4e2ff77fc5d/third_party/polymer/v1_0/components-chromium/paper-toggle-button/paper-toggle-button.html
[modify] https://crrev.com/87c70f1d6fadfcbd580641d3769ea520ca352924/ui/webui/resources/polymer_resources.grdp

Status: Fixed (was: Started)

Sign in to add a comment