Back button does not show up in hebrew |
||||||||
Issue descriptionChrome Version: M61 Tot What steps will reproduce the problem? (1) put device in Hebrew or any RTL language What is the expected result? Back button shows up on the right side. What happens instead? Back button is invisible.
,
Sep 25 2017
Actually, it shouldve been merged here https://chromium-review.googlesource.com/c/chromium/src/+/619451. Let me investigate this tomorrow.
,
Sep 26 2017
Reproed again with sammiequon@ 61.3163.101. It's either an Eve M61 issue, or a hebrew M61 issue. Sammiequon@ couldn't see the issue emulating ToT M61 chromeOS on linux.
,
Sep 26 2017
Re#1 Yes please.
,
Sep 26 2017
Just repo'ed on a kevin as well, and on ToT (non m61). Working on this now.
,
Sep 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f7fde4b94712922ea68b740dd7e5d0db914b82d3 commit f7fde4b94712922ea68b740dd7e5d0db914b82d3 Author: Sammie Quon <sammiequon@google.com> Date: Wed Sep 27 21:36:47 2017 vector icon: Switch ordering of transforms in rtl paint vector icon. Vector icons with FLIPS_IN_RTL get shown. Right now there are only the submenu arrow and the tablet mode back button which uses this command. This also only happens when using the 2x icon. The current transforms applied on rtl 2x icons are: - scale down by factor of 2 - scale by -1 - translate by the canvas size This results in the icon being translated out of its bounds and not being shown. This cl does the scaling down after the translation. Test: gfx_unittests VectorIconTest.FlipsInRtl Bug: 769366 , 768059 Change-Id: I67e748ea23c9020f13a693546db2fade07e05ae6 Reviewed-on: https://chromium-review.googlesource.com/687826 Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#504776} [modify] https://crrev.com/f7fde4b94712922ea68b740dd7e5d0db914b82d3/ui/gfx/paint_vector_icon.cc [modify] https://crrev.com/f7fde4b94712922ea68b740dd7e5d0db914b82d3/ui/gfx/paint_vector_icon_unittest.cc
,
Sep 27 2017
,
Sep 27 2017
Approved for 62, but please verify a Chrome with this change makes it through the PFQ before merging back.
,
Sep 28 2017
Approving merge for M61.
,
Oct 2 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 2 2017
,
Oct 13 2017
,
Nov 14 2017
Back button shows up and works for rtl languages, on M64 dev build (10124.0.0, 64.0.3265.0). |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by sammiequon@chromium.org
, Sep 25 2017Labels: OS-Chrome