When scanning for hosts, prioritize newly-updated devices first |
||||||||||
Issue descriptionCurrent logic: (1) Most-recently connected. (2) Most-recently responded to TetherAvailabilityRequest. New logic: (1) Most-recently connected. (2) Most-recently responded to TetherAvailabilityRequest. (3) Most-recently updated on CryptAuth. This will ensure that for users with tons of phones (e.g., Google engineers or tech bloggers), devices which are more likely to be nearby are scanned for first.
,
Sep 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/adafedd1ace0dd3738039df98f15cd42486b6275 commit adafedd1ace0dd3738039df98f15cd42486b6275 Author: Ryan Hansberry <hansberry@chromium.org> Date: Sat Sep 23 02:41:41 2017 HostScanDevicePrioritizer: Pre-sort RemoteDevices by their last update timestamp, with most recently updated first. Bug: 768056 Change-Id: Id39e600ec003bfdd5ca9585d2079846430ee57c1 Reviewed-on: https://chromium-review.googlesource.com/679995 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#503934} [modify] https://crrev.com/adafedd1ace0dd3738039df98f15cd42486b6275/chromeos/components/tether/host_scan_device_prioritizer_impl.cc [modify] https://crrev.com/adafedd1ace0dd3738039df98f15cd42486b6275/chromeos/components/tether/host_scan_device_prioritizer_impl_unittest.cc
,
Sep 23 2017
,
Sep 23 2017
Approving merge to M61.
,
Sep 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd27fec1f12d1102aae57fa11084d8975cdedd72 commit dd27fec1f12d1102aae57fa11084d8975cdedd72 Author: Kyle Horimoto <khorimoto@google.com> Date: Sat Sep 23 06:30:45 2017 Add a last update timestamp to RemoteDevice. TBR=hansberry@chromium.org (cherry picked from commit a2aa7d8ff137c99baa8d250089cad974550ea0eb) Bug: 768056 Change-Id: I750231eb64b90ad35f71feb419ca92862fb2f1c2 Reviewed-on: https://chromium-review.googlesource.com/679484 Reviewed-by: Tim Song <tengs@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#503924} Reviewed-on: https://chromium-review.googlesource.com/679997 Cr-Commit-Position: refs/branch-heads/3202@{#414} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/dd27fec1f12d1102aae57fa11084d8975cdedd72/chrome/browser/signin/easy_unlock_service_signin_chromeos.cc [modify] https://crrev.com/dd27fec1f12d1102aae57fa11084d8975cdedd72/components/cryptauth/cryptauth_test_util.cc [modify] https://crrev.com/dd27fec1f12d1102aae57fa11084d8975cdedd72/components/cryptauth/cryptauth_test_util.h [modify] https://crrev.com/dd27fec1f12d1102aae57fa11084d8975cdedd72/components/cryptauth/remote_device.cc [modify] https://crrev.com/dd27fec1f12d1102aae57fa11084d8975cdedd72/components/cryptauth/remote_device.h [modify] https://crrev.com/dd27fec1f12d1102aae57fa11084d8975cdedd72/components/cryptauth/remote_device_loader.cc [modify] https://crrev.com/dd27fec1f12d1102aae57fa11084d8975cdedd72/components/cryptauth/remote_device_loader_unittest.cc [modify] https://crrev.com/dd27fec1f12d1102aae57fa11084d8975cdedd72/components/proximity_auth/proximity_auth_system_unittest.cc [modify] https://crrev.com/dd27fec1f12d1102aae57fa11084d8975cdedd72/components/proximity_auth/proximity_monitor_impl_unittest.cc
,
Sep 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/549c1b1b9cd667c567cd687c169a8cff172ccc5a commit 549c1b1b9cd667c567cd687c169a8cff172ccc5a Author: Kyle Horimoto <khorimoto@google.com> Date: Sat Sep 23 06:46:20 2017 Add a last update timestamp to RemoteDevice. TBR=hansberry@chromium.org (cherry picked from commit a2aa7d8ff137c99baa8d250089cad974550ea0eb) Bug: 768056 Change-Id: I750231eb64b90ad35f71feb419ca92862fb2f1c2 Reviewed-on: https://chromium-review.googlesource.com/679484 Reviewed-by: Tim Song <tengs@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#503924} Reviewed-on: https://chromium-review.googlesource.com/680095 Cr-Commit-Position: refs/branch-heads/3163@{#1271} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/549c1b1b9cd667c567cd687c169a8cff172ccc5a/chrome/browser/signin/easy_unlock_service_signin_chromeos.cc [modify] https://crrev.com/549c1b1b9cd667c567cd687c169a8cff172ccc5a/components/cryptauth/cryptauth_test_util.cc [modify] https://crrev.com/549c1b1b9cd667c567cd687c169a8cff172ccc5a/components/cryptauth/cryptauth_test_util.h [modify] https://crrev.com/549c1b1b9cd667c567cd687c169a8cff172ccc5a/components/cryptauth/remote_device.cc [modify] https://crrev.com/549c1b1b9cd667c567cd687c169a8cff172ccc5a/components/cryptauth/remote_device.h [modify] https://crrev.com/549c1b1b9cd667c567cd687c169a8cff172ccc5a/components/cryptauth/remote_device_loader.cc [modify] https://crrev.com/549c1b1b9cd667c567cd687c169a8cff172ccc5a/components/cryptauth/remote_device_loader_unittest.cc [modify] https://crrev.com/549c1b1b9cd667c567cd687c169a8cff172ccc5a/components/proximity_auth/proximity_auth_system_unittest.cc [modify] https://crrev.com/549c1b1b9cd667c567cd687c169a8cff172ccc5a/components/proximity_auth/proximity_monitor_impl_unittest.cc
,
Sep 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd76740e8a3439c9cbae0fa67d0e711a06d03dab commit dd76740e8a3439c9cbae0fa67d0e711a06d03dab Author: Kyle Horimoto <khorimoto@google.com> Date: Sat Sep 23 06:47:41 2017 HostScanDevicePrioritizer: Pre-sort RemoteDevices by their last update timestamp, with most recently updated first. TBR=hansberry@chromium.org (cherry picked from commit adafedd1ace0dd3738039df98f15cd42486b6275) Bug: 768056 Change-Id: Id39e600ec003bfdd5ca9585d2079846430ee57c1 Reviewed-on: https://chromium-review.googlesource.com/679995 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#503934} Reviewed-on: https://chromium-review.googlesource.com/680097 Cr-Commit-Position: refs/branch-heads/3202@{#415} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/dd76740e8a3439c9cbae0fa67d0e711a06d03dab/chromeos/components/tether/host_scan_device_prioritizer_impl.cc [modify] https://crrev.com/dd76740e8a3439c9cbae0fa67d0e711a06d03dab/chromeos/components/tether/host_scan_device_prioritizer_impl_unittest.cc
,
Sep 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/18e2e58f63e24c54a02e7a8feceb0cc7f2e9f560 commit 18e2e58f63e24c54a02e7a8feceb0cc7f2e9f560 Author: Kyle Horimoto <khorimoto@google.com> Date: Sat Sep 23 06:48:49 2017 HostScanDevicePrioritizer: Pre-sort RemoteDevices by their last update timestamp, with most recently updated first. TBR=hansberry@chromium.org (cherry picked from commit adafedd1ace0dd3738039df98f15cd42486b6275) Bug: 768056 Change-Id: Id39e600ec003bfdd5ca9585d2079846430ee57c1 Reviewed-on: https://chromium-review.googlesource.com/679995 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#503934} Reviewed-on: https://chromium-review.googlesource.com/680098 Cr-Commit-Position: refs/branch-heads/3163@{#1272} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/18e2e58f63e24c54a02e7a8feceb0cc7f2e9f560/chromeos/components/tether/host_scan_device_prioritizer_impl.cc [modify] https://crrev.com/18e2e58f63e24c54a02e7a8feceb0cc7f2e9f560/chromeos/components/tether/host_scan_device_prioritizer_impl_unittest.cc
,
Sep 23 2017
,
Sep 24 2017
This bug requires manual review: M62 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 25 2017
,
Sep 29 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 2 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 30
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by bugdroid1@chromium.org
, Sep 23 2017