New issue
Advanced search Search tips

Issue 768051 link

Starred by 1 user
Status: Verified
Owner:
manojgupta@chromium.org
Closed: Oct 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

llvm-next r312858 compiler-rt is broken

Project Member Reported by manojgupta@chromium.org, Sep 22 2017 
Daisy Unit tests failed after trying to test new llvm-next.

https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/llvm_next_toolchain/builds/709

Root cause is compiler-rt: 
r312858 Fails
r310330 Passes

Comment 1 by manojgupta@chromium.org, Sep 22 2017 

Bisection shows following to be the bad commit:

commit 4ae44f4ac154fc0bb0458f33c4c6bef0837d9fa8
Author: Weiming Zhao <weimingz@codeaurora.org>
Date:   Mon Aug 14 20:48:47 2017 +0000

    [builtins][ARM] Select correct code fragments when compiling for Thumb1/Thum2/ARM ISA
    
    Summary:
    Value of __ARM_ARCH_ISA_THUMB isn't based on the actual compilation
     mode (-mthumb, -marm), it reflect's capability of given CPU.
    
    Due to this:
    •use tbumb and thumb2 insteand of __ARM_ARCH_ISA_THUMB
    •use '.thumb' directive consistently in all affected files
    •decorate all thumb functions using DEFINE_COMPILERRT_THUMB_FUNCTION()
    
    (This is based off  Michal's patch https://reviews.llvm.org/D30938)
    
    Reviewers: dim, rengolin, compnerd, strejda

Comment 2 by manojgupta@chromium.org, Sep 25 2017 

Upstream fix in review @ https://reviews.llvm.org/D38227

Comment 3 by manojgupta@chromium.org, Sep 25 2017

Owner: manojgupta@chromium.org
Status: Started (was: Untriaged)

Comment 4 by manojgupta@chromium.org, Sep 27 2017 

The upstrem review was approved and committed but had to revert because of a watchos builder breaakge. Proposed a patch and waiting for Apple's reply before relanding it.

Comment 6 by manojgupta@chromium.org, Oct 7 2017

Status: Verified (was: Started)
Upstream issue is now fixed. Closing.

Comment 7 by manojgupta@chromium.org, Feb 5 2018

Labels: compiler-rt-migration
►

Sign in to add a comment