New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 768043 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 3
Type: Bug



Sign in to add a comment

QuicStreamFactoryJob uses priority LOWEST for all its DNS requests

Project Member Reported by mge...@chromium.org, Sep 22 2017

Issue description

https://cs.chromium.org/chromium/src/net/quic/chromium/quic_stream_factory.cc?type=cs&l=513

I'd add statistics on how much of a problem this is, but the UMA dashboard isn't loading. My guess is it's pretty minor.
 

Comment 1 by rch@chromium.org, Nov 10 2017

Owner: wangyix@chromium.org
wangyix: Can you take a look at this? it should be fairly straight forward to plumb the request priority down through the stream request and into the resolver.
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/247ea64167abfb6e96d0baa3fbbcb99a74f4c01a

commit 247ea64167abfb6e96d0baa3fbbcb99a74f4c01a
Author: Yixin Wang <wangyix@chromium.org>
Date: Wed Nov 15 01:15:50 2017

Use the request priority in QuicStreamFactory::Job's host resolution step instead of DEFAULT_PRIORITY

This adds a RequestPriority param to QuicStreamRequest::Request()

Bug:  768043 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I9feb7f4d66eb971e6c66aa444317116c03dbdc2e
Reviewed-on: https://chromium-review.googlesource.com/767853
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Yixin Wang <wangyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516542}
[modify] https://crrev.com/247ea64167abfb6e96d0baa3fbbcb99a74f4c01a/net/http/http_proxy_client_socket_wrapper.cc
[modify] https://crrev.com/247ea64167abfb6e96d0baa3fbbcb99a74f4c01a/net/http/http_stream_factory_impl_job.cc
[modify] https://crrev.com/247ea64167abfb6e96d0baa3fbbcb99a74f4c01a/net/quic/chromium/quic_stream_factory.cc
[modify] https://crrev.com/247ea64167abfb6e96d0baa3fbbcb99a74f4c01a/net/quic/chromium/quic_stream_factory.h
[modify] https://crrev.com/247ea64167abfb6e96d0baa3fbbcb99a74f4c01a/net/quic/chromium/quic_stream_factory_fuzzer.cc
[modify] https://crrev.com/247ea64167abfb6e96d0baa3fbbcb99a74f4c01a/net/quic/chromium/quic_stream_factory_test.cc

Status: Fixed (was: Assigned)

Sign in to add a comment