New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 768027 link

Starred by 1 user
Status: Fixed
Owner:
█ timbrown@chromium.org
Last visit > 30 days ago
Closed: Dec 2017
Cc:
thestig@chromium.org
thomasanderson@chromium.org
dpranke@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Switch Linux dependency on gconf to dconf

Project Member Reported by thomasanderson@chromium.org, Sep 22 2017 
gconf is an obsolete utility that was used for getting system settings in the GNOME2 era.  Now, all of our supported distros have switched to dconf, and it's where apps store their settings nowadays.  Additionally, gconf is only community-maintained on Ubuntu through the universe repo.

Outline of the necessary steps:
1. Add dconf to install-build-deps.sh
2. Ask Chrome labs to add dconf to bot puppet config
3. Add dconf to sysroots
4. Add dconf to instrumented libraries
5. Allow dconf dependency in Linux packages
6. Add use_dconf gn argument, and set it to the same condition as use_gconf today
7. Begin switching all USE_GCONF-guarded code to USE_DCONF (the real meat of the project)
8. Remove the use_gconf gn arg
9. Remove gconf from the allowed Linux package deps
10. Remove gconf from instrumented libs
11. Remove gconf from sysroots
12. Remove gconf from install-build-deps.sh

Comment 1 by timbrown@chromium.org, Sep 28 2017

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b267c0c4ffb22f07bea43853567c0b8a2ab9c21

commit 5b267c0c4ffb22f07bea43853567c0b8a2ab9c21
Author: Tim Brown <timbrown@chromium.org>
Date: Thu Sep 28 22:08:00 2017

Add libdconf-dev to to install-build-deps.sh

This is the first step in moving from using gconf to dconf.

Bug:  768027 
Change-Id: Ifb05a6679c38e115b322e0a7caa6c3aad309389e
Reviewed-on: https://chromium-review.googlesource.com/691097
Commit-Queue: Tim Brown <timbrown@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505183}
[modify] https://crrev.com/5b267c0c4ffb22f07bea43853567c0b8a2ab9c21/build/install-build-deps.sh

Comment 3 by dgolovchenko@google.com, Sep 29 2017 

https://chromium-review.googlesource.com/c/chromium/src/+/691097 broke install-build-deps.sh:

on goobuntu-trusty_desktop-stable-amd64 it cause conflict of packages:

The following packages have unmet dependencies:
 libdconf-dev : Conflicts: libdconf-dev:i386 but 0.20.0-1 is to be installed
 libdconf-dev:i386 : Depends: libglib2.0-dev:i386 (>= 2.25.7) but it is not going to be installed
                     Recommends: libdconf-doc:i386 but it is not installable
                     Conflicts: libdconf-dev but 0.20.0-1 is to be installed
E: Unable to correct problems, you have held broken packages.

Also PTAL on similar report: https://www.google.com/url?q=https://chromium-review.googlesource.com/c/chromium/src/%2B/691097%23message-78e4c1614154ec0f547d27556aaaa426f842285f&sa=D&usg=AFQjCNEBt8BbnzJfmRgibBYR1ZZhkeAPrw
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3cd469287f3ce7290d3bfe3f1971aa529b6b1303

commit 3cd469287f3ce7290d3bfe3f1971aa529b6b1303
Author: Dmytro Golovchenko <dgolovchenko@google.com>
Date: Fri Sep 29 16:40:27 2017

Revert "Add libdconf-dev to to install-build-deps.sh"

Script is failing on goobuntu-trusty_desktop-stable-amd64 due to packages conflict:
The following packages have unmet dependencies:
 libdconf-dev : Conflicts: libdconf-dev:i386 but 0.20.0-1 is to be installed
 libdconf-dev:i386 : Depends: libglib2.0-dev:i386 (>= 2.25.7) but it is not going to be installed
                     Recommends: libdconf-doc:i386 but it is not installable
                     Conflicts: libdconf-dev but 0.20.0-1 is to be installed

This reverts commit 5b267c0c4ffb22f07bea43853567c0b8a2ab9c21.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Add libdconf-dev to to install-build-deps.sh
> 
> This is the first step in moving from using gconf to dconf.
> 
> Bug:  768027 
> Change-Id: Ifb05a6679c38e115b322e0a7caa6c3aad309389e
> Reviewed-on: https://chromium-review.googlesource.com/691097
> Commit-Queue: Tim Brown <timbrown@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#505183}

TBR=dpranke@chromium.org,thomasanderson@chromium.org,timbrown@chromium.org

Change-Id: Icec37c78711a2016667ee7f134d5db49b918b7d2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  768027 
Reviewed-on: https://chromium-review.googlesource.com/692974
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505391}
[modify] https://crrev.com/3cd469287f3ce7290d3bfe3f1971aa529b6b1303/build/install-build-deps.sh
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/357bdbf7f33061d9ecf3052813cced0e9da45498

commit 357bdbf7f33061d9ecf3052813cced0e9da45498
Author: Tim Brown <timbrown@chromium.org>
Date: Fri Sep 29 19:11:29 2017

Reland "Add libdconf-dev to to install-build-deps.sh"

Test: Manually installed packages to make sure no conflict

This is a reland of 5b267c0c4ffb22f07bea43853567c0b8a2ab9c21
Original change's description:
> Add libdconf-dev to to install-build-deps.sh
> 
> This is the first step in moving from using gconf to dconf.
> 
> Bug:  768027 
> Change-Id: Ifb05a6679c38e115b322e0a7caa6c3aad309389e
> Reviewed-on: https://chromium-review.googlesource.com/691097
> Commit-Queue: Tim Brown <timbrown@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#505183}

Bug:  768027 
Change-Id: I151d1c1e708fa763f3d2d5a4a18b44bfdbe351fd
Reviewed-on: https://chromium-review.googlesource.com/692616
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Tim Brown <timbrown@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505437}
[modify] https://crrev.com/357bdbf7f33061d9ecf3052813cced0e9da45498/build/install-build-deps.sh
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 29 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/puppet/+/73839e89c57bac36d21e77fb916e19066091475a

commit 73839e89c57bac36d21e77fb916e19066091475a
Author: Tim Brown <timbrown@google.com>
Date: Fri Sep 29 20:58:27 2017
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95ecb913508e3dfc32afb93f6b930dc8d8514de9

commit 95ecb913508e3dfc32afb93f6b930dc8d8514de9
Author: Tim Brown <timbrown@chromium.org>
Date: Sun Oct 01 04:07:43 2017

Add dconf to the sysroot

There are also some security updates for some of the packages.

Bug:  768027 
Change-Id: Ibd2160d43e4f43f5344db8567c280cb154a96fc5
Reviewed-on: https://chromium-review.googlesource.com/693305
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Tim Brown <timbrown@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505500}
[modify] https://crrev.com/95ecb913508e3dfc32afb93f6b930dc8d8514de9/build/linux/sysroot_scripts/packagelist.jessie.amd64
[modify] https://crrev.com/95ecb913508e3dfc32afb93f6b930dc8d8514de9/build/linux/sysroot_scripts/packagelist.jessie.arm
[modify] https://crrev.com/95ecb913508e3dfc32afb93f6b930dc8d8514de9/build/linux/sysroot_scripts/packagelist.jessie.arm64
[modify] https://crrev.com/95ecb913508e3dfc32afb93f6b930dc8d8514de9/build/linux/sysroot_scripts/packagelist.jessie.i386
[modify] https://crrev.com/95ecb913508e3dfc32afb93f6b930dc8d8514de9/build/linux/sysroot_scripts/packagelist.jessie.mipsel
[modify] https://crrev.com/95ecb913508e3dfc32afb93f6b930dc8d8514de9/build/linux/sysroot_scripts/packagelist.stretch.amd64
[modify] https://crrev.com/95ecb913508e3dfc32afb93f6b930dc8d8514de9/build/linux/sysroot_scripts/packagelist.stretch.arm
[modify] https://crrev.com/95ecb913508e3dfc32afb93f6b930dc8d8514de9/build/linux/sysroot_scripts/packagelist.stretch.arm64
[modify] https://crrev.com/95ecb913508e3dfc32afb93f6b930dc8d8514de9/build/linux/sysroot_scripts/packagelist.stretch.i386
[modify] https://crrev.com/95ecb913508e3dfc32afb93f6b930dc8d8514de9/build/linux/sysroot_scripts/packagelist.stretch.mips64el
[modify] https://crrev.com/95ecb913508e3dfc32afb93f6b930dc8d8514de9/build/linux/sysroot_scripts/packagelist.stretch.mipsel
[modify] https://crrev.com/95ecb913508e3dfc32afb93f6b930dc8d8514de9/build/linux/sysroot_scripts/sysroot-creator-jessie.sh
[modify] https://crrev.com/95ecb913508e3dfc32afb93f6b930dc8d8514de9/build/linux/sysroot_scripts/sysroot-creator-stretch.sh
[modify] https://crrev.com/95ecb913508e3dfc32afb93f6b930dc8d8514de9/build/linux/sysroot_scripts/sysroots.json
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46e09597fd24e3c0e8e4d8a5413b71206b7fe2de

commit 46e09597fd24e3c0e8e4d8a5413b71206b7fe2de
Author: Tim Brown <timbrown@chromium.org>
Date: Fri Nov 17 03:10:16 2017

Add dconf to instrumented libraries

This is in preparation of the removal of the deprecated gconf.

Bug:  768027 
Change-Id: Id81087ceb304c4124b810544c2244fd3123f0ef6
Reviewed-on: https://chromium-review.googlesource.com/775360
Reviewed-by: Evgeniy Stepanov <eugenis@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Tim Brown <timbrown@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517267}
[modify] https://crrev.com/46e09597fd24e3c0e8e4d8a5413b71206b7fe2de/third_party/instrumented_libraries/BUILD.gn
[modify] https://crrev.com/46e09597fd24e3c0e8e4d8a5413b71206b7fe2de/third_party/instrumented_libraries/scripts/install-build-deps.sh
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81d3bb059b2f8cd273a62f1547c3f8af2a7b3d16

commit 81d3bb059b2f8cd273a62f1547c3f8af2a7b3d16
Author: Tim Brown <timbrown@chromium.org>
Date: Sat Nov 18 00:42:43 2017

Update sha1 for new instrumented libraries

The new libraries include dconf.

Bug:  768027 
Change-Id: I724aa27893f37891103de2cf0898d48ea7a4d406
Reviewed-on: https://chromium-review.googlesource.com/777968
Reviewed-by: Evgeniy Stepanov <eugenis@chromium.org>
Commit-Queue: Tim Brown <timbrown@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517636}
[modify] https://crrev.com/81d3bb059b2f8cd273a62f1547c3f8af2a7b3d16/third_party/instrumented_libraries/binaries/msan-chained-origins-trusty.tgz.sha1
[modify] https://crrev.com/81d3bb059b2f8cd273a62f1547c3f8af2a7b3d16/third_party/instrumented_libraries/binaries/msan-no-origins-trusty.tgz.sha1
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cfad42b16db127b4e6cdd2cd840a7849dc996b65

commit cfad42b16db127b4e6cdd2cd840a7849dc996b65
Author: Tim Brown <timbrown@chromium.org>
Date: Thu Dec 07 00:17:16 2017

Use GSettings to retrieve button layout

This will be the replacement backup way of getting the setting, rather
than using the deprecated gconf. I will remove the gconf code in a
separate CL.

gsettings app to change values and test behavior in chromium.

Test: Force use of gsettings for config (see patchset 3) and used
Bug:  768027 
Change-Id: I957edc5f03c20f42e74d0ba9d1e57a352cc2d418
Reviewed-on: https://chromium-review.googlesource.com/809730
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Elliot Glaysher <erg@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522266}
[modify] https://crrev.com/cfad42b16db127b4e6cdd2cd840a7849dc996b65/chrome/browser/ui/libgtkui/BUILD.gn
[modify] https://crrev.com/cfad42b16db127b4e6cdd2cd840a7849dc996b65/chrome/browser/ui/libgtkui/gtk_ui.cc
[add] https://crrev.com/cfad42b16db127b4e6cdd2cd840a7849dc996b65/chrome/browser/ui/libgtkui/nav_button_layout_manager_gsettings.cc
[add] https://crrev.com/cfad42b16db127b4e6cdd2cd840a7849dc996b65/chrome/browser/ui/libgtkui/nav_button_layout_manager_gsettings.h
Project Member

Comment 12 by bugdroid1@chromium.org, Dec 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c307cc3013b72f716ac0ddd83373818f6d6e1ee

commit 1c307cc3013b72f716ac0ddd83373818f6d6e1ee
Author: Tim Brown <timbrown@chromium.org>
Date: Fri Dec 08 02:40:38 2017

Update usage of GSettings in proxy config on linux

We were using a deprecated API to determine the existence of a schema,
and we were lazy loading the libgio library in case a distro doesn't
have the library.

All supported distros have libgio and support the new API, hence I fixed
both.

Test: Forced use of GSettings (see patch 1 - I use i3) and watched
chrome: //net-internals#proxy while I changed gsettings
Bug:  768027 
Change-Id: Id9a3b157723c0b34e69b5b4eadcce1a7048b8636
Reviewed-on: https://chromium-review.googlesource.com/812471
Commit-Queue: Tim Brown <timbrown@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522686}
[modify] https://crrev.com/1c307cc3013b72f716ac0ddd83373818f6d6e1ee/build/linux/BUILD.gn
[delete] https://crrev.com/0af72badfc47b8d2485fa07eaccbef9e8b4066dc/build/linux/libgio/BUILD.gn
[modify] https://crrev.com/1c307cc3013b72f716ac0ddd83373818f6d6e1ee/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/1c307cc3013b72f716ac0ddd83373818f6d6e1ee/chrome/test/BUILD.gn
[modify] https://crrev.com/1c307cc3013b72f716ac0ddd83373818f6d6e1ee/net/BUILD.gn
[modify] https://crrev.com/1c307cc3013b72f716ac0ddd83373818f6d6e1ee/net/proxy/proxy_config_service_linux.cc
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a19f3bf6661448e26a1d042d36b23841786ef40

commit 2a19f3bf6661448e26a1d042d36b23841786ef40
Author: Tim Brown <timbrown@chromium.org>
Date: Tue Dec 12 01:08:40 2017

Remove use of gconf from code

Gconf has been deprecated for several years, with none of the supported
distros even assigning values to the gconf settings. This is part of an
effort to move from using gconf to gsettings.

Bug:  768027 
Change-Id: Ifa1a668364e39c05270999c9eea801a2593011f3
Reviewed-on: https://chromium-review.googlesource.com/817759
Reviewed-by: Eric Roman <eroman@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Tim Brown <timbrown@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523285}
[modify] https://crrev.com/2a19f3bf6661448e26a1d042d36b23841786ef40/chrome/browser/ui/libgtkui/BUILD.gn
[modify] https://crrev.com/2a19f3bf6661448e26a1d042d36b23841786ef40/chrome/browser/ui/libgtkui/gtk_ui.cc
[delete] https://crrev.com/88af91120d1b5aeef887c3360a9275e39ce5e385/chrome/browser/ui/libgtkui/nav_button_layout_manager_gconf.cc
[delete] https://crrev.com/88af91120d1b5aeef887c3360a9275e39ce5e385/chrome/browser/ui/libgtkui/nav_button_layout_manager_gconf.h
[modify] https://crrev.com/2a19f3bf6661448e26a1d042d36b23841786ef40/net/BUILD.gn
[modify] https://crrev.com/2a19f3bf6661448e26a1d042d36b23841786ef40/net/proxy/proxy_config_service_linux.cc
Project Member

Comment 14 by bugdroid1@chromium.org, Dec 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1829894ac62e37257973d5e5c27d1bffb9888b3

commit c1829894ac62e37257973d5e5c27d1bffb9888b3
Author: Tim Brown <timbrown@chromium.org>
Date: Wed Dec 13 22:04:34 2017

Remove remaining references to gconf

This change should be a no-op. It is mostly comment changes, with a few
code changes removing unused enum values and a settings provider class
(which was accidentally added back in after I removed it previously).

Bug:  768027 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia26788b970fbaa6c25eda9cce7758ad626e587b3
Reviewed-on: https://chromium-review.googlesource.com/822160
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Tim Brown <timbrown@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523899}
[modify] https://crrev.com/c1829894ac62e37257973d5e5c27d1bffb9888b3/chrome/browser/net/proxy_service_factory.cc
[modify] https://crrev.com/c1829894ac62e37257973d5e5c27d1bffb9888b3/chrome/browser/ui/libgtkui/gtk_util.h
[modify] https://crrev.com/c1829894ac62e37257973d5e5c27d1bffb9888b3/chrome/browser/ui/libgtkui/settings_provider.h
[delete] https://crrev.com/ca0ec21fa47658e4974020082992a4f367da3cd0/chrome/browser/ui/libgtkui/settings_provider_gconf.cc
[delete] https://crrev.com/ca0ec21fa47658e4974020082992a4f367da3cd0/chrome/browser/ui/libgtkui/settings_provider_gconf.h
[modify] https://crrev.com/c1829894ac62e37257973d5e5c27d1bffb9888b3/chrome/service/service_process.cc
[modify] https://crrev.com/c1829894ac62e37257973d5e5c27d1bffb9888b3/content/browser/BUILD.gn
[modify] https://crrev.com/c1829894ac62e37257973d5e5c27d1bffb9888b3/content/browser/browser_main_loop.cc
[modify] https://crrev.com/c1829894ac62e37257973d5e5c27d1bffb9888b3/content/public/common/proxy_config.mojom
[modify] https://crrev.com/c1829894ac62e37257973d5e5c27d1bffb9888b3/content/public/common/proxy_config_traits.cc
[modify] https://crrev.com/c1829894ac62e37257973d5e5c27d1bffb9888b3/content/public/common/proxy_config_traits_unittest.cc
[modify] https://crrev.com/c1829894ac62e37257973d5e5c27d1bffb9888b3/ios/chrome/browser/browser_state/chrome_browser_state_io_data.h
[modify] https://crrev.com/c1829894ac62e37257973d5e5c27d1bffb9888b3/net/proxy/proxy_config_service_linux_unittest.cc
[modify] https://crrev.com/c1829894ac62e37257973d5e5c27d1bffb9888b3/net/proxy/proxy_config_source.cc
[modify] https://crrev.com/c1829894ac62e37257973d5e5c27d1bffb9888b3/net/proxy/proxy_config_source.h
[modify] https://crrev.com/c1829894ac62e37257973d5e5c27d1bffb9888b3/net/proxy/proxy_service.cc
Project Member

Comment 15 by bugdroid1@chromium.org, Dec 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a28f4d062f4c030eeddd085f261988d7958db2ba

commit a28f4d062f4c030eeddd085f261988d7958db2ba
Author: Tim Brown <timbrown@chromium.org>
Date: Thu Dec 14 18:32:18 2017

Remove use_gconf build flag

All usages of gconf have now been removed, so we can remove the build
flag too. After this, I will remove gconf from the instrumented
libraries, sysroots, and install-build-deps.sh.

Bug:  768027 
Change-Id: Idf5e8d60da387b3287f875092feba488217ca642
Reviewed-on: https://chromium-review.googlesource.com/826046
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Tim Brown <timbrown@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524120}
[modify] https://crrev.com/a28f4d062f4c030eeddd085f261988d7958db2ba/build/args/headless.gn
[modify] https://crrev.com/a28f4d062f4c030eeddd085f261988d7958db2ba/build/config/features.gni
[modify] https://crrev.com/a28f4d062f4c030eeddd085f261988d7958db2ba/build/config/linux/atk/BUILD.gn
[delete] https://crrev.com/3085594d142c3a1ea01a671807385e2c0696beb9/build/config/linux/gconf/BUILD.gn
Project Member

Comment 16 by bugdroid1@chromium.org, Dec 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78a3d474af986731a2cfed7671f5b520e2d30acb

commit 78a3d474af986731a2cfed7671f5b520e2d30acb
Author: Tim Brown <timbrown@chromium.org>
Date: Thu Dec 14 23:27:31 2017

Remove libdconf and libgconf from dependencies

Use of gconf has been removed, and we depend on gsettings (in libgio)
instead of dconf directly.

Bug:  768027 
Change-Id: Iec222f01577d3ffe10ee4a31345030d765eaefb4
Reviewed-on: https://chromium-review.googlesource.com/827921
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Tim Brown <timbrown@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524227}
[modify] https://crrev.com/78a3d474af986731a2cfed7671f5b520e2d30acb/chrome/installer/linux/debian/dist_package_versions.json
[modify] https://crrev.com/78a3d474af986731a2cfed7671f5b520e2d30acb/chrome/installer/linux/debian/update_dist_package_versions.py
[modify] https://crrev.com/78a3d474af986731a2cfed7671f5b520e2d30acb/chrome/installer/linux/rpm/dist_package_provides.json
[modify] https://crrev.com/78a3d474af986731a2cfed7671f5b520e2d30acb/chrome/installer/linux/rpm/update_package_provides.py
Project Member

Comment 17 by bugdroid1@chromium.org, Dec 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aebd73d251f2e05235274cda2ee8fd6383c513a8

commit aebd73d251f2e05235274cda2ee8fd6383c513a8
Author: Tim Brown <timbrown@chromium.org>
Date: Fri Dec 15 01:11:54 2017

Remove gconf and dconf from instrumented libraries

Use of gconf has been removed, and we depend on gsettings (in
libgio/libglib) instead of dconf directly.

Bug:  768027 
Change-Id: I2c2dfb7f36db456c8c55af1041ad9497ddca07cd
Reviewed-on: https://chromium-review.googlesource.com/827677
Reviewed-by: Evgeniy Stepanov <eugenis@chromium.org>
Commit-Queue: Tim Brown <timbrown@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524274}
[modify] https://crrev.com/aebd73d251f2e05235274cda2ee8fd6383c513a8/third_party/instrumented_libraries/BUILD.gn
[modify] https://crrev.com/aebd73d251f2e05235274cda2ee8fd6383c513a8/third_party/instrumented_libraries/scripts/install-build-deps.sh
Project Member

Comment 18 by bugdroid1@chromium.org, Dec 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67fee5924741f4ccd5985b4933a042e8a24559d4

commit 67fee5924741f4ccd5985b4933a042e8a24559d4
Author: Tim Brown <timbrown@chromium.org>
Date: Fri Dec 15 21:17:02 2017

Update checksum for instrumented libraries

This is after having removed dconf and gconf.

Bug:  768027 
Change-Id: I8963b75da9b20688b698b658d7d5039fa59ac959
Reviewed-on: https://chromium-review.googlesource.com/827616
Reviewed-by: Evgeniy Stepanov <eugenis@chromium.org>
Commit-Queue: Tim Brown <timbrown@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524464}
[modify] https://crrev.com/67fee5924741f4ccd5985b4933a042e8a24559d4/third_party/instrumented_libraries/binaries/msan-chained-origins-trusty.tgz.sha1
[modify] https://crrev.com/67fee5924741f4ccd5985b4933a042e8a24559d4/third_party/instrumented_libraries/binaries/msan-no-origins-trusty.tgz.sha1
Project Member

Comment 19 by bugdroid1@chromium.org, Dec 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2bede458a4744fdf465620afd871a2f3c892266b

commit 2bede458a4744fdf465620afd871a2f3c892266b
Author: Tim Brown <timbrown@chromium.org>
Date: Fri Dec 15 21:52:17 2017

Remove gconf and dconf from sysroots

Bug:  768027 
Change-Id: Idf3e65c743e79b27e189a3ce4cb7f7e675a9fd03
Reviewed-on: https://chromium-review.googlesource.com/830812
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Tim Brown <timbrown@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524474}
[modify] https://crrev.com/2bede458a4744fdf465620afd871a2f3c892266b/build/linux/sysroot_scripts/packagelist.stretch.amd64
[modify] https://crrev.com/2bede458a4744fdf465620afd871a2f3c892266b/build/linux/sysroot_scripts/packagelist.stretch.arm
[modify] https://crrev.com/2bede458a4744fdf465620afd871a2f3c892266b/build/linux/sysroot_scripts/packagelist.stretch.arm64
[modify] https://crrev.com/2bede458a4744fdf465620afd871a2f3c892266b/build/linux/sysroot_scripts/packagelist.stretch.i386
[modify] https://crrev.com/2bede458a4744fdf465620afd871a2f3c892266b/build/linux/sysroot_scripts/packagelist.stretch.mips64el
[modify] https://crrev.com/2bede458a4744fdf465620afd871a2f3c892266b/build/linux/sysroot_scripts/packagelist.stretch.mipsel
[modify] https://crrev.com/2bede458a4744fdf465620afd871a2f3c892266b/build/linux/sysroot_scripts/sysroot-creator-stretch.sh
Project Member

Comment 20 by bugdroid1@chromium.org, Dec 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36312fccc6b5f9bba0fa427d6b9756daad3b94e6

commit 36312fccc6b5f9bba0fa427d6b9756daad3b94e6
Author: Tim Brown <timbrown@chromium.org>
Date: Fri Dec 15 22:56:20 2017

Remove gconf and dconf from install deps

Also update the "Notes for other distros" in the build instructions.

All usages of gconf has been removed, and we depend on gsettings, not
dconf directly.

This is the final step in switching from gconf to gsettings.

Bug:  768027 
Change-Id: I4430c261ac2c9691838e7dfe9c0d7c6842fa535f
Reviewed-on: https://chromium-review.googlesource.com/831106
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Tim Brown <timbrown@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524503}
[modify] https://crrev.com/36312fccc6b5f9bba0fa427d6b9756daad3b94e6/build/install-build-deps.sh
[modify] https://crrev.com/36312fccc6b5f9bba0fa427d6b9756daad3b94e6/docs/linux_build_instructions.md

Comment 21 by timbrown@chromium.org, Dec 28 2017

Status: Fixed (was: Started)
►

Sign in to add a comment