The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/95ab64dc3565e8daad0aa6f30f4266b2e6e26f8d

commit 95ab64dc3565e8daad0aa6f30f4266b2e6e26f8d
Author: Don Garrett <dgarrett@google.com>
Date: Wed Sep 27 03:43:57 2017

waterfalls: Clean up obsolete 'waterfall' constants.

This change does three things:

1) Removes unused BRILLO/WEAVE waterfalls.
2) Removes obsolete concept of CIDB supported waterfalls.

The concept of watefalls with CIDB support has been obsolete since
the CIDB migration 00041_alter_build_table_stringify_waterfall.sql.

This change is potentially very significant, because a number of
existing waterfalls were not having their builds inserted into CIDB.

BUG= chromium:768025 
TEST=run_tests

Change-Id: I556609392baccb4a9e039d1441997d223e300fba
Reviewed-on: https://chromium-review.googlesource.com/679675
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/95ab64dc3565e8daad0aa6f30f4266b2e6e26f8d/cbuildbot/cbuildbot_run_unittest.py
[modify] https://crrev.com/95ab64dc3565e8daad0aa6f30f4266b2e6e26f8d/scripts/cbuildbot.py
[modify] https://crrev.com/95ab64dc3565e8daad0aa6f30f4266b2e6e26f8d/lib/const/waterfall.py
[modify] https://crrev.com/95ab64dc3565e8daad0aa6f30f4266b2e6e26f8d/cbuildbot/stages/report_stages_unittest.py
[modify] https://crrev.com/95ab64dc3565e8daad0aa6f30f4266b2e6e26f8d/cbuildbot/stages/report_stages.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/f0ae80d90078b665030ca45fc9561a82b464f4de

commit f0ae80d90078b665030ca45fc9561a82b464f4de
Author: Don Garrett <dgarrett@google.com>
Date: Wed Sep 27 03:43:57 2017

waterfalls: Insert chromeos.swarming waterfall.

Swarming doesn't really have a waterfall, but we use the value for a
number of assorted things, so just create a placeholder waterfall for
now.

BUG= chromium:768025 
TEST=run_tests

Change-Id: I97923cdcec1aeb8e5f9e7c01e7b5fc5fa01605d6
Reviewed-on: https://chromium-review.googlesource.com/679676
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/f0ae80d90078b665030ca45fc9561a82b464f4de/scripts/cbuildbot.py
[modify] https://crrev.com/f0ae80d90078b665030ca45fc9561a82b464f4de/lib/const/waterfall.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/89bcd5d027811e3d2fdfe5c6b2eaa61799f6f368

commit 89bcd5d027811e3d2fdfe5c6b2eaa61799f6f368
Author: Don Garrett <dgarrett@google.com>
Date: Fri Sep 29 06:26:21 2017

cros tryjob: Don't set waterfall for swarming.

I created a special swarming waterfall name, but forgot to remove the
old hack value when sending swarming requests.

BUG= chromium:768025 
TEST=cros tryjob --swarming chromite-pre-cq

Change-Id: I52c48d573b79b90df87f22621d927cbf27cc772e
Reviewed-on: https://chromium-review.googlesource.com/687980
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/89bcd5d027811e3d2fdfe5c6b2eaa61799f6f368/lib/remote_try.py

All swarming builds are now in either Prod or Debug CIDB.

All non tryjobs are in Prod CIDB.

Nearly all tryjobs in in Prod CIDB.

A few "difficult" tryjob build configs are in Debug CIDB. These are roughly the configs "master-*-tryjob" and "precq-launcher-tryjob".

Since the Legoland build details page is no longer fully dependent on CIDB information, I believe we can consider this fixed.

jinjinl@ do you agree?

Yes. The build details page should behave normally (only with slightly less info like recent related builds) even for builds not in Prod CIDB as long as they are in Buildbucket or Milo.BuildInfo.