More sanity checks for Linux installer |
||
Issue descriptionIdeas for more robust Linux packaging: 1) Whitelist of expected files. If it's just a simple list, then it needs to include all possible files for all brand + channel combinations. 2) Make sure all files have the right permissions: - Directories are 755 - All files are 755 or 644 - Expect chrome-sandbox which is 4755.
,
Sep 22 2017
We already do (3). That's bug 748293 .
,
Sep 22 2017
Hm, I received a CL the other day that tried to strip nacl_helper. Is it wrong? https://chromium-review.googlesource.com/c/chromium/src/+/674872/1/chrome/installer/linux/common/installer.include
,
Sep 22 2017
I'll reply on the CL.
,
Sep 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/465181c8ea35ff1ad0a9d57811cd0c0bb6150c0a commit 465181c8ea35ff1ad0a9d57811cd0c0bb6150c0a Author: Tom Anderson <thomasanderson@chromium.org> Date: Tue Sep 26 00:30:55 2017 Verify file permissions on Linux packages BUG=768020 R=thestig@chromium.org Change-Id: I8ec5c4b4b4be5910f3571d7770e910f5e74ae0f4 Reviewed-on: https://chromium-review.googlesource.com/683155 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#504233} [modify] https://crrev.com/465181c8ea35ff1ad0a9d57811cd0c0bb6150c0a/chrome/installer/linux/common/installer.include
,
Sep 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf34d5495531847d7b481c2d57dd7e33dca0a244 commit cf34d5495531847d7b481c2d57dd7e33dca0a244 Author: Tom Anderson <thomasanderson@chromium.org> Date: Tue Sep 26 19:37:23 2017 Linux packager: Make sure ELF binaries live exclusively in /opt BUG=768020 R=thestig@chromium.org Change-Id: Iaf520e6f064cdc44977607fdac8be7137648bbfd Reviewed-on: https://chromium-review.googlesource.com/685506 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#504460} [modify] https://crrev.com/cf34d5495531847d7b481c2d57dd7e33dca0a244/chrome/installer/linux/common/installer.include
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7ca6141429ce2f8ae07faf1920b8dba776bebfa3 commit 7ca6141429ce2f8ae07faf1920b8dba776bebfa3 Author: Tom Anderson <thomasanderson@chromium.org> Date: Thu Sep 28 00:45:31 2017 Fix broken chromium-browser symlink in Linux packages This CL: * Fixes the broken symlink. * Adds a check to ensure symlinks are valid. R=thestig@chromium.org BUG=768020 Change-Id: I98060b989b7723179128ccd9ee3b971638be83a7 Reviewed-on: https://chromium-review.googlesource.com/688489 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#504830} [modify] https://crrev.com/7ca6141429ce2f8ae07faf1920b8dba776bebfa3/chrome/installer/linux/common/installer.include [modify] https://crrev.com/7ca6141429ce2f8ae07faf1920b8dba776bebfa3/chrome/installer/linux/debian/build.sh [modify] https://crrev.com/7ca6141429ce2f8ae07faf1920b8dba776bebfa3/chrome/installer/linux/rpm/build.sh
,
Oct 6 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by thomasanderson@chromium.org
, Sep 22 2017