New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 768012 link

Starred by 1 user
Status: Fixed
Owner:
dgarr...@chromium.org
Closed: Jan 2018
Cc:
█ pho...@chromium.org
dgarr...@chromium.org
█ leecy@chromium.org
█ nxia@chromium.org
pprabhu@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature


Participants' hotlists:
Hotlist-1


Sign in to add a comment

Use GoldenEye suite details page to replace the viceroy suite details page in HWTest stages

Project Member Reported by jinjingl@chromium.org, Sep 22 2017 
In HW test stages, there is a "suite details" link generated that links to this viceroy page https://viceroy.corp.google.com/chromeos/suite_details?job_id=142004215. 

Since the viceroy page will be replaced with GoldenEye suite details page, we want the link to go to http://cros-goldeneye/healthmonitoring/suiteDetails?suiteId=SUITE_ID, 

where SUITE_ID is the job id for the suite.

Comment 1 by dgarr...@chromium.org, Sep 22 2017

Cc: pprabhu@chromium.org pho...@chromium.org
Our current link code by either suiteId, or CIDB build id.

http://cs/chromeos_public/chromite/lib/tree_status.py?l=506&rcl=d883d089ad9849666a8bb0ca19631d8087d2fed0

There is code generating a buildId based link from the ReportStage.

Do you want to update the links from both the hwtest stage and the ReportStage? If so, can you accept CIDB build id as an argument?

Comment 2 by dgarr...@chromium.org, Sep 22 2017

Labels: Hotlist-Fixit
Owner: dgarr...@chromium.org
Status: Started (was: Untriaged)

Comment 3 by dgarr...@chromium.org, Sep 22 2017

Owner: jinjingl@chromium.org
Passing to jinjingl to figure out is both links should be updated.

Comment 4 by jinjingl@chromium.org, Sep 26 2017 

We accept both cidbBuildId and suiteId as parameter. 

Both stage sounds good.

For HW test stage, let's use the suiteId parameter. 
For report stage, let's use the cidbBuildId parameter.

Comment 5 by dgarr...@chromium.org, Sep 26 2017 

Sounds good!

Comment 6 by jinjingl@chromium.org, Oct 30 2017

Labels: Legoland

Comment 7 by jinjingl@chromium.org, Jan 11 2018

Owner: ----
Reassigning this to Infra team since I don't have the bandwidth for contributing to cbuildbot code base before my vacation in Feb. 

This will enable user to go to a specific suite's details page. On the current page, https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?id=2028616, the "GE suite details" link goes to all Hwtests for a build, but not for a suite.

Comment 8 by jinjingl@chromium.org, Jan 11 2018

Owner: dgarr...@chromium.org
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/39d243e2d1b16a396000b2f5fbb6b39b9a93ad5e

commit 39d243e2d1b16a396000b2f5fbb6b39b9a93ad5e
Author: Don Garrett <dgarrett@google.com>
Date: Sat Jan 13 06:37:52 2018

hwtest suite details: Move link from Viceroy to GE.

We want to use GE to display our suite details information, so update
the links embedded in our waterfall.

BUG= chromium:768012 
TEST=run_tests (which didn't notice the change)

Change-Id: Ib395fcd78db91b63968f99b6a4de54a105501b07
Reviewed-on: https://chromium-review.googlesource.com/862886
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/39d243e2d1b16a396000b2f5fbb6b39b9a93ad5e/lib/tree_status.py
[modify] https://crrev.com/39d243e2d1b16a396000b2f5fbb6b39b9a93ad5e/cbuildbot/commands.py
[modify] https://crrev.com/39d243e2d1b16a396000b2f5fbb6b39b9a93ad5e/cbuildbot/stages/report_stages.py
►

Sign in to add a comment