New issue
Advanced search Search tips

Issue 767992 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Stop reporting blacklist load incidents

Project Member Reported by proberge@chromium.org, Sep 22 2017

Issue description

As part of the plan to transfer ownership of incident reporting to the Chrome SafeBrowsing team, we will be removing maintenance-intensive components.

The Blacklist load analyzer and associated blacklist load incidents currently have very little impact as the triggering rate is very low. We should remove it.
 
 
Labels: -Type-Bug Type-Task
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3d51e2527354bf382498c637c79f89c67dfea35

commit f3d51e2527354bf382498c637c79f89c67dfea35
Author: proberge <proberge@chromium.org>
Date: Wed Sep 27 15:54:44 2017

Disable and remove the blacklist load incident

Also removes code in chrome_elf/blacklist which was added to support
this incident.

Also starts clearing suspicious module incidents from the state_store, which I
forgot to do in https://chromium-review.googlesource.com/c/chromium/src/+/656086

Bug:  767992 
Cq-Include-Trybots: master.tryserver.chromium.win:win10_chromium_x64_rel_ng
Change-Id: I0562fe18704f7bfab8ed4e8732eebb49652a5a1a
Reviewed-on: https://chromium-review.googlesource.com/679205
Reviewed-by: Robert Shield <robertshield@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: proberge <proberge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504689}
[modify] https://crrev.com/f3d51e2527354bf382498c637c79f89c67dfea35/chrome/browser/safe_browsing/BUILD.gn
[delete] https://crrev.com/d9ce58ca4190de9609889450f2504d6a925f9ed0/chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyzer.cc
[delete] https://crrev.com/d9ce58ca4190de9609889450f2504d6a925f9ed0/chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyzer.h
[delete] https://crrev.com/d9ce58ca4190de9609889450f2504d6a925f9ed0/chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyzer_win.cc
[delete] https://crrev.com/d9ce58ca4190de9609889450f2504d6a925f9ed0/chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyzer_win_unittest.cc
[delete] https://crrev.com/d9ce58ca4190de9609889450f2504d6a925f9ed0/chrome/browser/safe_browsing/incident_reporting/blacklist_load_incident.cc
[delete] https://crrev.com/d9ce58ca4190de9609889450f2504d6a925f9ed0/chrome/browser/safe_browsing/incident_reporting/blacklist_load_incident.h
[delete] https://crrev.com/d9ce58ca4190de9609889450f2504d6a925f9ed0/chrome/browser/safe_browsing/incident_reporting/blacklist_load_incident_unittest.cc
[modify] https://crrev.com/f3d51e2527354bf382498c637c79f89c67dfea35/chrome/browser/safe_browsing/incident_reporting/incident.h
[modify] https://crrev.com/f3d51e2527354bf382498c637c79f89c67dfea35/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc
[modify] https://crrev.com/f3d51e2527354bf382498c637c79f89c67dfea35/chrome/browser/safe_browsing/incident_reporting/state_store.cc
[modify] https://crrev.com/f3d51e2527354bf382498c637c79f89c67dfea35/chrome/browser/safe_browsing/incident_reporting/state_store_unittest.cc
[modify] https://crrev.com/f3d51e2527354bf382498c637c79f89c67dfea35/chrome/browser/safe_browsing/safe_browsing_service.cc
[modify] https://crrev.com/f3d51e2527354bf382498c637c79f89c67dfea35/chrome/test/BUILD.gn
[modify] https://crrev.com/f3d51e2527354bf382498c637c79f89c67dfea35/chrome_elf/blacklist/blacklist.cc
[modify] https://crrev.com/f3d51e2527354bf382498c637c79f89c67dfea35/chrome_elf/blacklist/blacklist.h
[modify] https://crrev.com/f3d51e2527354bf382498c637c79f89c67dfea35/chrome_elf/blacklist/test/blacklist_test.cc
[modify] https://crrev.com/f3d51e2527354bf382498c637c79f89c67dfea35/chrome_elf/blacklist/test/blacklist_test_main_dll.def
[modify] https://crrev.com/f3d51e2527354bf382498c637c79f89c67dfea35/chrome_elf/chrome_elf_x64.def
[modify] https://crrev.com/f3d51e2527354bf382498c637c79f89c67dfea35/chrome_elf/chrome_elf_x86.def
[modify] https://crrev.com/f3d51e2527354bf382498c637c79f89c67dfea35/components/safe_browsing/proto/csd.proto
[modify] https://crrev.com/f3d51e2527354bf382498c637c79f89c67dfea35/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)

Sign in to add a comment