Issue metadata
Sign in to add a comment
|
Attempt to view local benchmark run results.html throws JS error loading data. |
||||||||||||||||||||||
Issue descriptionAttempting to run a benchmark locally and view output results.html is throwing a JS error after loading ~80% of the data. This has been happening at least the past two days. Seems potentially P1 since eng can't easily investigate broken benchmarks but feel free to lower priority if I am off base. To repro: % tools/perf/run_benchmark -v --pageset-repeat=1 --browser=release rasterize_and_record_micro.top_25 and try opening the results.html via link printed to console. I see for example: Loading Histogram 5100 of 5152 and then JS error and hang. It does not always hang at the same displayed histogram progress point, for example, reloading a few times also gives me: Loading Histogram 4600 of 5152 Sample error in console: Uncaught (in promise) Error: Unrecognized diagnostic type: TelemetryInfo at Function.fromDict (results.html:11606) at Map.addDicts (results.html:15803) at Function.fromDict (results.html:16210) at HistogramSet.importDicts (results.html:17716) at HistogramImporter.loadSomeHistograms_ (results.html:17993) at HistogramImporter.loadSomeHistograms_ (results.html:18001) at <anonymous>
,
Sep 22 2017
,
Sep 25 2017
Ben, can you triage? I suggested offline that wkorman@ use --reset-results, but not sure if you have any other suggestions.
,
Sep 25 2017
We've made a few breaking changes to the metadata structure: https://github.com/catapult-project/catapult/commit/e94ec7bdc9789b3b7afec8d0ef6dd724c1a6d56f#diff-fdafdaa107517ce471e3d5add801fd08 https://github.com/catapult-project/catapult/commit/b9777c776dee43db2063ad97c9eb7a8a09afd0f3#diff-fdafdaa107517ce471e3d5add801fd08 If you need the data from the old results.html file, please email it to me and I can manually upgrade it. Otherwise, you can delete the old data via rm results.html or --reset-results.
,
Sep 25 2017
Next time, if there is a breaking change, is it possible to make Telemetry detect it & add s.t that would make run_benchmark commandline prompt "There is an update to results.html, please remove old data via rm results.html or --reset-results."?
,
Sep 25 2017
Yes, it would be better to warn users if possible. Depending on the nature of the change, it would probably be possible to detect it in results_renderer.ReadExistingResults(). I don't currently anticipate any more breaking changes.
,
Jan 16
,
Jan 16
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by nedngu...@google.com
, Sep 22 2017Owner: eakuefner@chromium.org
Status: Assigned (was: Available)