New issue
Advanced search Search tips

Issue 767985 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove unused parameter from DoInstallOnBlockingTaskRunner

Project Member Reported by sorin@chromium.org, Sep 22 2017

Issue description

The unused |callback| parameter is confusing since it gives the
impression that the DoInstallOnBlockingTaskRunner is non-blocking.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/482552f5bc3b53d1370e385a62f60b13e63825a0

commit 482552f5bc3b53d1370e385a62f60b13e63825a0
Author: Sorin Jianu <sorin@chromium.org>
Date: Fri Sep 22 21:33:06 2017

Remove unused parameter from DoInstallOnBlockingTaskRunner.

Bug:  767985 
Change-Id: I0fd421ef8f8b25422725556aaf047a6bf74e0fcd
Reviewed-on: https://chromium-review.googlesource.com/679285
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503860}
[modify] https://crrev.com/482552f5bc3b53d1370e385a62f60b13e63825a0/components/update_client/component.cc

Comment 2 by sorin@chromium.org, Oct 4 2017

Status: Fixed (was: Started)

Sign in to add a comment