New issue
Advanced search Search tips

Issue 767977 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 5
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 696822



Sign in to add a comment

DNR: Impost a limit on the number of declarative rules that an extension can provide.

Project Member Reported by karandeepb@chromium.org, Sep 22 2017

Issue description

This should then be implemented in both the Chrome and CWS code.
 
Also, note that by default Flatbuffer::Verifier allows a max number of 10^6 tables. See "Access of untrusted buffers" in https://google.github.io/flatbuffers/md__cpp_usage.html.


Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42ac670f7314a95c31b51819961aa2c3b8c6c835

commit 42ac670f7314a95c31b51819961aa2c3b8c6c835
Author: Karan Bhatia <karandeepb@chromium.org>
Date: Sat Sep 01 03:11:23 2018

Declarative Net Request: Limit the no. of rules that an extension can provide.

This CL limits the no. of rules that an extension can provide to 30000. If an
extension provides more rules than this limit, those rules will be ignored and
an install warning will be surfaced to the user upon installation on the
extensions page. These won't re-surface once the browser restarts for packed
extensions.

BUG= 767977 

Change-Id: I95c824f4233dd7c0b77393fa817522b9b1c70681
Reviewed-on: https://chromium-review.googlesource.com/1198010
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588257}
[modify] https://crrev.com/42ac670f7314a95c31b51819961aa2c3b8c6c835/chrome/browser/extensions/api/declarative_net_request/rule_indexing_unittest.cc
[modify] https://crrev.com/42ac670f7314a95c31b51819961aa2c3b8c6c835/extensions/browser/api/declarative_net_request/constants.cc
[modify] https://crrev.com/42ac670f7314a95c31b51819961aa2c3b8c6c835/extensions/browser/api/declarative_net_request/constants.h
[modify] https://crrev.com/42ac670f7314a95c31b51819961aa2c3b8c6c835/extensions/browser/api/declarative_net_request/utils.cc
[modify] https://crrev.com/42ac670f7314a95c31b51819961aa2c3b8c6c835/extensions/common/api/declarative_net_request.idl

Status: Fixed (was: Started)

Sign in to add a comment