New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 767957 link

Starred by 3 users

Issue metadata

Status: Started
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , Windows
Pri: 2
Type: Task
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Refactor the VR UI object to hide its internal implementation

Project Member Reported by cjgrant@chromium.org, Sep 22 2017

Issue description

As of now, VrShellGl is tightly coupled to the parts of the skia UI.  We're moving towards having a vr::Ui abstract class, and VrShellGl should be able to render the UI using a clean interface to this class.

Ui object getters like the following should disappear:

  UiScene* scene() { return scene_.get(); }
  VrShellRenderer* vr_shell_renderer() { return vr_shell_renderer_.get(); }
  UiRenderer* ui_renderer() { return ui_renderer_.get(); }
  UiInputManager* input_manager() { return input_manager_.get(); }

 
Labels: -M-63 M-64
Labels: -M-64 M-65
Labels: -M-65 M-66
Labels: -M-66 M-68
Status: WontFix (was: Available)
The dust has settled on this implementation.  These getters still exist, but they won't disappear until an external force (like Windows support) necessitates refactoring.  Closing this for now.
Status: Started (was: WontFix)
This work is happening in preparation for VR modularization.

Comment 8 by samdrazin@chromium.org, Jan 17 (6 days ago)

Cc: cassew@chromium.org elalish@chromium.org
Labels: -M-68

Comment 9 by ddorwin@chromium.org, Jan 18 (5 days ago)

Labels: -Proj-VR-Shell OS-Android OS-Windows

Sign in to add a comment