New issue
Advanced search Search tips

Issue 767946 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jan 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

WebStateTest.Snapshot fails on iPhone SE

Project Member Reported by eugene...@chromium.org, Sep 22 2017

Issue description

App Version (from "Chrome Settings > About Chrome"): ToT
iOS Version: 11
Device: iPhone SE (simulator and device)

Steps to reproduce: 
1.) Run WebStateTest.Snapshot test from ios_web_unittest test suite

Observed behavior: 

../../ui/gfx/image/image_unittest_util.cc:276: Failure
Value of: ColorsClose(color1, color2, MaxColorSpaceConversionColorShift())
  Actual: false
Expected: true

 
Labels: -Pri-2 M-64 Pri-1
The test is also failing on iPhone 8 Plus. Ed, could you please take a look
Ed, could you please look at this bug. It's very distracting to see the test failure.

Comment 3 by edchin@chromium.org, Nov 29 2017

I was not able to reproduce on the following environments:
iPhone SE iOS 11 simulator
iPhone 8 Plus iOS 11 simulator
iPhone 5s iOS 11 simulator
iPhone X iOS 11 simulator
iPhone 7 Plus iOS 10 device
iPhone 6 iOS 10 device

I also ran the test method 20x for each run.

The flakiness of this bug suggests one of two potential issues:
1) the ColorsClose() method is flaky, or
2) the SpinRunLoopWithMinDelay is not long enough 

Without a reliable repro, I can't say that addressing either of these will help.

Comment 4 by edchin@chromium.org, Nov 29 2017

Cc: edchin@chromium.org
Owner: eugene...@chromium.org
eugenebut@, could you help me repro this?
Owner: edchin@chromium.org
Couldrepro on iPhone SE, iOS 11.0:

[ RUN      ] WebStateTest.Snapshot
../../ui/gfx/image/image_unittest_util.cc:276: Failure
Value of: ColorsClose(color1, color2, MaxColorSpaceConversionColorShift())
  Actual: false
Expected: true
[  FAILED  ] WebStateTest.Snapshot (648 ms)

Labels: -Pri-1 -M-64 Pri-3
I think this is a p3 relative to other priorities. 
Components: Mobile>iOSWeb
Components: -Mobile>WebView>Glue
Status: WontFix (was: Assigned)
Did not see this problem for a while.

Sign in to add a comment