New issue
Advanced search Search tips

Issue 767944 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 762724
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Proj-XR

Blocking:
issue 734611



Sign in to add a comment

VR PendingIntent broadcast sending flaky w/ DON skipped

Project Member Reported by bsheedy@chromium.org, Sep 22 2017

Issue description

Occasionally, we are failing to receive the broadcast from the PendingIntent that we pass to VrCore that lets us know that we can enter VR.

The CL that caused this to start happening is https://chromium-review.googlesource.com/c/chromium/src/+/667926, but it seems more likely that this just exposed an existing issue.

This has a ~60-70% chance of happening at least once during an instrumentation test run when using the swarmed Pixel XL devices, but only a tiny chance of happening otherwise. 
 
Blocking: 734611
This is fixed by https://chromium-review.googlesource.com/c/chromium/src/+/677982, although the root cause of the issue still hasn't been found.
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7eac167f6f00062bdb53c5bc052a333b8762c0f

commit a7eac167f6f00062bdb53c5bc052a333b8762c0f
Author: bsheedy <bsheedy@chromium.org>
Date: Sat Sep 23 21:47:01 2017

Add comment to S8 workaround to not remove

Adds a comment to the workaround that was initially added to fix a
problem with VR on the Galaxy S8. It turns out this workaround also
fixes an issue with VR PendingIntent broadcasts not being received, so
this just notes that the workaround should not be removed until that
issue is also fixed.

Bug:  767944 
Change-Id: Idf264cde619a45a4f2d8d98e43009837e05b29b3
Reviewed-on: https://chromium-review.googlesource.com/679774
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503946}
[modify] https://crrev.com/a7eac167f6f00062bdb53c5bc052a333b8762c0f/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java

Labels: VR-Caught-By-Test
Owner: bsheedy@chromium.org
Status: Assigned (was: Available)
Brian, is this a duplicate of the DON flow broadcast order issues?
Mergedinto: 762724
Status: Duplicate (was: Assigned)
I believe it's a duplicate, yes.
Components: Internals>XR
Labels: -VR-Caught-By-Test XR-Caught-By-Test

Sign in to add a comment