New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 767932 link

Starred by 1 user
Status: Fixed
Owner:
█ thanhdle@chromium.org
Last visit > 30 days ago
Closed: Sep 2017
Cc:
ryansturm@chromium.org
bengr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

TestClientLoFiExplicitlyDisabled tested the wrong thing

Project Member Reported by thanhdle@chromium.org, Sep 22 2017 
What is the expected result?
The test should disabled kClientLoFiFieldTrial, and test that params::IsClientLoFiEnabled() is false.

What happens instead?
The test currently turns on kClientLoFiFieldTrial, and test that params::IsClientLoFiEnabled() is true.

Please use labels and text to provide additional information.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14595e641da2d54c0a2426caf8a39ab8f28792e4

commit 14595e641da2d54c0a2426caf8a39ab8f28792e4
Author: Thanh Le <thanhdle@chromium.org>
Date: Fri Sep 22 21:48:52 2017

Fixed TestClientLoFiExplicitlyDisabled implementation.

The test now disables kClientLoFiFieldTrial, and test that params::IsClientLoFiEnabled() is false.

Bug:  767932 
Change-Id: Ib10f804c0f5410fdd8fc768a96b232f35727ece5
Reviewed-on: https://chromium-review.googlesource.com/679201
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Thanh Le <thanhdle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503867}
[modify] https://crrev.com/14595e641da2d54c0a2426caf8a39ab8f28792e4/components/previews/core/previews_experiments_unittest.cc

Comment 2 by thanhdle@chromium.org, Sep 22 2017

Status: Fixed (was: Assigned)

Comment 3 by efoo@chromium.org, Dec 5 2017

Components: Blink>Previews

Comment 4 by efoo@chromium.org, Dec 5 2017

Components: -UI>Browser>Previews
►

Sign in to add a comment