New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 767931 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

[Autofill] Fill abbreviations/full versions of states/regions in dropdowns,

Project Member Reported by ma...@chromium.org, Sep 22 2017

Issue description

On target.com, the dropdown for Canadian regions is AB, MB, QC, etc. 

If the user's address is QC or Quebec, it should fill in any case. 


 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eea046d170daba05abfaef53a436caf663c35b47

commit eea046d170daba05abfaef53a436caf663c35b47
Author: Mathieu Perreault <mathp@chromium.org>
Date: Thu Sep 28 15:51:21 2017

[Autofill] Move AddressNormalizer and phone utils to Autofill

Functionality neutral refactor for an upcoming change. I started 
pulling on AddressNormalizer and a lot of stuff came with it :|

* AddressNormalizer and friends move to Autofill code.
* GetCountryCodeWithFallback moves to autofill_data_util
* Phone number utils move from Payment Request code to Autofill

Bug:  767931 
Test: components_unittests
Change-Id: I57b4b7863bc2f12408ab388694b349029607fe5e
Reviewed-on: https://chromium-review.googlesource.com/688581
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505037}
[modify] https://crrev.com/eea046d170daba05abfaef53a436caf663c35b47/chrome/browser/autofill/android/personal_data_manager_android.cc
[modify] https://crrev.com/eea046d170daba05abfaef53a436caf663c35b47/chrome/browser/autofill/android/personal_data_manager_android.h
[modify] https://crrev.com/eea046d170daba05abfaef53a436caf663c35b47/chrome/browser/payments/chrome_payment_request_delegate.cc
[modify] https://crrev.com/eea046d170daba05abfaef53a436caf663c35b47/chrome/browser/payments/chrome_payment_request_delegate.h
[modify] https://crrev.com/eea046d170daba05abfaef53a436caf663c35b47/chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc
[modify] https://crrev.com/eea046d170daba05abfaef53a436caf663c35b47/chrome/browser/ui/views/payments/payment_request_views_util.cc
[modify] https://crrev.com/eea046d170daba05abfaef53a436caf663c35b47/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc
[modify] https://crrev.com/eea046d170daba05abfaef53a436caf663c35b47/components/autofill/core/browser/BUILD.gn
[rename] https://crrev.com/eea046d170daba05abfaef53a436caf663c35b47/components/autofill/core/browser/address_normalizer.h
[rename] https://crrev.com/eea046d170daba05abfaef53a436caf663c35b47/components/autofill/core/browser/address_normalizer_impl.cc
[rename] https://crrev.com/eea046d170daba05abfaef53a436caf663c35b47/components/autofill/core/browser/address_normalizer_impl.h
[rename] https://crrev.com/eea046d170daba05abfaef53a436caf663c35b47/components/autofill/core/browser/address_normalizer_impl_unittest.cc
[modify] https://crrev.com/eea046d170daba05abfaef53a436caf663c35b47/components/autofill/core/browser/autofill_data_util.cc
[modify] https://crrev.com/eea046d170daba05abfaef53a436caf663c35b47/components/autofill/core/browser/autofill_data_util.h
[modify] https://crrev.com/eea046d170daba05abfaef53a436caf663c35b47/components/autofill/core/browser/autofill_data_util_unittest.cc
[modify] https://crrev.com/eea046d170daba05abfaef53a436caf663c35b47/components/autofill/core/browser/phone_number_i18n.cc
[modify] https://crrev.com/eea046d170daba05abfaef53a436caf663c35b47/components/autofill/core/browser/phone_number_i18n.h
[modify] https://crrev.com/eea046d170daba05abfaef53a436caf663c35b47/components/autofill/core/browser/phone_number_i18n_unittest.cc
[rename] https://crrev.com/eea046d170daba05abfaef53a436caf663c35b47/components/autofill/core/browser/test_address_normalizer.cc
[rename] https://crrev.com/eea046d170daba05abfaef53a436caf663c35b47/components/autofill/core/browser/test_address_normalizer.h
[modify] https://crrev.com/eea046d170daba05abfaef53a436caf663c35b47/components/payments/content/payment_request_state.cc
[modify] https://crrev.com/eea046d170daba05abfaef53a436caf663c35b47/components/payments/content/payment_request_state.h
[modify] https://crrev.com/eea046d170daba05abfaef53a436caf663c35b47/components/payments/content/payment_response_helper.cc
[modify] https://crrev.com/eea046d170daba05abfaef53a436caf663c35b47/components/payments/content/payment_response_helper.h
[modify] https://crrev.com/eea046d170daba05abfaef53a436caf663c35b47/components/payments/core/BUILD.gn
[modify] https://crrev.com/eea046d170daba05abfaef53a436caf663c35b47/components/payments/core/address_normalization_manager.cc
[modify] https://crrev.com/eea046d170daba05abfaef53a436caf663c35b47/components/payments/core/address_normalization_manager.h
[modify] https://crrev.com/eea046d170daba05abfaef53a436caf663c35b47/components/payments/core/address_normalization_manager_unittest.cc
[modify] https://crrev.com/eea046d170daba05abfaef53a436caf663c35b47/components/payments/core/autofill_payment_instrument.h
[modify] https://crrev.com/eea046d170daba05abfaef53a436caf663c35b47/components/payments/core/autofill_payment_instrument_unittest.cc
[modify] https://crrev.com/eea046d170daba05abfaef53a436caf663c35b47/components/payments/core/payment_request_base_delegate.h
[modify] https://crrev.com/eea046d170daba05abfaef53a436caf663c35b47/components/payments/core/payment_request_data_util.cc
[modify] https://crrev.com/eea046d170daba05abfaef53a436caf663c35b47/components/payments/core/payment_request_data_util.h
[modify] https://crrev.com/eea046d170daba05abfaef53a436caf663c35b47/components/payments/core/payment_request_data_util_unittest.cc
[modify] https://crrev.com/eea046d170daba05abfaef53a436caf663c35b47/components/payments/core/payments_profile_comparator.cc
[modify] https://crrev.com/eea046d170daba05abfaef53a436caf663c35b47/components/payments/core/test_payment_request_delegate.cc
[modify] https://crrev.com/eea046d170daba05abfaef53a436caf663c35b47/components/payments/core/test_payment_request_delegate.h
[modify] https://crrev.com/eea046d170daba05abfaef53a436caf663c35b47/ios/chrome/browser/payments/payment_request.h
[modify] https://crrev.com/eea046d170daba05abfaef53a436caf663c35b47/ios/chrome/browser/payments/payment_request.mm
[modify] https://crrev.com/eea046d170daba05abfaef53a436caf663c35b47/ios/chrome/browser/payments/payment_request_util.mm
[modify] https://crrev.com/eea046d170daba05abfaef53a436caf663c35b47/ios/chrome/browser/payments/payment_response_helper.mm
[modify] https://crrev.com/eea046d170daba05abfaef53a436caf663c35b47/ios/chrome/browser/payments/test_payment_request.h
[modify] https://crrev.com/eea046d170daba05abfaef53a436caf663c35b47/ios/chrome/browser/payments/test_payment_request.mm
[modify] https://crrev.com/eea046d170daba05abfaef53a436caf663c35b47/ios/chrome/browser/ui/payments/address_edit_mediator.mm
[modify] https://crrev.com/eea046d170daba05abfaef53a436caf663c35b47/ios/chrome/browser/ui/payments/contact_info_edit_mediator.mm

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/773c9d22c929637046b6667efe137c5c25b6d0ae

commit 773c9d22c929637046b6667efe137c5c25b6d0ae
Author: Mathieu Perreault <mathp@chromium.org>
Date: Tue Oct 03 01:19:34 2017

[Autofill] Move SubKeyRequester to Autofill instead of Payments

Bug:  767931 
Test: existing
Change-Id: I3289af3bf4644f8bea05cbe23d14574f0a17a414
Reviewed-on: https://chromium-review.googlesource.com/693089
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505902}
[modify] https://crrev.com/773c9d22c929637046b6667efe137c5c25b6d0ae/chrome/browser/autofill/android/personal_data_manager_android.cc
[modify] https://crrev.com/773c9d22c929637046b6667efe137c5c25b6d0ae/chrome/browser/autofill/android/personal_data_manager_android.h
[modify] https://crrev.com/773c9d22c929637046b6667efe137c5c25b6d0ae/components/autofill/core/browser/BUILD.gn
[rename] https://crrev.com/773c9d22c929637046b6667efe137c5c25b6d0ae/components/autofill/core/browser/subkey_requester.cc
[rename] https://crrev.com/773c9d22c929637046b6667efe137c5c25b6d0ae/components/autofill/core/browser/subkey_requester.h
[rename] https://crrev.com/773c9d22c929637046b6667efe137c5c25b6d0ae/components/autofill/core/browser/subkey_requester_unittest.cc
[modify] https://crrev.com/773c9d22c929637046b6667efe137c5c25b6d0ae/components/payments/content/BUILD.gn
[modify] https://crrev.com/773c9d22c929637046b6667efe137c5c25b6d0ae/components/payments/content/DEPS
[modify] https://crrev.com/773c9d22c929637046b6667efe137c5c25b6d0ae/components/payments/core/BUILD.gn
[modify] https://crrev.com/773c9d22c929637046b6667efe137c5c25b6d0ae/components/payments/core/DEPS

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1549017ab5d772390cccb145c99a5aee30e8184a

commit 1549017ab5d772390cccb145c99a5aee30e8184a
Author: Mathieu Perreault <mathp@chromium.org>
Date: Fri Oct 06 20:10:51 2017

[Autofill] Move AddressNormalizationManager to Autofill code

Bug:  767931 
Change-Id: I90671b2d53730a8af1f091d7fdc5d5b91d53b2fa
Reviewed-on: https://chromium-review.googlesource.com/694362
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507159}
[modify] https://crrev.com/1549017ab5d772390cccb145c99a5aee30e8184a/components/autofill/core/browser/BUILD.gn
[rename] https://crrev.com/1549017ab5d772390cccb145c99a5aee30e8184a/components/autofill/core/browser/address_normalization_manager.cc
[rename] https://crrev.com/1549017ab5d772390cccb145c99a5aee30e8184a/components/autofill/core/browser/address_normalization_manager.h
[rename] https://crrev.com/1549017ab5d772390cccb145c99a5aee30e8184a/components/autofill/core/browser/address_normalization_manager_unittest.cc
[modify] https://crrev.com/1549017ab5d772390cccb145c99a5aee30e8184a/components/payments/core/BUILD.gn
[modify] https://crrev.com/1549017ab5d772390cccb145c99a5aee30e8184a/ios/chrome/browser/payments/payment_request.h
[modify] https://crrev.com/1549017ab5d772390cccb145c99a5aee30e8184a/ios/chrome/browser/payments/payment_request.mm
[modify] https://crrev.com/1549017ab5d772390cccb145c99a5aee30e8184a/ios/chrome/browser/payments/payment_response_helper.mm
[modify] https://crrev.com/1549017ab5d772390cccb145c99a5aee30e8184a/ios/chrome/browser/payments/test_payment_request.h
[modify] https://crrev.com/1549017ab5d772390cccb145c99a5aee30e8184a/ios/chrome/browser/payments/test_payment_request.mm

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf67deeb3b5b0b69fc7ef512124dca0c0ae31ef4

commit cf67deeb3b5b0b69fc7ef512124dca0c0ae31ef4
Author: Mathieu Perreault <mathp@chromium.org>
Date: Wed Oct 18 21:54:44 2017

[Autofill] Cleaning up of AddressNormalizationManager

Changing the method names in anticipation of future change. Moving a
class to the implementation

Bug:  767931 
Change-Id: Id386a7708f05c501c7f44321dfa0b116215118cd
Tbr: mahmadi@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/726370
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509888}
[modify] https://crrev.com/cf67deeb3b5b0b69fc7ef512124dca0c0ae31ef4/components/autofill/core/browser/address_normalization_manager.cc
[modify] https://crrev.com/cf67deeb3b5b0b69fc7ef512124dca0c0ae31ef4/components/autofill/core/browser/address_normalization_manager.h
[modify] https://crrev.com/cf67deeb3b5b0b69fc7ef512124dca0c0ae31ef4/components/autofill/core/browser/address_normalization_manager_unittest.cc
[modify] https://crrev.com/cf67deeb3b5b0b69fc7ef512124dca0c0ae31ef4/ios/chrome/browser/payments/payment_response_helper.mm

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17c1ae92a469fb553f56f12731332a8b9bd6684e

commit 17c1ae92a469fb553f56f12731332a8b9bd6684e
Author: Mathieu Perreault <mathp@chromium.org>
Date: Fri Oct 20 17:16:00 2017

[Autofill] Change AddressNormalizer to take a callback

There was no need for a Delegate interface. A OnceCallback is cleaner in
my opinion. I think it simplifies the code.

Bug:  767931 
Test: existing
Change-Id: If765e2ee18f36ce8210f6c873e826b9a5bec5c30
Reviewed-on: https://chromium-review.googlesource.com/729543
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510472}
[modify] https://crrev.com/17c1ae92a469fb553f56f12731332a8b9bd6684e/chrome/browser/autofill/android/personal_data_manager_android.cc
[modify] https://crrev.com/17c1ae92a469fb553f56f12731332a8b9bd6684e/chrome/browser/autofill/android/personal_data_manager_android.h
[modify] https://crrev.com/17c1ae92a469fb553f56f12731332a8b9bd6684e/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc
[modify] https://crrev.com/17c1ae92a469fb553f56f12731332a8b9bd6684e/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.h
[modify] https://crrev.com/17c1ae92a469fb553f56f12731332a8b9bd6684e/components/autofill/core/browser/address_normalization_manager.cc
[modify] https://crrev.com/17c1ae92a469fb553f56f12731332a8b9bd6684e/components/autofill/core/browser/address_normalizer.h
[modify] https://crrev.com/17c1ae92a469fb553f56f12731332a8b9bd6684e/components/autofill/core/browser/address_normalizer_impl.cc
[modify] https://crrev.com/17c1ae92a469fb553f56f12731332a8b9bd6684e/components/autofill/core/browser/address_normalizer_impl.h
[modify] https://crrev.com/17c1ae92a469fb553f56f12731332a8b9bd6684e/components/autofill/core/browser/address_normalizer_impl_unittest.cc
[modify] https://crrev.com/17c1ae92a469fb553f56f12731332a8b9bd6684e/components/autofill/core/browser/test_address_normalizer.cc
[modify] https://crrev.com/17c1ae92a469fb553f56f12731332a8b9bd6684e/components/autofill/core/browser/test_address_normalizer.h
[modify] https://crrev.com/17c1ae92a469fb553f56f12731332a8b9bd6684e/components/payments/content/payment_request_state.cc
[modify] https://crrev.com/17c1ae92a469fb553f56f12731332a8b9bd6684e/components/payments/content/payment_request_state.h
[modify] https://crrev.com/17c1ae92a469fb553f56f12731332a8b9bd6684e/components/payments/content/payment_response_helper.cc
[modify] https://crrev.com/17c1ae92a469fb553f56f12731332a8b9bd6684e/components/payments/content/payment_response_helper.h
[modify] https://crrev.com/17c1ae92a469fb553f56f12731332a8b9bd6684e/components/payments/core/autofill_payment_instrument.cc
[modify] https://crrev.com/17c1ae92a469fb553f56f12731332a8b9bd6684e/components/payments/core/autofill_payment_instrument.h
[modify] https://crrev.com/17c1ae92a469fb553f56f12731332a8b9bd6684e/components/payments/core/autofill_payment_instrument_unittest.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c94700f11af40123e684c287f2a0400868400790

commit c94700f11af40123e684c287f2a0400868400790
Author: Mathieu Perreault <mathp@chromium.org>
Date: Mon Oct 23 20:28:39 2017

[Autofill] NormalizeAddressSync and NormalizeAddressAsync

Split the API in a sync and async version. Used the Sync version
in Payment Request. May convert more in the future.

Added tests and cleanup.

Bug:  767931 
Change-Id: If7cfced750928f3aa2e1e75301ad27717612340d
Reviewed-on: https://chromium-review.googlesource.com/730567
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510899}
[modify] https://crrev.com/c94700f11af40123e684c287f2a0400868400790/chrome/browser/autofill/android/personal_data_manager_android.cc
[modify] https://crrev.com/c94700f11af40123e684c287f2a0400868400790/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc
[modify] https://crrev.com/c94700f11af40123e684c287f2a0400868400790/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.h
[modify] https://crrev.com/c94700f11af40123e684c287f2a0400868400790/components/autofill/core/browser/address_normalization_manager.cc
[modify] https://crrev.com/c94700f11af40123e684c287f2a0400868400790/components/autofill/core/browser/address_normalizer.h
[modify] https://crrev.com/c94700f11af40123e684c287f2a0400868400790/components/autofill/core/browser/address_normalizer_impl.cc
[modify] https://crrev.com/c94700f11af40123e684c287f2a0400868400790/components/autofill/core/browser/address_normalizer_impl.h
[modify] https://crrev.com/c94700f11af40123e684c287f2a0400868400790/components/autofill/core/browser/address_normalizer_impl_unittest.cc
[modify] https://crrev.com/c94700f11af40123e684c287f2a0400868400790/components/autofill/core/browser/autofill_test_utils.cc
[modify] https://crrev.com/c94700f11af40123e684c287f2a0400868400790/components/autofill/core/browser/autofill_test_utils.h
[modify] https://crrev.com/c94700f11af40123e684c287f2a0400868400790/components/autofill/core/browser/test_address_normalizer.cc
[modify] https://crrev.com/c94700f11af40123e684c287f2a0400868400790/components/autofill/core/browser/test_address_normalizer.h
[modify] https://crrev.com/c94700f11af40123e684c287f2a0400868400790/components/payments/content/payment_request_state.cc
[modify] https://crrev.com/c94700f11af40123e684c287f2a0400868400790/components/payments/content/payment_response_helper.cc
[modify] https://crrev.com/c94700f11af40123e684c287f2a0400868400790/components/payments/core/autofill_payment_instrument.cc

Comment 8 by hdodda@chromium.org, Oct 25 2017

Cc: hdodda@chromium.org
Labels: Needs-Feedback
Tested the issue on windows 10 , Mac os 10.12.6 and ubuntu 14.04 using chrome M64 #64.0.3249.0 and followed below steps :

1. Added the address in chrome://settings/autofill.
2. After signing into target.com and during shipping address, autofilled the addressed and observed that all the fields autofilled.

Attached screencast for reference.

@mathp-- Could you please check attached screencast and confirm us if this is expected or if we have missed any steps in reproducing the issue.

Thanks!
767931.mp4
986 KB View Download

Comment 9 by ma...@chromium.org, Oct 25 2017

Issue is not fixed yet, will give repro steps once it's marked Fixed
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a75bf740de716fc8199cafc6026f9e4199a2511a

commit a75bf740de716fc8199cafc6026f9e4199a2511a
Author: Mathieu Perreault <mathp@chromium.org>
Date: Fri Nov 17 19:55:49 2017

[Autofill] Create FieldFiller helper class

Currently holding on to app_locale but will soon also
gain Address normalization tools.

This is functionality neutral.

Bug:  767931 
Test: existing
Change-Id: I2dfbf93b4e6b8b891c0f78b4fcde615dedf37b1e
Reviewed-on: https://chromium-review.googlesource.com/775813
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517521}
[modify] https://crrev.com/a75bf740de716fc8199cafc6026f9e4199a2511a/components/autofill/core/browser/BUILD.gn
[modify] https://crrev.com/a75bf740de716fc8199cafc6026f9e4199a2511a/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/a75bf740de716fc8199cafc6026f9e4199a2511a/components/autofill/core/browser/autofill_manager.h
[modify] https://crrev.com/a75bf740de716fc8199cafc6026f9e4199a2511a/components/autofill/core/browser/credit_card_field.cc
[rename] https://crrev.com/a75bf740de716fc8199cafc6026f9e4199a2511a/components/autofill/core/browser/field_filler.cc
[add] https://crrev.com/a75bf740de716fc8199cafc6026f9e4199a2511a/components/autofill/core/browser/field_filler.h
[rename] https://crrev.com/a75bf740de716fc8199cafc6026f9e4199a2511a/components/autofill/core/browser/field_filler_unittest.cc
[delete] https://crrev.com/9d7de5fe800da373521a884e2767c68b5b60cc21/components/autofill/core/browser/fill_util.h

Project Member

Comment 11 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b40d51095760e7c05fbf321f6f231a72b3ef012

commit 9b40d51095760e7c05fbf321f6f231a72b3ef012
Author: Mathieu Perreault <mathp@chromium.org>
Date: Tue Nov 21 20:51:29 2017

[Autofill] Simplify the interface of AddressNormalizer

NormalizeAddress{Sync/Async} will now use the profile's region (or
fallback to the app_locale's region) when normalizing.

Bug:  767931 
Test: existing`
Tbr: mahmadi
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I2bda562786e2fd6b6f50ffaf27c6fa7942eeafb7
Reviewed-on: https://chromium-review.googlesource.com/782039
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518382}
[modify] https://crrev.com/9b40d51095760e7c05fbf321f6f231a72b3ef012/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java
[modify] https://crrev.com/9b40d51095760e7c05fbf321f6f231a72b3ef012/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java
[modify] https://crrev.com/9b40d51095760e7c05fbf321f6f231a72b3ef012/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/9b40d51095760e7c05fbf321f6f231a72b3ef012/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentResponseHelper.java
[modify] https://crrev.com/9b40d51095760e7c05fbf321f6f231a72b3ef012/chrome/browser/autofill/address_normalizer_factory.cc
[modify] https://crrev.com/9b40d51095760e7c05fbf321f6f231a72b3ef012/chrome/browser/autofill/android/personal_data_manager_android.cc
[modify] https://crrev.com/9b40d51095760e7c05fbf321f6f231a72b3ef012/chrome/browser/autofill/android/personal_data_manager_android.h
[modify] https://crrev.com/9b40d51095760e7c05fbf321f6f231a72b3ef012/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc
[modify] https://crrev.com/9b40d51095760e7c05fbf321f6f231a72b3ef012/components/autofill/core/browser/address_normalization_manager.cc
[modify] https://crrev.com/9b40d51095760e7c05fbf321f6f231a72b3ef012/components/autofill/core/browser/address_normalizer.h
[modify] https://crrev.com/9b40d51095760e7c05fbf321f6f231a72b3ef012/components/autofill/core/browser/address_normalizer_impl.cc
[modify] https://crrev.com/9b40d51095760e7c05fbf321f6f231a72b3ef012/components/autofill/core/browser/address_normalizer_impl.h
[modify] https://crrev.com/9b40d51095760e7c05fbf321f6f231a72b3ef012/components/autofill/core/browser/address_normalizer_impl_unittest.cc
[modify] https://crrev.com/9b40d51095760e7c05fbf321f6f231a72b3ef012/components/autofill/core/browser/test_address_normalizer.cc
[modify] https://crrev.com/9b40d51095760e7c05fbf321f6f231a72b3ef012/components/autofill/core/browser/test_address_normalizer.h
[modify] https://crrev.com/9b40d51095760e7c05fbf321f6f231a72b3ef012/components/payments/content/payment_request_state.cc
[modify] https://crrev.com/9b40d51095760e7c05fbf321f6f231a72b3ef012/components/payments/content/payment_response_helper.cc
[modify] https://crrev.com/9b40d51095760e7c05fbf321f6f231a72b3ef012/components/payments/core/autofill_payment_instrument.cc
[modify] https://crrev.com/9b40d51095760e7c05fbf321f6f231a72b3ef012/ios/chrome/browser/payments/payment_request.mm

Project Member

Comment 12 by bugdroid1@chromium.org, Nov 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b492842fcc2c05087efbc8fa9be477ebc758002

commit 1b492842fcc2c05087efbc8fa9be477ebc758002
Author: Mathieu Perreault <mathp@chromium.org>
Date: Mon Nov 27 21:05:53 2017

[Autofill] Normalize state/region names during filling

Using the AddressNormalizer and the metadata, we can normalize field
values and the user's region value to make sure they are compatible
when filling.

Bug:  767931 
Test: components_unittests
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I5f5451e9a8ddaaba31779eeeab2f41e2b0b35e38
Reviewed-on: https://chromium-review.googlesource.com/788453
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519393}
[modify] https://crrev.com/1b492842fcc2c05087efbc8fa9be477ebc758002/android_webview/browser/aw_autofill_client.cc
[modify] https://crrev.com/1b492842fcc2c05087efbc8fa9be477ebc758002/android_webview/browser/aw_autofill_client.h
[modify] https://crrev.com/1b492842fcc2c05087efbc8fa9be477ebc758002/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/1b492842fcc2c05087efbc8fa9be477ebc758002/chrome/browser/ui/autofill/chrome_autofill_client.h
[modify] https://crrev.com/1b492842fcc2c05087efbc8fa9be477ebc758002/components/autofill/core/browser/BUILD.gn
[modify] https://crrev.com/1b492842fcc2c05087efbc8fa9be477ebc758002/components/autofill/core/browser/address_normalizer_impl.cc
[modify] https://crrev.com/1b492842fcc2c05087efbc8fa9be477ebc758002/components/autofill/core/browser/autofill_client.h
[modify] https://crrev.com/1b492842fcc2c05087efbc8fa9be477ebc758002/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/1b492842fcc2c05087efbc8fa9be477ebc758002/components/autofill/core/browser/autofill_manager.h
[modify] https://crrev.com/1b492842fcc2c05087efbc8fa9be477ebc758002/components/autofill/core/browser/field_filler.cc
[modify] https://crrev.com/1b492842fcc2c05087efbc8fa9be477ebc758002/components/autofill/core/browser/field_filler.h
[modify] https://crrev.com/1b492842fcc2c05087efbc8fa9be477ebc758002/components/autofill/core/browser/field_filler_unittest.cc
[modify] https://crrev.com/1b492842fcc2c05087efbc8fa9be477ebc758002/components/autofill/core/browser/test_autofill_client.cc
[modify] https://crrev.com/1b492842fcc2c05087efbc8fa9be477ebc758002/components/autofill/core/browser/test_autofill_client.h
[modify] https://crrev.com/1b492842fcc2c05087efbc8fa9be477ebc758002/components/autofill/core/common/autofill_features.cc
[modify] https://crrev.com/1b492842fcc2c05087efbc8fa9be477ebc758002/components/autofill/core/common/autofill_features.h
[modify] https://crrev.com/1b492842fcc2c05087efbc8fa9be477ebc758002/components/autofill/ios/browser/autofill_client_ios.h
[modify] https://crrev.com/1b492842fcc2c05087efbc8fa9be477ebc758002/components/autofill/ios/browser/autofill_client_ios.mm
[modify] https://crrev.com/1b492842fcc2c05087efbc8fa9be477ebc758002/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.h
[modify] https://crrev.com/1b492842fcc2c05087efbc8fa9be477ebc758002/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.mm

Comment 13 by ma...@chromium.org, Nov 27 2017

Status: Fixed (was: Assigned)

Sign in to add a comment