New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 767924 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Changing a PPD type through edit doesn't remove old values

Project Member Reported by skau@chromium.org, Sep 22 2017

Issue description

Chrome Version: 63.0.3219.0
OS: CrOS

What steps will reproduce the problem?
(1) Add an autoconf printer manually
(2) Edit printer from list
(3) Select a user provided printer

What is the expected result?
Printer switches to user provided PPD

What happens instead?
Printer is still autoconf.  Sync record shows the value is added but autoconf was not removed.

Please use labels and text to provide additional information.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 

Comment 1 by skau@chromium.org, Sep 22 2017

Components: Internals>Printing>CUPS

Comment 2 by skau@chromium.org, Sep 25 2017

Cc: skau@chromium.org
Owner: ----

Comment 3 by skau@chromium.org, Oct 5 2017

Owner: jycai@chromium.org
Status: Assigned (was: Available)
You can see the printer configuration in chrome://sync-internals

Comment 4 by skau@chromium.org, Nov 7 2017

Labels: -Pri-1 M-65 Pri-2
Owner: luum@chromium.org
Labels: -M-65 M-66

Comment 6 by skau@chromium.org, Feb 15 2018

Labels: Bolton-FixIt-2018
Labels: -Pri-2 Pri-1
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37c4da4be16e50086c75d40142988dad2293dda3

commit 37c4da4be16e50086c75d40142988dad2293dda3
Author: Luum Habtemariam <luum@chromium.org>
Date: Wed Feb 21 20:43:20 2018

Addressing PPD type edit bug

Fixed. Now correctly edits PPD type and ensures only one PPD type is
ever selected at one time. Printers currently setup and presenting this
bug will have to be re-edited for this change to take effect
(chromium:814374 is tracking this).

Current behavior: Will always favor autoconf on printer setup, if
possible. Else will take any PPD type provided by user.

Bug:  chromium:767924 
Change-Id: I7172c9d8d831916d7a49d02d0db38a01458f0006
Reviewed-on: https://chromium-review.googlesource.com/929301
Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Luum Habtemariam <luum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538199}
[modify] https://crrev.com/37c4da4be16e50086c75d40142988dad2293dda3/chrome/browser/chromeos/printing/printers_sync_bridge.cc

Comment 9 by luum@chromium.org, Feb 21 2018

Status: Fixed (was: Assigned)

Sign in to add a comment