New issue
Advanced search Search tips

Issue 767915 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 766263



Sign in to add a comment

All informational builds failed at BuildPackages step

Project Member Reported by x...@chromium.org, Sep 22 2017

Issue description

See an example build: https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/veyron_minnie-tot-chrome-pfq-informational/builds/6112

Selected error message:
chromeos-chrome-63.0.3223.0_alpha-r1: /home/chrome-bot/depot_tools/gclient runhooks --force
chromeos-chrome-63.0.3223.0_alpha-r1: 
chromeos-chrome-63.0.3223.0_alpha-r1: src (ERROR)
chromeos-chrome-63.0.3223.0_alpha-r1: ----------------------------------------
chromeos-chrome-63.0.3223.0_alpha-r1: [0:00:00] Started.
chromeos-chrome-63.0.3223.0_alpha-r1: ----------------------------------------
chromeos-chrome-63.0.3223.0_alpha-r1: Error: 1> dependency url must be either a string, None, or From() instead of dict
chromeos-chrome-63.0.3223.0_alpha-r1:  * ERROR: chromeos-base/chromeos-chrome-63.0.3223.0_alpha-r1::chromiumos failed (configure phase):
chromeos-chrome-63.0.3223.0_alpha-r1:  *   (no error message)
chromeos-chrome-63.0.3223.0_alpha-r1:  * 
chromeos-chrome-63.0.3223.0_alpha-r1:  * Call stack:
chromeos-chrome-63.0.3223.0_alpha-r1:  *     ebuild.sh, line  93:  Called src_configure
chromeos-chrome-63.0.3223.0_alpha-r1:  *   environment, line 3819:  Called die
chromeos-chrome-63.0.3223.0_alpha-r1:  * The specific snippet of code:
chromeos-chrome-63.0.3223.0_alpha-r1:  *           CFLAGS="${CFLAGS} ${EBUILD_CFLAGS[*]}" CXXFLAGS="${CXXFLAGS} ${EBUILD_CXXFLAGS[*]}" "${cmd[@]}" || die;
chromeos-chrome-63.0.3223.0_alpha-r1:  * 
chromeos-chrome-63.0.3223.0_alpha-r1:  * If you need support, post the output of `emerge --info '=chromeos-base/chromeos-chrome-63.0.3223.0_alpha-r1::chromiumos'`,
chromeos-chrome-63.0.3223.0_alpha-r1:  * the complete build log and the output of `emerge -pqv '=chromeos-base/chromeos-chrome-63.0.3223.0_alpha-r1::chromiumos'`.
chromeos-chrome-63.0.3223.0_alpha-r1:  * The complete build log is located at '/build/veyron_minnie/tmp/portage/logs/chromeos-base:chromeos-chrome-63.0.3223.0_alpha-r1:20170922-093840.log'.
chromeos-chrome-63.0.3223.0_alpha-r1:  * For convenience, a symlink to the build log is located at '/build/veyron_minnie/tmp/portage/chromeos-base/chromeos-chrome-63.0.3223.0_alpha-r1/temp/build.log'.
chromeos-chrome-63.0.3223.0_alpha-r1:  * The ebuild environment file is located at '/build/veyron_minnie/tmp/portage/chromeos-base/chromeos-chrome-63.0.3223.0_alpha-r1/temp/environment'.
chromeos-chrome-63.0.3223.0_alpha-r1:  * Working directory: '/build/veyron_minnie/tmp/portage/chromeos-base/chromeos-chrome-63.0.3223.0_alpha-r1/work/chromeos-chrome-63.0.3223.0_alpha'
chromeos-chrome-63.0.3223.0_alpha-r1:  * S: '/build/veyron_minnie/tmp/portage/chromeos-base/chromeos-chrome-63.0.3223.0_alpha-r1/work/chromeos-chrome-63.0.3223.0_alpha'
chromeos-chrome-63.0.3223.0_alpha-r1: >>> Failed to emerge chromeos-base/chromeos-chrome-63.0.3223.0_alpha-r1 for /build/veyron_minnie/, Log file:
chromeos-chrome-63.0.3223.0_alpha-r1: >>>  '/build/veyron_minnie/tmp/portage/logs/chromeos-base:chromeos-chrome-63.0.3223.0_alpha-r1:20170922-093840.log'
chromeos-chrome-63.0.3223.0_alpha-r1: 
chromeos-chrome-63.0.3223.0_alpha-r1:  * Messages for package chromeos-base/chromeos-chrome-63.0.3223.0_alpha-r1 merged to /build/veyron_minnie/:
chromeos-chrome-63.0.3223.0_alpha-r1: 
chromeos-chrome-63.0.3223.0_alpha-r1:  * CHROME_ORIGIN VALUE is LOCAL_SOURCE
chromeos-chrome-63.0.3223.0_alpha-r1:  * /home/chrome-bot/chrome_root should be set here properly
chromeos-chrome-63.0.3223.0_alpha-r1:  * ERROR: chromeos-base/chromeos-chrome-63.0.3223.0_alpha-r1::chromiumos failed (configure phase):
chromeos-chrome-63.0.3223.0_alpha-r1:  *   (no error message)
chromeos-chrome-63.0.3223.0_alpha-r1:  * 
chromeos-chrome-63.0.3223.0_alpha-r1:  * Call stack:
chromeos-chrome-63.0.3223.0_alpha-r1:  *     ebuild.sh, line  93:  Called src_configure
chromeos-chrome-63.0.3223.0_alpha-r1:  *   environment, line 3819:  Called die
chromeos-chrome-63.0.3223.0_alpha-r1:  * The specific snippet of code:
chromeos-chrome-63.0.3223.0_alpha-r1:  *           CFLAGS="${CFLAGS} ${EBUILD_CFLAGS[*]}" CXXFLAGS="${CXXFLAGS} ${EBUILD_CXXFLAGS[*]}" "${cmd[@]}" || die;

It looks similar to  Issue 767150 . Suspicious CL: 
https://chromium-review.googlesource.com/c/chromium/src/+/677460 again?
 
Owner: dgarr...@chromium.org
Status: Started (was: Untriaged)
Based on the command path above "/home/chrome-bot/depot_tools" it looks like the failure is inside the chroot.

I'd forgotten, but there is ALSO a depot_tools pin in our manifests that is used inside the chroot. I'm updating this to match the recipe. I'll also add comments both in the manifests and the recipe to tell people to keep them in sync.
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 23 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/manifest-internal/+/a0a6d306ac42fb056fb089372970a274adb9bc6f

commit a0a6d306ac42fb056fb089372970a274adb9bc6f
Author: Don Garrett <dgarrett@google.com>
Date: Sat Sep 23 05:25:32 2017

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/manifest/+/dceb67bd626b71c3869b6498aa0afc6d21e65e45

commit dceb67bd626b71c3869b6498aa0afc6d21e65e45
Author: Don Garrett <dgarrett@google.com>
Date: Sat Sep 23 05:25:32 2017

depot_tools: Pin bump for updated chrome tools.

This pin exactly matches what was set in the recipe in CL:677457.

Added comment about keeping in sync with recipe. Will need a comment
in the recipe as well.

BUG= chromium:767915 
TEST=None
CQ-DEPEND=CL:*460276

Change-Id: Ia375c745eb82524619777dcc6195a02a505c1674
Reviewed-on: https://chromium-review.googlesource.com/679037
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/dceb67bd626b71c3869b6498aa0afc6d21e65e45/full.xml

Blocking: 766263

Comment 6 by vadimt@chromium.org, Sep 25 2017

Cc: -vadimt@chromium.org
Status: Fixed (was: Started)
The manifest pin bump in is place, and the builders are green (mostly).
PS: I'm landing comments on both the recipe and manifest sides to guide people to keep them in sync in the future.

For a variety of reasons, that can't be done automatically.

Also, be aware that when doing branch builds you will get the current recipe pinned version of depot_tools outside the chroot, but the branched version of the pin inside the chroot.
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/1cd521a70e4ffa519304170820d25c3c543c751e

commit 1cd521a70e4ffa519304170820d25c3c543c751e
Author: Don Garrett <dgarrett@google.com>
Date: Tue Sep 26 00:11:30 2017

chromite/api.py: Update comments, remove dead code.

Add a comment to a second location that should be kept in sync with
the depot_tools pin used here. Make a few other comments a little more
informative, and remove support for a dead command line option.

BUG= chromium:767915 
TBR=agable@chromium.org, akeshet@chromium.org

Change-Id: I08e5e8a2229b6667d6ff2f46026535a5381c2090
Reviewed-on: https://chromium-review.googlesource.com/678044
Reviewed-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>
Commit-Queue: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/1cd521a70e4ffa519304170820d25c3c543c751e/scripts/slave/recipe_modules/chromite/OWNERS
[modify] https://crrev.com/1cd521a70e4ffa519304170820d25c3c543c751e/scripts/slave/recipe_modules/chromite/api.py
[modify] https://crrev.com/1cd521a70e4ffa519304170820d25c3c543c751e/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_harness_failure.json
[add] https://crrev.com/1cd521a70e4ffa519304170820d25c3c543c751e/scripts/slave/recipes/ndk/OWNERS
[modify] https://crrev.com/1cd521a70e4ffa519304170820d25c3c543c751e/scripts/slave/README.recipes.md
[modify] https://crrev.com/1cd521a70e4ffa519304170820d25c3c543c751e/scripts/slave/recipes/cros/cbuildbot.expected/chromiumos_coverage.json
[add] https://crrev.com/1cd521a70e4ffa519304170820d25c3c543c751e/scripts/slave/recipes/cros/OWNERS
[modify] https://crrev.com/1cd521a70e4ffa519304170820d25c3c543c751e/scripts/slave/recipes/ndk/ndk_buildbot.expected/basic.json
[modify] https://crrev.com/1cd521a70e4ffa519304170820d25c3c543c751e/scripts/slave/recipes/cros/cbuildbot.expected/chromiumos_coverage_variant.json

Comment 10 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 11 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment