New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 767868 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Desktop notifications cannot be clicked.

Reported by canb...@gmail.com, Sep 22 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3222.2 Safari/537.36

Steps to reproduce the problem:
1. Open haberler.com and subscribe for notifications (Allow notifications from site settings.)
2. Whenever a notification comes, try to click on it.
3. Notification cannot be clicked (Only close and settings icon can be clicked)

What is the expected behavior?
Notification should be clicked and navigate user to the proper site.

What went wrong?
Notification cannot be clicked. 

And there are notifications coming that says "the website haberler.com updated background" which is also not clickable.

Did this work before? N/A 

Chrome version: 63.0.3222.2  Channel: n/a
OS Version: 10.0
Flash Version:
 
Labels: Needs-Triage-M63
Cc: divya.pa...@techmahindra.com
Labels: Needs-Feedback Triaged-ET
@Reporter: Checked the issue on windows 10 on 63.0.3222.2,with the following steps
1.I have tried clicking the URL provided, 
2.then enabled the notifications from that site through settings.
3. Even though I browsed and waited for some time I couldn't get any notifications on my screen to check whether they are clickable or not. 
Could you please tell whether the notifications are time bound. 

Comment 3 by fricca...@gmail.com, Sep 26 2017

With Chrome 63.0.3223.8 (Canary) and 63.0.3218.0 (Dev) on Win 10 I see the issue also with https://gauntface.github.io/simple-push-demo/
If a notification is sent via the web interface it cannot be clicked.
If it is sent via dev tools (Application - Service Workers - Push) it can.

In our own implementation I also occasionally get the message "the website updated in the background" but have not seen this for the push demo yet.
 

Comment 4 by rpop@chromium.org, Oct 4 2017

Reporter, could you provide your exact Windows OS version/build and SKU (Home/Pro)? We have not been able to repro.

Comment 5 by canb...@gmail.com, Oct 4 2017

Windows 10 Home 64 bit
Project Member

Comment 6 by sheriffbot@chromium.org, Oct 4 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "divya.padigela@techmahindra.com" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: sc00335...@techmahindra.com
Components: -UI UI>Notifications
Labels: -Type-Bug -Pri-2 ReleaseBlock-Stable M-63 OS-Linux Pri-1 Type-Bug-Regression
Owner: est...@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce this issue on reported version 63.0.3222.2 and on latest canary 63.0.3236.0 using Ubuntu 14.04,Windows 10 with URL given in comment#3.
Issue is not reproducible on Mac 10.12.6

Good Build: 63.0.3214.0
Bad Build: 63.0.3215.0

You are probably looking for a change made after 501508 (known good), but no later than 501509 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/e44b98077549c5901abeeb22d372abdb7ba4dbda..7ff08dc7700829e4d0dd5c100faeee7fe4ad0ddf

Reviewed-on: https://chromium-review.googlesource.com/657599

Suspecting same from aabove changelog.

@estade: Please confirm the bug and help in re-assigning if it is not related to your change.

Adding RB-Stable as this is recent regression. Please change if not the case.
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26222fc987eee4c9ccdf8eecb4398fa401ac1e6b

commit 26222fc987eee4c9ccdf8eecb4398fa401ac1e6b
Author: Evan Stade <estade@chromium.org>
Date: Tue Oct 10 23:53:17 2017

Fix clickability of web notifications.

The fix is in GetAllIdsByProfile. This patch also removes
GetAllIdsByProfileAndSourceOrigin() which is similarly broken, but
currently unused.

Bug:  767868 
Change-Id: I75c3d286b1a982b6938ed6cd6ca54bbbd1a4a76e
Reviewed-on: https://chromium-review.googlesource.com/709997
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507828}
[modify] https://crrev.com/26222fc987eee4c9ccdf8eecb4398fa401ac1e6b/chrome/browser/notifications/message_center_notification_manager.cc
[modify] https://crrev.com/26222fc987eee4c9ccdf8eecb4398fa401ac1e6b/chrome/browser/notifications/message_center_notification_manager.h
[add] https://crrev.com/26222fc987eee4c9ccdf8eecb4398fa401ac1e6b/chrome/browser/notifications/message_center_notification_manager_interactive_uitest.cc
[modify] https://crrev.com/26222fc987eee4c9ccdf8eecb4398fa401ac1e6b/chrome/browser/notifications/message_center_notifications_unittest.cc
[modify] https://crrev.com/26222fc987eee4c9ccdf8eecb4398fa401ac1e6b/chrome/browser/notifications/notification_test_util.cc
[modify] https://crrev.com/26222fc987eee4c9ccdf8eecb4398fa401ac1e6b/chrome/browser/notifications/notification_test_util.h
[modify] https://crrev.com/26222fc987eee4c9ccdf8eecb4398fa401ac1e6b/chrome/browser/notifications/notification_ui_manager.h
[modify] https://crrev.com/26222fc987eee4c9ccdf8eecb4398fa401ac1e6b/chrome/browser/notifications/profile_notification.cc
[modify] https://crrev.com/26222fc987eee4c9ccdf8eecb4398fa401ac1e6b/chrome/browser/notifications/profile_notification.h
[modify] https://crrev.com/26222fc987eee4c9ccdf8eecb4398fa401ac1e6b/chrome/test/BUILD.gn

sc00335628@ can you please verify this in today's canary.
Labels: TE-Verified-M63 TE-Verified-63.0.3239.7
Tested the issue on 63.0.3239.7 using Ubuntu 14.04 and is no longer reproducible with  https://gauntface.github.io/simple-push-demo/ .

Hence adding TE-Verified labels.

Thanks!
Attaching screencast for reference.
Issue 767868.ogv
1.9 MB View Download
Status: Verified (was: Assigned)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-63; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-63 label, otherwise remove Merge-TBD label. Thanks.
Labels: -Merge-TBD
branch was 508578 and this landed as 507828 so there's no need to merge.

Sign in to add a comment