Regression: Save Password bubble reappears after password has been already saved.
Reported by
vineetha...@etouch.net,
Sep 22 2017
|
|||
Issue descriptionChrome version: 63.0.3222.0 7754c77f5af465147885e57c6ba7fc4e9095d842-refs/heads/master@{#503582} OS: Windows (7,8,10),Linux (14.04 LTS), Mac(10.12.6). Steps to reproduce: 1. Launch Chrome > Navigate to www.gmail.com 2. Enter valid username and password and after clicking "Next" button,click on the password bubble that appears on the R.H.S of the omnibox and click "Save" button. 3. Observe that password gets saved in Setting > Passwords and Forms > Manage Password 4. Navigate back to gmail account and observe Save Password bubble reappears. Actual Result: Save Password bubble reappears after password has been already saved. Expected Result: Save Password bubble should not appear after password has been already saved. This is Regression Issue broken in M-62 and and Using the per-revision bisect providing the bisect results, Good Build: 62.0.3181.0(Revision:493198) Bad Build: 62.0.3182.0(Revision:493619) You are probably looking for a change made after 493336 (known good), but no later than 493337 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/4f9d2469ba713829aaa2e62fdd766a64cb5965d3..7cf7408af869f5b605a6f35cdd458380c56fb73d Suspect: https://chromium.googlesource.com/chromium/src/+/7cf7408af869f5b605a6f35cdd458380c56fb73d @kolos: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.
,
Sep 25 2017
thanks for reporting. It revealed an important bug. I will look into it.
,
Oct 11 2017
As I understand, it happened because of race conditions. The user clicked "Login" and then click to save the password while the navigation is in progress which is tricky ;) The second bubble shouldn't appear actually because the username/password pair has been sent for saving, but the password manager hasn't received an update from the store and tries to save the credential again. Could you please repeat the steps a bit slower? 1. Click to save your password without submission. 2. Click "Login". 3. The bubble shouldn't reappear. It works ok for Autofill Smoke test (https://rsolomakhin.github.io/autofill/).
,
Oct 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/64aae3069d6fe3c7227f5fae82a8e8c68e9359cf commit 64aae3069d6fe3c7227f5fae82a8e8c68e9359cf Author: Maxim Kolosovskiy <kolos@chromium.org> Date: Thu Oct 12 19:46:16 2017 [Password Manager] Don't show the fallback for saving if the credential is already saved Bug: 725883 , 767861 , 774012 Change-Id: I64b4729a1db3c450fc532403bb9764e2e8adcbb4 Reviewed-on: https://chromium-review.googlesource.com/714176 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#508387} [modify] https://crrev.com/64aae3069d6fe3c7227f5fae82a8e8c68e9359cf/components/password_manager/core/browser/password_manager.cc [modify] https://crrev.com/64aae3069d6fe3c7227f5fae82a8e8c68e9359cf/components/password_manager/core/browser/password_manager_unittest.cc
,
Oct 13 2017
Can this be marked as fixed as well?
,
Oct 13 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by rbasuvula@chromium.org
, Sep 23 2017