Regression:'To' text field goes missing from Gmail compose window
Reported by
pranjali...@etouch.net,
Sep 22 2017
|
|||||||
Issue descriptionChrome Version:63.0.3222.0 (Official Build) 7754c77f5af465147885e57c6ba7fc4e9095d842-refs/heads/master@{#503582}(32/64 bit). OS: Windows (7,8,10),Linux (14.04 LTS), Mac(10.12.6). Precondition: Sign in to Gmail with valid credentials. Steps to reproduce: 1)Launch chrome and go to 'https://mail.google.com/mail/u/0/#inbox'. 2)Click on 'compose' button, add 2-3 valid email ids and subject. 3)Now press shift+esc key and end process for gmail tab. 4)Now reload the killed tab and observe. Actual Result:'To' text field goes missing from gmail compose window after reloading killed tab. Expected Result:'To' text field should stay after reloading killed tab. This is regression issue broken in 'M-62' and below per-revision bisect result Using the per-revision bisect providing the bisect results, Good build: 62.0.3200.0 Bad build: 62.0.3201.0 You are probably looking for a change made after 498416 (known good), but no later than 498417 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/fe2758ee73750adeafa452908c305a601edbdd35..a87ff17992abb8eea93e035b7e355824f5ff74d9 Suspect: https://chromium.googlesource.com/chromium/src/+/a87ff17992abb8eea93e035b7e355824f5ff74d9 @rune- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thanks!
,
Sep 25 2017
,
Sep 25 2017
,
Sep 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b37246c8f89310cb5f8d94c385627b6b596a0c6 commit 5b37246c8f89310cb5f8d94c385627b6b596a0c6 Author: Rune Lillesveen <rune@opera.com> Date: Tue Sep 26 04:43:44 2017 Store new ComputedStyle object if style did not change. The comparison of ComputedStyle does not take additional flags into account. For instance, the AffectedBy* flags used for updating pseudo classes like :hover. We used to call SetStyleInternal, but this was removed because the previous comment said it was because of style sharing which is now removed. The display:contents case (768406) never worked because the code path for StoreNonLayoutObjectComputedStyle() was always skipped when computed style compared to be equal. Bug: 768406 , 767832 Change-Id: Iac4708e3cd3a6451d99c1bb2bb69efb74289b8eb Reviewed-on: https://chromium-review.googlesource.com/681755 Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Rune Lillesveen <rune@opera.com> Cr-Commit-Position: refs/heads/master@{#504285} [add] https://crrev.com/5b37246c8f89310cb5f8d94c385627b6b596a0c6/third_party/WebKit/LayoutTests/fast/dynamic/hover-after-affected-by-change.html [modify] https://crrev.com/5b37246c8f89310cb5f8d94c385627b6b596a0c6/third_party/WebKit/Source/core/dom/Element.cpp
,
Sep 26 2017
,
Sep 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ac19ac76519aaa0e4ffd228629d4488d5efea79 commit 8ac19ac76519aaa0e4ffd228629d4488d5efea79 Author: Marc Treib <treib@chromium.org> Date: Tue Sep 26 08:18:11 2017 Revert "Store new ComputedStyle object if style did not change." This reverts commit 5b37246c8f89310cb5f8d94c385627b6b596a0c6. Reason for revert: hover-after-affected-by-change.html consistently fails on WebKit Linux Trusty Leak: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak Original change's description: > Store new ComputedStyle object if style did not change. > > The comparison of ComputedStyle does not take additional flags into > account. For instance, the AffectedBy* flags used for updating pseudo > classes like :hover. We used to call SetStyleInternal, but this was > removed because the previous comment said it was because of style > sharing which is now removed. > > The display:contents case (768406) never worked because the code path > for StoreNonLayoutObjectComputedStyle() was always skipped when > computed style compared to be equal. > > Bug: 768406 , 767832 > Change-Id: Iac4708e3cd3a6451d99c1bb2bb69efb74289b8eb > Reviewed-on: https://chromium-review.googlesource.com/681755 > Reviewed-by: nainar <nainar@chromium.org> > Commit-Queue: Rune Lillesveen <rune@opera.com> > Cr-Commit-Position: refs/heads/master@{#504285} TBR=rune@opera.com,nainar@chromium.org Change-Id: I34a54b694bb719b278426f9a76076fa77cd9e82f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 768406 , 767832 Reviewed-on: https://chromium-review.googlesource.com/684275 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#504313} [delete] https://crrev.com/a3f3699bedf7166984c5c4664f673eecb7486aaa/third_party/WebKit/LayoutTests/fast/dynamic/hover-after-affected-by-change.html [modify] https://crrev.com/8ac19ac76519aaa0e4ffd228629d4488d5efea79/third_party/WebKit/Source/core/dom/Element.cpp
,
Sep 26 2017
,
Sep 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f0c480da9cb188c82e16e6c6751875a60a114cf commit 9f0c480da9cb188c82e16e6c6751875a60a114cf Author: Rune Lillesveen <rune@opera.com> Date: Wed Sep 27 02:59:59 2017 Reland "Store new ComputedStyle object if style did not change." This is a reland of https://chromium-review.googlesource.com/681755 The comparison of ComputedStyle does not take additional flags into account. For instance, the AffectedBy* flags used for updating pseudo classes like :hover. We used to call SetStyleInternal, but this was removed because the previous comment said it was because of style sharing which is now removed. The display:contents case (768406) never worked because the code path for StoreNonLayoutObjectComputedStyle() was always skipped when computed style compared to be equal. TBR=nainar@chromium.org,treib@chromium.org Bug: 768406 , 767832 , 768790 Change-Id: Iee509e43e5fcc29d04944655d3d966ea61cc2adf Reviewed-on: https://chromium-review.googlesource.com/684186 Commit-Queue: Rune Lillesveen <rune@opera.com> Reviewed-by: Rune Lillesveen <rune@opera.com> Cr-Commit-Position: refs/heads/master@{#504561} [add] https://crrev.com/9f0c480da9cb188c82e16e6c6751875a60a114cf/third_party/WebKit/LayoutTests/fast/dynamic/hover-after-affected-by-change.html [modify] https://crrev.com/9f0c480da9cb188c82e16e6c6751875a60a114cf/third_party/WebKit/Source/core/dom/Element.cpp
,
Sep 27 2017
,
Oct 30 2017
Issue 778230 has been merged into this issue. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by schenney@chromium.org
, Sep 22 2017