New issue
Advanced search Search tips

Issue 767822 link

Starred by 1 user
Status: Archived
Owner: ----
Closed: Sep 13
Cc:
est...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

ThemeService::OnThemeBuiltFromExtension() DCHECKs on disk full

Project Member Reported by ricea@chromium.org, Sep 22 2017 
WritePackToDiskCallback() in //chrome/browser/themes/theme_service.cc has the lines:

  if (!pack->WriteToDisk(path))
    NOTREACHED() << "Could not write theme pack to disk";

Since the function cannot guarantee that a disk full error will not occur, it is not appropriate to use NOTREACHED() here.

This caused a test failure on a try bot: https://luci-milo.appspot.com/buildbot/chromium.mac/Mac10.9%20Tests%20%28dbg%29/45304

Comment 1 by jhawkins@chromium.org, Sep 22 2017

Owner: ----
Status: Available (was: Assigned)
I don't work on Chrome anymore.

Comment 2 by ricea@chromium.org, Sep 25 2017

Status: Untriaged (was: Available)
Please triage.

Comment 3 by robliao@chromium.org, Sep 13

Status: Archived (was: Untriaged)
Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!

Comment 4 by robliao@chromium.org, Sep 13 

Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!

Comment 5 by robliao@chromium.org, Sep 13 

Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!
►

Sign in to add a comment