Non-Regression : Picture not captured on clicking 'Take photo' option in 'Create Supervised User' overlay |
||||||||
Issue descriptionChrome Version: 63.0.3218.0/9963.0.0 dev-channel Candy,Daisy & Paine OS: Chrome What steps will reproduce the problem? (1)In sign-out screen click on three dot Menu to 'Add supervised User' (2)Click on 'Create Supervised User' -> Now enter password in'Choose the manager for this supervised user' Overlay -> Navigates to 'Create Supervised User' overlay (3)Now at Profile pictures click on 'Take photo' option -> So that Camera screen is seen -> Now again click on 'Take photo' option and observe Picture is not captured (Please refer Video) Note : 1)On continuous clicking on 'Take photo' option picture is captured in 'Create Supervised User' overlay 2)Click on 'Take photo' option-> observe Picture is not captured If it is intended change then on continuous clicking 'Take photo' option Picture should not be captured[As Mentioned in Note (1)] 3)In chrome://settings/changePicture -> click on 'Take photo' option So that Camera screen is seen -> Now again click on 'Take photo' and observe Picture is captured (Please refer 'Expected_PicCapturedOnClickingTakephoto' video) Expected: On clicking 'Take photo' option Picture should be captured Actual: Instead Picture is not captured This is Non-Regression Issue seen from M-55 @reveman: Please confirm the issue
,
Oct 13 2017
+ mcirimele
,
Oct 13 2017
,
Oct 24 2017
Oh interesting find - I didn't know this was even possible. Thanks for filing! The button to enter "take photo" should not take a photo, the user will have to press the actual "capture" button under the preview to take the photo. I think this means that we need to move focus to the "capture" button so keyboard users can press "enter" to take a photo. Not sure who to assign to here, giving to reveman@ to point to the right person :)
,
Oct 24 2017
Thanks Maria. For now let's move the focus to the green capture button so that users can press "enter" to take a photo. hcarmona@ will you be able to fix this?
,
Nov 10 2017
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4e5fdd3f018ead78e22e62d6a5a1943e0014598 commit d4e5fdd3f018ead78e22e62d6a5a1943e0014598 Author: Hector Carmona <hcarmona@chromium.org> Date: Tue Nov 14 19:39:18 2017 Focus action button instead of triggering in profile picture chooser. This improves accessibility behavior by focusing the button that will perform the action when the selected item is pressed. Before, this would have deleted a user photo or taken a photo. The new behavior moves focus to a button that is properly labeled. Bug: 765104 , 767820 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8b813a9d53c0e5b47579274253c173fc4294404f Reviewed-on: https://chromium-review.googlesource.com/764594 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#516391} [modify] https://crrev.com/d4e5fdd3f018ead78e22e62d6a5a1943e0014598/chrome/browser/resources/chromeos/login/oobe_change_picture.js [modify] https://crrev.com/d4e5fdd3f018ead78e22e62d6a5a1943e0014598/chrome/browser/resources/settings/people_page/change_picture.js [modify] https://crrev.com/d4e5fdd3f018ead78e22e62d6a5a1943e0014598/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_camera.js [modify] https://crrev.com/d4e5fdd3f018ead78e22e62d6a5a1943e0014598/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_list.js [modify] https://crrev.com/d4e5fdd3f018ead78e22e62d6a5a1943e0014598/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_pane.js
,
Nov 16 2017
,
Nov 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5946dbf3fd9d3f924d6e42954ddd32adbe5e691d commit 5946dbf3fd9d3f924d6e42954ddd32adbe5e691d Author: Hector Carmona <hcarmona@chromium.org> Date: Mon Nov 27 18:40:06 2017 Focus action button instead of triggering in profile picture chooser. This improves accessibility behavior by focusing the button that will perform the action when the selected item is pressed. Before, this would have deleted a user photo or taken a photo. The new behavior moves focus to a button that is properly labeled. Bug: 765104 , 767820 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8b813a9d53c0e5b47579274253c173fc4294404f Reviewed-on: https://chromium-review.googlesource.com/764594 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#516391}(cherry picked from commit d4e5fdd3f018ead78e22e62d6a5a1943e0014598) Reviewed-on: https://chromium-review.googlesource.com/791211 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#572} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/5946dbf3fd9d3f924d6e42954ddd32adbe5e691d/chrome/browser/resources/chromeos/login/oobe_change_picture.js [modify] https://crrev.com/5946dbf3fd9d3f924d6e42954ddd32adbe5e691d/chrome/browser/resources/settings/people_page/change_picture.js [modify] https://crrev.com/5946dbf3fd9d3f924d6e42954ddd32adbe5e691d/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_camera.js [modify] https://crrev.com/5946dbf3fd9d3f924d6e42954ddd32adbe5e691d/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_list.js [modify] https://crrev.com/5946dbf3fd9d3f924d6e42954ddd32adbe5e691d/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_pane.js
,
Jan 5 2018
10032.79.0, 63.0.3239.132 |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by reve...@chromium.org
, Sep 22 2017Owner: elizabethchiu@chromium.org