New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 767805 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 726246



Sign in to add a comment

Message center height does not resize properly

Project Member Reported by tetsui@chromium.org, Sep 22 2017

Issue description

Chrome Version: ToT
OS: Chrome OS

What steps will reproduce the problem?
(1) Press Caps Lock.
(2) Caps Lock is ON notification is shown.
(3) Click the bell icon to expand message center in the right bottom of the self.
(4) Press notification settings button.
(5) Do some random steps.
(6) Press settings again.

What is the expected result?
Message center height should be always kept after returning from settings.

What happens instead?
Sometimes the height is kept, while sometimes it isn't.
 

Comment 1 by tetsui@chromium.org, Sep 23 2017

Summary: Message center height does not resize properly (was: Message center does not )

Comment 2 by tetsui@chromium.org, Sep 25 2017

Description: Show this description

Comment 3 by tetsui@chromium.org, Sep 25 2017

It seems always keeping the height is the expected behavior.

https://b.corp.google.com/issues/36517819
https://bugs.chromium.org/p/chromium/issues/detail?id=709337

Comment 4 by tetsui@chromium.org, Sep 26 2017

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8833b1eae41404f3634e01b3281e53b5903237ad

commit 8833b1eae41404f3634e01b3281e53b5903237ad
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Tue Sep 26 03:23:12 2017

Not shrink message center after returning from settings panel.

Message center is required to not resize after returning to settings
panel.
Previously, the height was sometimes shrinking, while sometimes not,
depending on event timing.

TEST=manual
BUG= 767805 

Change-Id: Ic1594f142f8dc9e4f88a69bfddd1f2598c2a0ab1
Reviewed-on: https://chromium-review.googlesource.com/681095
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504272}
[modify] https://crrev.com/8833b1eae41404f3634e01b3281e53b5903237ad/ash/message_center/message_center_view.cc

Comment 6 by tetsui@chromium.org, Sep 26 2017

Status: Fixed (was: Started)

Sign in to add a comment