Material design checkbox is tied to --secondary-ui-md switch |
||||
Issue descriptionIn view framework, checkbox does not support material design, while toggle button does. https://cs.chromium.org/chromium/src/ui/views/controls/button/checkbox.h
,
Sep 28 2017
,
Sep 28 2017
,
Oct 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7521c49da40bcf4a08dfeccee9f158b7173aba6 commit b7521c49da40bcf4a08dfeccee9f158b7173aba6 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Tue Oct 03 05:11:08 2017 Add Material Design option to ctor of views::Checkbox. Material Design checkbox is available behind runtime flag (--secondary-ui-md), but there was no way to access the feature separately without enabling all Material Design secondary UI elements. We need Material Design checkbox in Chrome OS notification settings. Mock: https://crbug.com/726246#c8 TEST=manual BUG= 767803 Change-Id: I89dfbd3708cae64bd68183167a2088b5ca826856 Reviewed-on: https://chromium-review.googlesource.com/690057 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#505950} [modify] https://crrev.com/b7521c49da40bcf4a08dfeccee9f158b7173aba6/ui/views/controls/button/checkbox.cc [modify] https://crrev.com/b7521c49da40bcf4a08dfeccee9f158b7173aba6/ui/views/controls/button/checkbox.h
,
Oct 3 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by tetsui@chromium.org
, Sep 28 2017