Issue 765402  has been merged into this issue.

 Issue 765252  has been merged into this issue.

 Issue 764925  has been merged into this issue.

Hey gambard@ are you working on this issue?

Waiting for MDC roll.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e96fc0bd1076af261a710514086f76255f28651

commit 9e96fc0bd1076af261a710514086f76255f28651
Author: Gauthier Ambard <gambard@chromium.org>
Date: Thu Oct 26 16:52:59 2017

Fix iPhone X collections issues

As MDC is rolled to 38.0, we can start taking advantage of the fix
included for the iPhone X by letting the collection have the default
adjustedContentBehavior.
This also changes the NTP to use an automatic
adjustedContentInsetBehavior, to prevent a bug with the overscroll
action.

Bug:  767802 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I2c68bb0e88f377c3b93af937b70605cd952b8c84
Reviewed-on: https://chromium-review.googlesource.com/737995
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511851}
[modify] https://crrev.com/9e96fc0bd1076af261a710514086f76255f28651/ios/chrome/browser/content_suggestions/content_suggestions_header_view_controller.mm
[modify] https://crrev.com/9e96fc0bd1076af261a710514086f76255f28651/ios/chrome/browser/ui/collection_view/collection_view_controller.mm
[modify] https://crrev.com/9e96fc0bd1076af261a710514086f76255f28651/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_controlling.h
[modify] https://crrev.com/9e96fc0bd1076af261a710514086f76255f28651/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer.mm
[modify] https://crrev.com/9e96fc0bd1076af261a710514086f76255f28651/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer_unittest.mm
[modify] https://crrev.com/9e96fc0bd1076af261a710514086f76255f28651/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
[modify] https://crrev.com/9e96fc0bd1076af261a710514086f76255f28651/ios/chrome/browser/ui/ntp/google_landing_view_controller.mm
[modify] https://crrev.com/9e96fc0bd1076af261a710514086f76255f28651/ios/chrome/browser/ui/ntp/new_tab_page_header_view.h
[modify] https://crrev.com/9e96fc0bd1076af261a710514086f76255f28651/ios/chrome/browser/ui/ntp/new_tab_page_header_view.mm
[modify] https://crrev.com/9e96fc0bd1076af261a710514086f76255f28651/ios/clean/chrome/browser/ui/ntp/ntp_home_header_view_controller.mm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9941ba961238abd4b28618c2f65b6b457359378

commit c9941ba961238abd4b28618c2f65b6b457359378
Author: Menglu Huang <huangml@chromium.org>
Date: Fri Oct 27 23:26:15 2017

Revert "Fix iPhone X collections issues"

This reverts commit 9e96fc0bd1076af261a710514086f76255f28651.

Reason for revert: <INSERT REASONING HERE>
This CL breaks some eg tests running on iPhone X.
https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.fyi%2FEarlGreyiOS%2F32771%2F%2B%2Frecipes%2Fsteps%2Fios_chrome_ui_egtests__iPhone_X_iOS_11.0_%2F0%2Flogs%2FNTPHomeTestCase__x2f_testOmniboxWidthRotation%2F0

Original change's description:
> Fix iPhone X collections issues
> 
> As MDC is rolled to 38.0, we can start taking advantage of the fix
> included for the iPhone X by letting the collection have the default
> adjustedContentBehavior.
> This also changes the NTP to use an automatic
> adjustedContentInsetBehavior, to prevent a bug with the overscroll
> action.
> 
> Bug:  767802 
> Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: I2c68bb0e88f377c3b93af937b70605cd952b8c84
> Reviewed-on: https://chromium-review.googlesource.com/737995
> Commit-Queue: Gauthier Ambard <gambard@chromium.org>
> Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#511851}

TBR=rohitrao@chromium.org,gambard@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  767802 
Change-Id: I98a8e73c0153a534393c89f79c05571a2a1aa58d
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/742349
Reviewed-by: Menglu Huang <huangml@chromium.org>
Commit-Queue: Menglu Huang <huangml@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512344}
[modify] https://crrev.com/c9941ba961238abd4b28618c2f65b6b457359378/ios/chrome/browser/content_suggestions/content_suggestions_header_view_controller.mm
[modify] https://crrev.com/c9941ba961238abd4b28618c2f65b6b457359378/ios/chrome/browser/ui/collection_view/collection_view_controller.mm
[modify] https://crrev.com/c9941ba961238abd4b28618c2f65b6b457359378/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_controlling.h
[modify] https://crrev.com/c9941ba961238abd4b28618c2f65b6b457359378/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer.mm
[modify] https://crrev.com/c9941ba961238abd4b28618c2f65b6b457359378/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer_unittest.mm
[modify] https://crrev.com/c9941ba961238abd4b28618c2f65b6b457359378/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
[modify] https://crrev.com/c9941ba961238abd4b28618c2f65b6b457359378/ios/chrome/browser/ui/ntp/google_landing_view_controller.mm
[modify] https://crrev.com/c9941ba961238abd4b28618c2f65b6b457359378/ios/chrome/browser/ui/ntp/new_tab_page_header_view.h
[modify] https://crrev.com/c9941ba961238abd4b28618c2f65b6b457359378/ios/chrome/browser/ui/ntp/new_tab_page_header_view.mm
[modify] https://crrev.com/c9941ba961238abd4b28618c2f65b6b457359378/ios/clean/chrome/browser/ui/ntp/ntp_home_header_view_controller.mm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26054fded2ff114df520b5ed2714c1673030b54d

commit 26054fded2ff114df520b5ed2714c1673030b54d
Author: Gauthier Ambard <gambard@chromium.org>
Date: Mon Oct 30 14:37:22 2017

Reland "Fix iPhone X collections issues"

As MDC is rolled to 38.0, we can start taking advantage of the fix
included for the iPhone X by letting the collection have the default
adjustedContentBehavior.
This also changes the NTP to use an automatic
adjustedContentInsetBehavior, to prevent a bug with the overscroll
action.

Bug:  767802 ,  779234 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I9d4b3c2cbe7feedcab03714c061a8ff9705d4d57
Reviewed-on: https://chromium-review.googlesource.com/743018
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512491}
[modify] https://crrev.com/26054fded2ff114df520b5ed2714c1673030b54d/ios/chrome/browser/content_suggestions/content_suggestions_header_view_controller.mm
[modify] https://crrev.com/26054fded2ff114df520b5ed2714c1673030b54d/ios/chrome/browser/ui/collection_view/collection_view_controller.mm
[modify] https://crrev.com/26054fded2ff114df520b5ed2714c1673030b54d/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_controlling.h
[modify] https://crrev.com/26054fded2ff114df520b5ed2714c1673030b54d/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer.mm
[modify] https://crrev.com/26054fded2ff114df520b5ed2714c1673030b54d/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer_unittest.mm
[modify] https://crrev.com/26054fded2ff114df520b5ed2714c1673030b54d/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
[modify] https://crrev.com/26054fded2ff114df520b5ed2714c1673030b54d/ios/chrome/browser/ui/content_suggestions/ntp_home_egtest.mm
[modify] https://crrev.com/26054fded2ff114df520b5ed2714c1673030b54d/ios/chrome/browser/ui/ntp/google_landing_view_controller.mm
[modify] https://crrev.com/26054fded2ff114df520b5ed2714c1673030b54d/ios/chrome/browser/ui/ntp/new_tab_page_header_view.h
[modify] https://crrev.com/26054fded2ff114df520b5ed2714c1673030b54d/ios/chrome/browser/ui/ntp/new_tab_page_header_view.mm
[modify] https://crrev.com/26054fded2ff114df520b5ed2714c1673030b54d/ios/clean/chrome/browser/ui/ntp/ntp_home_header_view_controller.mm

MDC has rolled. Consider this fixed.

Requesting MERGE for commit in comment 9

743018	Reland "Fix iPhone X collections issues"	2017-10-30 07:37	26054fded2ff114df520b5ed2714c1673030b54d

This bug requires manual review: Less than 29 days to go before AppStore submit on M63
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98265d437faee582fdf7ab227f5ff39eff7d4249

commit 98265d437faee582fdf7ab227f5ff39eff7d4249
Author: Gauthier Ambard <gambard@chromium.org>
Date: Mon Nov 06 23:44:08 2017

Reland "Fix iPhone X collections issues"

As MDC is rolled to 38.0, we can start taking advantage of the fix
included for the iPhone X by letting the collection have the default
adjustedContentBehavior.
This also changes the NTP to use an automatic
adjustedContentInsetBehavior, to prevent a bug with the overscroll
action.

Bug:  767802 ,  779234 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I9d4b3c2cbe7feedcab03714c061a8ff9705d4d57
Reviewed-on: https://chromium-review.googlesource.com/743018
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#512491}(cherry picked from commit 26054fded2ff114df520b5ed2714c1673030b54d)
Reviewed-on: https://chromium-review.googlesource.com/752461
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#402}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/98265d437faee582fdf7ab227f5ff39eff7d4249/ios/chrome/browser/content_suggestions/content_suggestions_header_view_controller.mm
[modify] https://crrev.com/98265d437faee582fdf7ab227f5ff39eff7d4249/ios/chrome/browser/ui/collection_view/collection_view_controller.mm
[modify] https://crrev.com/98265d437faee582fdf7ab227f5ff39eff7d4249/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_controlling.h
[modify] https://crrev.com/98265d437faee582fdf7ab227f5ff39eff7d4249/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer.mm
[modify] https://crrev.com/98265d437faee582fdf7ab227f5ff39eff7d4249/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer_unittest.mm
[modify] https://crrev.com/98265d437faee582fdf7ab227f5ff39eff7d4249/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
[modify] https://crrev.com/98265d437faee582fdf7ab227f5ff39eff7d4249/ios/chrome/browser/ui/content_suggestions/ntp_home_egtest.mm
[modify] https://crrev.com/98265d437faee582fdf7ab227f5ff39eff7d4249/ios/chrome/browser/ui/ntp/google_landing_view_controller.mm
[modify] https://crrev.com/98265d437faee582fdf7ab227f5ff39eff7d4249/ios/chrome/browser/ui/ntp/new_tab_page_header_view.h
[modify] https://crrev.com/98265d437faee582fdf7ab227f5ff39eff7d4249/ios/chrome/browser/ui/ntp/new_tab_page_header_view.mm
[modify] https://crrev.com/98265d437faee582fdf7ab227f5ff39eff7d4249/ios/clean/chrome/browser/ui/ntp/ntp_home_header_view_controller.mm

Verified on:

App Version: 63.0.3239.53

Tested on iPhone X simulator, Issue is fixed. Card layout for Reading list, History and Settings is displayed inside the safe area. Please see the screenshots attached.

Deleted: Settings.png 40.8 KB

	Settings.png 40.8 KB View Download

Deleted: Settings1.png 42.0 KB

	Settings1.png 42.0 KB View Download

Deleted: ReadingList.png 48.6 KB

	ReadingList.png 48.6 KB View Download

Deleted: ReadingList_EditMode.png 50.2 KB

	ReadingList_EditMode.png 50.2 KB View Download

Deleted: History.png 50.2 KB

	History.png 50.2 KB View Download