Service Worker shows it was received 01/01/1970, 01:00:00 when updating
Reported by
s1000...@gmail.com,
Sep 22 2017
|
||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.113 Safari/537.36 Steps to reproduce the problem: 1. Application 2. Service Workers 3. Update (on the right) What is the expected behavior? to show the correct date What went wrong? it showed the incorrect date Did this work before? N/A Chrome version: 60.0.3112.113 Channel: n/a OS Version: OS X 10.12.6 Flash Version: Original twitter thread with Jake Archibald aka @jaffathecake: https://twitter.com/s10wen/status/911129564071563264
,
Sep 26 2017
Tested on latest Chrome Stable #61.0.3163.100, Canary # 63.0.3223.8 on Windows 10, Mac 10.12.6 and Ubuntu 14.04 and able to reproduce the issue. This is a non-regression issue and able to reproduce from M-52 #52.0.2726.0. Marking it as untriaged so that issue gets addressed. Attached the screencast for reference. Thanks.
,
Sep 29 2017
I'll take a look.
,
Jun 12 2018
,
Aug 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/268fcfac4c28c0b5c3031c063bda6f0f96368c23 commit 268fcfac4c28c0b5c3031c063bda6f0f96368c23 Author: GauthamBanasandra <gautham.bangalore@gmail.com> Date: Fri Aug 24 23:30:43 2018 DevTools: Show scriptResponseTime for ServiceWorker only if present As per the browser protocol, the field scriptResponseTime is optional. Hence adding a check to see if it present before displaying it. Bug: 767790 Change-Id: I2638328aeec901419e48977ba40a15971da43f8b Reviewed-on: https://chromium-review.googlesource.com/1180623 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#586048} [modify] https://crrev.com/268fcfac4c28c0b5c3031c063bda6f0f96368c23/third_party/blink/renderer/devtools/front_end/resources/ServiceWorkersView.js
,
Aug 27
Able to to reproduce the issue on Mac 10.13.6,Windows 10 and Ubuntu 17.10 using chrome 63.0.3223.8 build without fix. Steps: ------ 1. Launched chrome 2. Opened Dev tools>> Application>> Service Workers As we are not seen date field on latest chrome 70.0.3534.0, attaching screen cast of latest chrome 70.0.3534.0 for reference. pnangunoori@chromium.org@ - Could you please review the attached screen cast and please let us know if anything missed from our end. Also help in verifying the fix. Thanks...!
,
Aug 27
As per comment #5 CC'ing gautham.bangalore@gmail.com. Could you please review the attached screen cast and please let us know if anything missed from our end. Also help in verifying the fix. Thanks..!
,
Aug 27
It seems to be working as expected. You might want to test it with multiple Service workers running.
,
Aug 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e27cfaca58d81d74a25460d2021592ce6174841 commit 7e27cfaca58d81d74a25460d2021592ce6174841 Author: John Abd-El-Malek <jam@chromium.org> Date: Mon Aug 27 18:39:55 2018 Revert "DevTools: Show scriptResponseTime for ServiceWorker only if present" This reverts commit 268fcfac4c28c0b5c3031c063bda6f0f96368c23. Broke http/tests/devtools/service-workers/service-workers-redundant.js http/tests/devtools/service-workers/service-workers-view.js with network service See https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mojo%20Linux/17958 You can reproduce this locally via --additional-driver-flag=--enable-features=NetworkService Original change's description: > DevTools: Show scriptResponseTime for ServiceWorker only if present > > As per the browser protocol, the field scriptResponseTime is > optional. Hence adding a check to see if it present before > displaying it. > > Bug: 767790 > Change-Id: I2638328aeec901419e48977ba40a15971da43f8b > Reviewed-on: https://chromium-review.googlesource.com/1180623 > Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#586048} TBR=dgozman@chromium.org,lushnikov@chromium.org,pfeldman@chromium.org,gautham.bangalore@gmail.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 767790 Change-Id: Idd1be72fe1bd5325263b8d46137edc07d70a4d22 Reviewed-on: https://chromium-review.googlesource.com/1191062 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#586331} [modify] https://crrev.com/7e27cfaca58d81d74a25460d2021592ce6174841/third_party/blink/renderer/devtools/front_end/resources/ServiceWorkersView.js
,
Oct 4
,
Dec 4
,
Dec 6
CL 1366370 effects: before: image #1 after: image #2
,
Dec 13
CL1376311 effects, same as above (CL1366370)
,
Dec 13
,
Dec 14
,
Dec 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f242cca527636841032b152a3718a7f261ee11b commit 0f242cca527636841032b152a3718a7f261ee11b Author: Harley Li <hhli@chromium.org> Date: Fri Dec 14 22:25:26 2018 [DevTools] Application > Service Workers, fix live script receiving time Before this patch, current site's service worker receive time is Unix epoch time. This patch fixes this problem. About the test for this CL: ServiceWorkerTestRunner.js is modified, so if the old problem (showing Unix epoch time) persists, then DevTools tests service-workers-view.js and service-workers-redundant.js would fail. Bug: 767790 Change-Id: I65aeadddcf03d381f8366e1157d85ac182202e15 Reviewed-on: https://chromium-review.googlesource.com/c/1376311 Commit-Queue: Haihong Li (Harley) <hhli@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#616849} [modify] https://crrev.com/0f242cca527636841032b152a3718a7f261ee11b/content/browser/service_worker/service_worker_new_script_loader.cc [modify] https://crrev.com/0f242cca527636841032b152a3718a7f261ee11b/third_party/blink/renderer/devtools/front_end/application_test_runner/ServiceWorkersTestRunner.js
,
Dec 25
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by jakearchibald@chromium.org
, Sep 22 2017Labels: -OS-Mac