New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 767790 link

Starred by 9 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Service Worker shows it was received 01/01/1970, 01:00:00 when updating

Reported by s1000...@gmail.com, Sep 22 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.113 Safari/537.36

Steps to reproduce the problem:
1. Application
2. Service Workers
3. Update (on the right)

What is the expected behavior?
to show the correct date

What went wrong?
it showed the incorrect date

Did this work before? N/A 

Chrome version: 60.0.3112.113  Channel: n/a
OS Version: OS X 10.12.6
Flash Version: 

Original twitter thread with Jake Archibald aka @jaffathecake: https://twitter.com/s10wen/status/911129564071563264
 
Screen Shot 2017-09-22 at 08.21.52.png
65.9 KB View Download
Components: Blink>ServiceWorker
Labels: -OS-Mac
Cc: pnangunoori@chromium.org
Labels: OS-Linux OS-Mac OS-Windows
Status: Untriaged (was: Unconfirmed)
Tested on latest Chrome Stable #61.0.3163.100,  Canary # 63.0.3223.8 on Windows 10, Mac 10.12.6 and Ubuntu 14.04 and able to reproduce the issue.

This is a non-regression issue and able to reproduce from M-52 #52.0.2726.0. Marking it as untriaged so that issue gets addressed.

Attached the screencast for reference.

Thanks.

767790.webm
3.8 MB View Download

Comment 3 by horo@chromium.org, Sep 29 2017

Labels: -Pri-2 Pri-3
Owner: horo@chromium.org
Status: Assigned (was: Untriaged)
I'll take a look.

Comment 4 by falken@chromium.org, Jun 12 2018

Cc: horo@chromium.org
Labels: Hotlist-GoodFirstBug
Owner: ----
Status: Available (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/268fcfac4c28c0b5c3031c063bda6f0f96368c23

commit 268fcfac4c28c0b5c3031c063bda6f0f96368c23
Author: GauthamBanasandra <gautham.bangalore@gmail.com>
Date: Fri Aug 24 23:30:43 2018

DevTools: Show scriptResponseTime for ServiceWorker only if present

As per the browser protocol, the field scriptResponseTime is
optional. Hence adding a check to see if it present before
displaying it.

Bug:  767790 
Change-Id: I2638328aeec901419e48977ba40a15971da43f8b
Reviewed-on: https://chromium-review.googlesource.com/1180623
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586048}
[modify] https://crrev.com/268fcfac4c28c0b5c3031c063bda6f0f96368c23/third_party/blink/renderer/devtools/front_end/resources/ServiceWorkersView.js

Labels: Needs-Feedback
Able to to reproduce the issue on Mac 10.13.6,Windows 10 and Ubuntu 17.10 using chrome 63.0.3223.8 build without fix.
Steps:
------
1. Launched chrome 
2. Opened Dev tools>> Application>> Service Workers 
As we are not seen date field on latest chrome 70.0.3534.0, attaching screen cast of latest chrome 70.0.3534.0 for reference.

pnangunoori@chromium.org@ - Could you please review the attached screen cast and please let us know if anything missed from our end. Also help in verifying the fix.

Thanks...!
767790.mp4
1.6 MB View Download
Cc: gautham....@gmail.com phanindra.mandapaka@chromium.org
As per comment #5 CC'ing gautham.bangalore@gmail.com. Could you please review the attached screen cast and please let us know if anything missed from our end. Also help in verifying the fix.

Thanks..!
It seems to be working as expected. You might want to test it with multiple Service workers running.
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e27cfaca58d81d74a25460d2021592ce6174841

commit 7e27cfaca58d81d74a25460d2021592ce6174841
Author: John Abd-El-Malek <jam@chromium.org>
Date: Mon Aug 27 18:39:55 2018

Revert "DevTools: Show scriptResponseTime for ServiceWorker only if present"

This reverts commit 268fcfac4c28c0b5c3031c063bda6f0f96368c23.

Broke 

http/tests/devtools/service-workers/service-workers-redundant.js
http/tests/devtools/service-workers/service-workers-view.js

with network service
See 
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mojo%20Linux/17958

You can reproduce this locally via
--additional-driver-flag=--enable-features=NetworkService

Original change's description:
> DevTools: Show scriptResponseTime for ServiceWorker only if present
> 
> As per the browser protocol, the field scriptResponseTime is
> optional. Hence adding a check to see if it present before
> displaying it.
> 
> Bug:  767790 
> Change-Id: I2638328aeec901419e48977ba40a15971da43f8b
> Reviewed-on: https://chromium-review.googlesource.com/1180623
> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#586048}

TBR=dgozman@chromium.org,lushnikov@chromium.org,pfeldman@chromium.org,gautham.bangalore@gmail.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  767790 
Change-Id: Idd1be72fe1bd5325263b8d46137edc07d70a4d22
Reviewed-on: https://chromium-review.googlesource.com/1191062
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586331}
[modify] https://crrev.com/7e27cfaca58d81d74a25460d2021592ce6174841/third_party/blink/renderer/devtools/front_end/resources/ServiceWorkersView.js

Cc: krajshree@chromium.org
 Issue 891502  has been merged into this issue.
Owner: hhli@chromium.org
Status: Assigned (was: Available)
CL 1366370 effects:

before: image #1
after: image #2

Screen Shot 2018-12-06 at 14.50.37.png
23.5 KB View Download
Screen Shot 2018-12-06 at 14.50.50.png
19.4 KB View Download
CL1376311 effects, same as above (CL1366370)
Cc: hhli@chromium.org
 Issue 857023  has been merged into this issue.
Status: Fixed (was: Assigned)
Project Member

Comment 16 by bugdroid1@chromium.org, Dec 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f242cca527636841032b152a3718a7f261ee11b

commit 0f242cca527636841032b152a3718a7f261ee11b
Author: Harley Li <hhli@chromium.org>
Date: Fri Dec 14 22:25:26 2018

[DevTools] Application > Service Workers, fix live script receiving time

Before this patch, current site's service worker receive time is Unix
epoch time. This patch fixes this problem.

About the test for this CL:
ServiceWorkerTestRunner.js is modified, so if the old problem (showing Unix epoch time)
persists, then DevTools tests service-workers-view.js and service-workers-redundant.js
would fail.

Bug:  767790 
Change-Id: I65aeadddcf03d381f8366e1157d85ac182202e15
Reviewed-on: https://chromium-review.googlesource.com/c/1376311
Commit-Queue: Haihong Li (Harley) <hhli@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616849}
[modify] https://crrev.com/0f242cca527636841032b152a3718a7f261ee11b/content/browser/service_worker/service_worker_new_script_loader.cc
[modify] https://crrev.com/0f242cca527636841032b152a3718a7f261ee11b/third_party/blink/renderer/devtools/front_end/application_test_runner/ServiceWorkersTestRunner.js

Cc: susan.boorgula@chromium.org
 Issue 916970  has been merged into this issue.

Sign in to add a comment