Issue metadata
Sign in to add a comment
|
Regression : In 'Edit bookmark' dialog, selected folder's name appears in black font color instead of white.
Reported by
avsha...@etouch.net,
Sep 22 2017
|
||||||||||||||||||||||
Issue descriptionChrome version : 63.0.3222.0 (Official Build) 7754c77f5af465147885e57c6ba7fc4e9095d842-refs/heads/master@{#503582} 32/64 bit OS : Windows (7,8,10) What steps will reproduce the problem? 1. Launch chrome, open NTP and click on 'Bookmark this page' icon. 2. Click on 'Edit' button in bubble and select any 'Folder' in 'Edit bookmark' dialog. 3. Observe the font color of currently selected folder. Actual Result : Selected folder's name appears in black font color. (black font does not look good with blue background color) Expected Result : Instead, a currently selected folder's name should have white font color. This is a regression issue broken in ‘M-63’, below is the manual bisect range and will soon update other info. Good build : 63.0.3220.0 Bad build : 63.0.3221.0
,
Sep 22 2017
Adding RB Label as this is a recent Regression. Please remove if not required. Thank You.
,
Sep 26 2017
Cc'ing sky@ as well for inputs on this.
,
Oct 3 2017
Still seeing the same issue on latest Canary-63.0.3230.0. ellyjones / sky, please take a look as it is marked as stable blocker. Thanks.!
,
Oct 3 2017
Looking at this today.
,
Oct 5 2017
Ah, I figured this one out I think.
The old code was:
ui::NativeTheme::ColorId text_color_id(bool has_focus, bool is_selected) {
if (is_selected) {
if (has_focus)
return ui::NativeTheme::kColorId_TreeSelectedText;
return ui::NativeTheme::kColorId_TreeSelectedTextUnfocused;
}
return ui::NativeTheme::kColorId_TreeText;
}
the new code is:
SkColor TreeViewDrawingProvider::GetTextColorForNode(TreeView* tree_view,
ui::TreeModelNode* node) {
ui::NativeTheme::ColorId color_id = ui::NativeTheme::kColorId_TreeText;
if (tree_view->GetSelectedNode() == node) {
if (tree_view->HasFocus())
color_id = ui::NativeTheme::kColorId_TreeSelectedText;
color_id = ui::NativeTheme::kColorId_TreeSelectedTextUnfocused; // <---- bug
}
return tree_view->GetNativeTheme()->GetSystemColor(color_id);
}
which erroneously always sets the color to TreeSelectedTextUnfocused even when tree_view->HasFocus(), which doesn't do the right thing on Windows. Those colors are the same on Linux and Mac, which is why I didn't notice this earlier. Fix will be up shortly.
,
Oct 5 2017
,
Oct 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9a8273052346c3c3c8c8312bdde31ba8236470ef commit 9a8273052346c3c3c8c8312bdde31ba8236470ef Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Fri Oct 06 14:40:53 2017 views: use the right color for unfocused treeview selection The existing code incorrectly always uses TreeSelectedTextUnfocused, even when the TreeView is focused. Oops. Bug: 767778 Change-Id: I79cbb8628a607a10901cd744ab71e37ead85aa62 Reviewed-on: https://chromium-review.googlesource.com/703095 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#507063} [modify] https://crrev.com/9a8273052346c3c3c8c8312bdde31ba8236470ef/ui/views/controls/tree/tree_view_drawing_provider.cc
,
Oct 6 2017
This should be fixed now, but I don't have a Windows machine to test it on, so please verify :)
,
Oct 9 2017
Update : Retested above issue in latest chrome canary #63.0.3236.0 build on Windows(7,8,10) OS and issue is fixed. Now in 'Edit bookmark' dialog, selected folder's name is seen with white font color. Kindly review an attached screen cast. Thank you! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by avsha...@etouch.net
, Sep 22 2017Owner: ellyjo...@chromium.org
Status: Assigned (was: Unconfirmed)
Summary: Regression : In 'Edit bookmark' dialog, selected folder's name appears in black font color instead of white. (was: Regression : In 'Edit bookmark' dialog, selected folder's name appears in black font color.)