New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 767770 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

pobfuzz: SkPath::readFromMemory assert

Project Member Reported by ClusterFuzz, Sep 22 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5614335656460288

Fuzzer: libFuzzer_paint_op_buffer_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Abrt
Crash Address: 0x03e9000009fa
Crash State:
  sk_abort_no_print
  SkPath::readFromMemory
  cc::PaintOpReader::Read
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=496919:496954

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5614335656460288

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Cc: msrchandra@chromium.org pnangunoori@chromium.org
Components: Internals>Compositing Internals>Skia
Labels: M-63 Test-Predator-Correct
Owner: enne@chromium.org
Status: Assigned (was: Untriaged)
Test Predator has given the following results:

Revert "cc: Add PaintCanvas::clipDeviceRect" by enne@chromium.org

Top touched frame is #5 cc::DrawPathOp::Deserialize(in paint_op_buffer.cc)
Changed files paint_canvas.h, paint_op_buffer.cc, paint_op_buffer.h, paint_op_buffer_unittest.cc, record_paint_canvas.cc, record_paint_canvas.h, skia_paint_canvas.cc, skia_paint_canvas.h, solid_color_analyzer.cc, solid_color_analyzer_unittest.cc, with the same CrashedDirectory(cc/paint) as paint_op_buffer.cc (in frame#5, frame#6), paint_op_reader.cc (in frame#4)
Touched files in stacktrace - paint_op_buffer.cc
Changed files paint_canvas.h, paint_op_buffer.cc, paint_op_buffer.h, paint_op_buffer_unittest.cc, record_paint_canvas.cc, record_paint_canvas.h, skia_paint_canvas.cc, skia_paint_canvas.h, solid_color_analyzer.cc, solid_color_analyzer_unittest.cc, with the same CrashedComponent(Internals>Compositing) as paint_op_buffer.cc (in frame#5, frame#6), paint_op_reader.cc (in frame#4)

@enne -- Could you please look into this issue, kindly reassign if it has nothing to do with your changes.

Thank You.

Comment 2 by enne@chromium.org, Sep 22 2017

Labels: -Pri-1 -M-63 Pri-2
Summary: pobfuzz: SkPath::readFromMemory assert (was: Abrt in sk_abort_no_print)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 25 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/ffbdd022dc6ec372500671b508a3d7ab025727d9

commit ffbdd022dc6ec372500671b508a3d7ab025727d9
Author: Adrienne Walker <enne@chromium.org>
Date: Mon Sep 25 19:24:49 2017

Make SkPath::readFromMemory failure silent

It currently asserts, but should instead silently fail.  Otherwise,
without asserts turned on, this would leave the SkPath in an
inconsistent state.

Bug: chromium: 767770
Change-Id: Ib2af4caccfe19a4a008abccfe7b25b80ccf23146
Reviewed-on: https://skia-review.googlesource.com/50160
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>

[modify] https://crrev.com/ffbdd022dc6ec372500671b508a3d7ab025727d9/src/core/SkPath.cpp

Project Member

Comment 4 by ClusterFuzz, Sep 26 2017

ClusterFuzz has detected this issue as fixed in range 504110:504235.

Detailed report: https://clusterfuzz.com/testcase?key=5614335656460288

Fuzzer: libFuzzer_paint_op_buffer_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Abrt
Crash Address: 0x03e9000073ca
Crash State:
  sk_abort_no_print
  SkPath::readFromMemory
  cc::PaintOpReader::Read
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=496919:496954
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=504110:504235

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5614335656460288

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, Sep 26 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5614335656460288 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment