SingleLogFileLogSource: Do not truncate log files based on timestamps |
|||||
Issue descriptionTo avoid reading too much from e.g. /var/log/messages, SingleLogFileLogSource will only read the last 10 minutes. However, this could result in a loss of information if there was a long delay. Update this feature to also read the last X bytes or lines in addition to last 10 minutes, whichever is longer.
,
Oct 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/84be820124669a3f0037d06058ea8eb818e60bf6 commit 84be820124669a3f0037d06058ea8eb818e60bf6 Author: Simon Que <sque@chromium.org> Date: Wed Oct 04 18:40:50 2017 SingleLogFileLogSource: Do not truncate based on timestamps This feature is too specific. It should not be hard-coded into the log source system. Instead, it should be implemented by the caller of the API that uses these log sources. BUG= 767742 Change-Id: I43da7adfb36c3ab899099fc174ce07a327673c00 Reviewed-on: https://chromium-review.googlesource.com/687810 Commit-Queue: Simon Que <sque@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#506458} [modify] https://crrev.com/84be820124669a3f0037d06058ea8eb818e60bf6/chrome/browser/chromeos/system_logs/single_log_file_log_source.cc [modify] https://crrev.com/84be820124669a3f0037d06058ea8eb818e60bf6/chrome/browser/chromeos/system_logs/single_log_file_log_source_unittest.cc
,
Oct 9 2017
,
Oct 9 2017
This bug requires manual review: We are only 7 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 10 2017
Approved for 62.
,
Oct 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5699a15e5e272bda216e969deed4d52b5942d0d7 commit 5699a15e5e272bda216e969deed4d52b5942d0d7 Author: Simon Que <sque@chromium.org> Date: Tue Oct 10 18:17:48 2017 SingleLogFileLogSource: Do not truncate based on timestamps This feature is too specific. It should not be hard-coded into the log source system. Instead, it should be implemented by the caller of the API that uses these log sources. BUG= 767742 TBR=sque@chromium.org (cherry picked from commit 84be820124669a3f0037d06058ea8eb818e60bf6) Change-Id: I43da7adfb36c3ab899099fc174ce07a327673c00 Reviewed-on: https://chromium-review.googlesource.com/687810 Commit-Queue: Simon Que <sque@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#506458} Reviewed-on: https://chromium-review.googlesource.com/709655 Reviewed-by: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#637} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/5699a15e5e272bda216e969deed4d52b5942d0d7/chrome/browser/chromeos/system_logs/single_log_file_log_source.cc [modify] https://crrev.com/5699a15e5e272bda216e969deed4d52b5942d0d7/chrome/browser/chromeos/system_logs/single_log_file_log_source_unittest.cc |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by sque@chromium.org
, Sep 27 2017