Chromeos recipe losing properties |
||||||
Issue descriptionThis swarming build: https://ci.chromium.org/swarming/task/38bfc7d140661e10?server=chrome-swarming.appspot.com Generates this command line for cbuildbot_launch: /b/swarming/w/ir/kitchen-workdir/chromite/scripts/cbuildbot_launch --buildroot /b/swarming/w/ir/cache/cbuild --buildbot --branch master --buildbucket-id 8967796619336164336 --git-cache-dir /b/swarming/w/ir/cache/git --goma_dir /b/swarming/w/ir/cache/goma_client --goma_client_json /creds/service_accounts/service-account-goma-client.json samus-paladin I was expecting something much closer to: /b/rr/tmpJwWfmx/w/chromite/scripts/cbuildbot_launch --buildroot /b/c/cbuild --branch master --buildbucket-id 8967793714574148336 --git-cache-dir /b/c/git --goma_dir /b/c/goma_client --goma_client_json /creds/service_accounts/service-account-goma-client.json --remote-trybot -g 676188 --hwtest samus-paladin Generally speaking, the relevant code is here: https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromite/api.py?rcl=5aecbf937093267ddfe43e0cca3a3e4689d13c35&l=242 With the main recipe being here: https://cs.chromium.org/search/?q=cros/cbuildbot.py&sq=package:chromium&type=cs Or here: https://cs.chromium.org/chromium/build/scripts/slave/recipes/cros/cbuildbot_tryjob.py?dr The main difference appears to be that this variable is unpopulated/empty. self.c.cbb.extra_args However, I don't really understand recipes well enough to see how it's supposed to be populated, or what's different.
,
Sep 22 2017
,
Sep 22 2017
I intend to try to work through this, but would appreciate any help.
,
Sep 22 2017
The build bucket request for the swarming build: https://apis-explorer.appspot.com/apis-explorer/?base=https://cr-buildbucket.appspot.com/_ah/api#p/buildbucket/v1/buildbucket.get?id=8967796619336164336&_h=1& Looks very like the request for the buildbot build: https://apis-explorer.appspot.com/apis-explorer/?base=https://cr-buildbucket.appspot.com/_ah/api#p/buildbucket/v1/buildbucket.get?id=8967793714574148336&_h=1&
,
Sep 22 2017
Ah.... swarming ran the recipe:
cros/cbuildbot
@@@STEP_LOG_LINE@run_recipe@{"$recipe_engine/path": {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"}, "cbb_extra_args": ["--remote-trybot", "-g", "676188", "--hwtest"], "name": "[None] 676188", "buildername": "Generic", "recipe": "cros/cbuildbot", "bot": ["samus-paladin"], "mastername": "chromiumos.chromium", "cbb_config": "samus-paladin", "swarming_run_id": "38bfc7d140661e11", "extra_args": ["--remote-trybot", "-g", "676188", "--hwtest"], "buildbucket": {"hostname": "cr-buildbucket.appspot.com", "build": {"created_ts": 1506039711592680, "bucket": "luci.chromeos.general", "id": "8967796619336164336", "created_by": "user:dgarrett@google.com", "tags": ["build_type:tryjob"]}}, "owners": ["dgarrett@google.com"], "user": "dgarrett", "path_config": "generic", "$recipe_engine/step": {"prefix_path": ["/b/swarming/w/ir/cipd_bin_packages", "/b/swarming/w/ir/cipd_bin_packages/bin"]}, "email": ["dgarrett@google.com"], "bot_id": "swarm-cros-1"}@@@
Buildbot ran the recpie:
cros/cbuildbot_tryjob
@@@STEP_LOG_LINE@run_recipe@{"bot": ["samus-paladin"], "recipe": "cros/cbuildbot_tryjob", "builder_id": "master.chromiumos.tryserver:paladin", "$recipe_engine/path": {"cleanup_dir": "/b/build/slave/paladin/build.dead"}, "buildnumber": 3798, "cbb_config": "samus-paladin", "slavename": "build44-m2", "blamelist": [], "branch": "", "use_gitiles": false, "email": ["dgarrett@google.com"], "revision": "", "workdir": "/b/build/slave/paladin", "repository": "", "buildername": "paladin", "mastername": "chromiumos.tryserver", "buildbucket": "{\"build\": {\"bucket\": \"master.chromiumos.tryserver\", \"created_by\": \"user:dgarrett@google.com\", \"created_ts\": \"1506042481789930\", \"id\": \"8967793714574148336\", \"lease_key\": \"145923334\", \"tags\": [\"build_type:tryjob\", \"builder:paladin\"]}}", "user": "dgarrett", "requester": "dgarrett@google.com", "buildbotURL": "https://uberchromegw.corp.google.com/i/chromiumos.tryserver/", "cbb_extra_args": "z:eJyLVtLVLUrNzS9J1S0pqkzKL1HSUVDSTQeRZuZmhhYWYL5uRnlJanGJUiwAR8kNNQ==", "build_data_dir": "/b/rr/tmpS2zDVi", "owners": ["dgarrett@google.com"], "name": "[None] 676188", "recipe_repository": "https://chromium.googlesource.com/chromium/tools/build.git", "project": "", "requestedAt": 1506042487, "path_config": "kitchen", "extra_args": ["--remote-trybot", "-g", "676188", "--hwtest"], "bot_id": "build44-m2"}@@@
I think the difference is related to the recipe used, not the invocation path.
,
Sep 26 2017
,
Sep 26 2017
FWIW, the CLs I tested with swarming were "draft" CLs. It turned out they didn't even work with non-swarming mode.
,
Nov 14 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/manifest-internal/+/9dd53d63c2d35689dc6d81231f7af234ee48ce4c commit 9dd53d63c2d35689dc6d81231f7af234ee48ce4c Author: Don Garrett <dgarrett@google.com> Date: Tue Nov 14 01:46:24 2017
,
Dec 13 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by dgarr...@chromium.org
, Sep 22 2017