New issue
Advanced search Search tips

Issue 767689 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Google Toolbox for Mac License points to a non-existent file

Reported by agi.nova...@gmail.com, Sep 22 2017

Issue description

Steps to reproduce the problem:
1. Navigate to Settings -> About Chrome -> Legal Information -> Open source License -> Google Toolbox for Mac
2. Click "Show License"
3. 

What is the expected behavior?
It should show the Apache license conditions

What went wrong?
The license just says "See src/COPYING" but that file does not exist

Did this work before? N/A 

Chrome version: 60.0.3112.116  Channel: stable
OS Version: 
Flash Version: Shockwave Flash 27.0 r0
 
Labels: Needs-triage-Mobile
Labels: -OS-Android -Needs-triage-Mobile OS-Mac
Issue looks to be Mac specific, changing the OS label to Mac.

Thanks!!
Labels: -Via-Wizard-Other Needs-Feedback
I can't even find this page on macOS... Can you provide more detailed directions for how to get to this page?

Comment 4 by rsesek@chromium.org, Oct 17 2017

Components: UI>Browser>Credits
It's in chrome://credits

Comment 5 by shrike@chromium.org, Oct 20 2017

Labels: M-64
Owner: lgrey@chromium.org
Status: Assigned (was: Unconfirmed)
[macbugtriage] Broken at lease since M51 (51.0.2704.84). Seems like it should be easy to fix, as third_party/google_toolbox_for_mac/src/LICENSE exists. lgrey@, PTAL.
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2c3a03a8c96c48772e6d0a92fab42e6fea69ac4

commit c2c3a03a8c96c48772e6d0a92fab42e6fea69ac4
Author: Leonard Grey <lgrey@chromium.org>
Date: Mon Oct 23 18:17:09 2017

Show correct license for GTM in chrome://credits

Copied Apache license over from src/

Bug:  767689 
Change-Id: Ia3ae4960e5a903b2ec1ab70a2c5792c6fb3e3f4a
Reviewed-on: https://chromium-review.googlesource.com/733501
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510852}
[modify] https://crrev.com/c2c3a03a8c96c48772e6d0a92fab42e6fea69ac4/third_party/google_toolbox_for_mac/LICENSE

Comment 7 by lgrey@chromium.org, Oct 24 2017

Status: Fixed (was: Assigned)

Sign in to add a comment