New issue
Advanced search Search tips

Issue 767664 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

button style

Project Member Reported by lgcheng@google.com, Sep 21 2017

Issue description

arc optin: Change button style to oobe style.
oobe arc optin: Fix agree button end margin to 18px.
oobe button: Change the radius of light blue outside border to 4px according to UI review..

 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d3e66529d732d7d960bc28168bfc1c611144431

commit 1d3e66529d732d7d960bc28168bfc1c611144431
Author: lgcheng <lgcheng@google.com>
Date: Fri Sep 22 03:45:53 2017

arc: opt-in UI and oobe button fix.

arc optin: Change to oobe style.
oobe arc optin: Fix agree button end margin to 18px.
oobe button: Change the radius of light blue outside border to 4px
according to UI feedback.

Bug:  767664 
Test: Manual
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I59c03f5c29bda7e6fa0f8d0366068d1c0ee277e3
Reviewed-on: https://chromium-review.googlesource.com/677637
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Long Cheng <lgcheng@google.com>
Cr-Commit-Position: refs/heads/master@{#503638}
[modify] https://crrev.com/1d3e66529d732d7d960bc28168bfc1c611144431/chrome/browser/resources/chromeos/arc_support/main.css
[modify] https://crrev.com/1d3e66529d732d7d960bc28168bfc1c611144431/chrome/browser/resources/chromeos/arc_support/main.html
[modify] https://crrev.com/1d3e66529d732d7d960bc28168bfc1c611144431/chrome/browser/resources/chromeos/login/arc_terms_of_service.css
[modify] https://crrev.com/1d3e66529d732d7d960bc28168bfc1c611144431/chrome/browser/resources/chromeos/login/oobe_text_button.css

Comment 2 by lgcheng@google.com, Sep 22 2017

Labels: Merge-Request-61 Merge-Request-62

Comment 3 by lgcheng@google.com, Sep 22 2017

Cc: bhthompson@google.com
Hi Bernie, 

Confirmed with Hiro, we do want this UI change In M61, Can you take a look?
Labels: -Merge-Request-61 -Merge-Request-62 Merge-Approved-62 Merge-Approved-61
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 22 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb7005c3206ba4a85857209bd119e4d8a5b3c04e

commit eb7005c3206ba4a85857209bd119e4d8a5b3c04e
Author: lgcheng <lgcheng@google.com>
Date: Fri Sep 22 18:09:10 2017

arc: opt-in UI and oobe button fix.

arc optin: Change to oobe style.
oobe arc optin: Fix agree button end margin to 18px.
oobe button: Change the radius of light blue outside border to 4px
according to UI feedback.

TBR=xiyuan@chromium.org

Bug:  767664 
Test: Manual
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I59c03f5c29bda7e6fa0f8d0366068d1c0ee277e3
Reviewed-on: https://chromium-review.googlesource.com/677637
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Long Cheng <lgcheng@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#503638}(cherry picked from commit 1d3e66529d732d7d960bc28168bfc1c611144431)
Reviewed-on: https://chromium-review.googlesource.com/678561
Reviewed-by: Long Cheng <lgcheng@google.com>
Cr-Commit-Position: refs/branch-heads/3202@{#399}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/eb7005c3206ba4a85857209bd119e4d8a5b3c04e/chrome/browser/resources/chromeos/arc_support/main.css
[modify] https://crrev.com/eb7005c3206ba4a85857209bd119e4d8a5b3c04e/chrome/browser/resources/chromeos/arc_support/main.html
[modify] https://crrev.com/eb7005c3206ba4a85857209bd119e4d8a5b3c04e/chrome/browser/resources/chromeos/login/arc_terms_of_service.css
[modify] https://crrev.com/eb7005c3206ba4a85857209bd119e4d8a5b3c04e/chrome/browser/resources/chromeos/login/oobe_text_button.css

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 22 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e9d06ac13cef524c4e9c7e8d9ccbafb7111c911

commit 5e9d06ac13cef524c4e9c7e8d9ccbafb7111c911
Author: lgcheng <lgcheng@google.com>
Date: Fri Sep 22 21:16:49 2017

arc: opt-in UI and oobe button fix.

arc optin: Change to oobe style.
oobe arc optin: Fix agree button end margin to 18px.
oobe button: Change the radius of light blue outside border to 4px
according to UI feedback.

TBR=xiyuan@chromium.org

(cherry picked from commit 1d3e66529d732d7d960bc28168bfc1c611144431)

Bug:  767664 
Test: Manual
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I59c03f5c29bda7e6fa0f8d0366068d1c0ee277e3
Reviewed-on: https://chromium-review.googlesource.com/677637
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Long Cheng <lgcheng@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#503638}
Reviewed-on: https://chromium-review.googlesource.com/679265
Reviewed-by: Long Cheng <lgcheng@google.com>
Cr-Commit-Position: refs/branch-heads/3163@{#1265}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/5e9d06ac13cef524c4e9c7e8d9ccbafb7111c911/chrome/browser/resources/chromeos/arc_support/main.css
[modify] https://crrev.com/5e9d06ac13cef524c4e9c7e8d9ccbafb7111c911/chrome/browser/resources/chromeos/arc_support/main.html
[modify] https://crrev.com/5e9d06ac13cef524c4e9c7e8d9ccbafb7111c911/chrome/browser/resources/chromeos/login/arc_terms_of_service.css
[modify] https://crrev.com/5e9d06ac13cef524c4e9c7e8d9ccbafb7111c911/chrome/browser/resources/chromeos/login/oobe_text_button.css

Comment 7 by lgcheng@google.com, Sep 22 2017

Status: Fixed (was: Started)

Sign in to add a comment