Mind if I grab it? I'm in midst of breaking the CLs for review, will upload them to gerrit soon.

Agreed on 767646, but 767646 can be done as a cleanup after landing this, so doesn't necessarily be a blocker of this issue.

I think the reason I had it as a blocker is that we use some of the glib process stuff to register a callback on child process death, so we'd have to rewrite the underlying process implementation to use some other mechanism (i.e. signalfd + SIGCHLD + chrome message loop/FD watcher). That might as well just go into the brillo process abstraction at that point.

Re #5: brillo already provides a ProcessReaper for tracking child process deatch. shill has a more functional ProcessManager based on ProcessReaper, for both launching and watching processes.

OK, are we using the ProcessReaper in the post-glib cros-disks implementation?

Is it worth extracting ProcessManager into libbrillo or is it too shill-specific?

Re: #7

> OK, are we using the ProcessReaper in the post-glib cros-disks implementation?   Yes

> Is it worth extracting ProcessManager into libbrillo or is it too shill-specific?  Maybe, with some changes to the implementation.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/81d18b33f9949d7abdd609da85efec69a1458c6b

commit 81d18b33f9949d7abdd609da85efec69a1458c6b
Author: Ben Chan <benchan@chromium.org>
Date: Sat Oct 14 00:22:06 2017

cros-disks: remove D-Bus introspection support

After cros-disks is migrated to use the Chrome D-Bus binding instead of
dbus-c++, it will not implement the org.freedesktop.DBus.Introspectable
interface. To ensure any cros-disks D-Bus client depending on the
introspection support is migrated properly, this CL removes the
introspection support from cros-disks.

BUG= chromium:767645 
CQ-DEPEND=CL:718077
TEST=Run platform_CrosDisks{DBus,Filesystem,Format,Rename} tests with CL:718077

Change-Id: Id1b38b5a7e7c94e41d5a90112205239dacc0a8a3
Reviewed-on: https://chromium-review.googlesource.com/718116
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/81d18b33f9949d7abdd609da85efec69a1458c6b/cros-disks/cros_disks_server.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/577e66b6485a7ba2aa3d6b9f5eaf0c891bd7cbfa

commit 577e66b6485a7ba2aa3d6b9f5eaf0c891bd7cbfa
Author: Ben Chan <benchan@chromium.org>
Date: Sat Oct 14 00:22:06 2017

cros_disks: specify D-Bus data types for cases requiring introspection

After cros-disks is migrated to use the Chrome D-Bus binding instead of
dbus-c++, it will not implement the org.freedesktop.DBus.Introspectable
interface. Without the introspection support, the CrosDisksClient Python
helper cannot deduce the D-Bus data type for arguments passed to
cros-disks. This CL updates the CrosDisksClient Python helper to
explicitly specify the D-Bus data types when necessary.

BUG= chromium:767645 
TEST=Run platform_CrosDisks{DBus,Filesystem,Format,Rename} tests.

Change-Id: I8649d56437c60dc16b39e1eda7edc373f1a5e60d
Reviewed-on: https://chromium-review.googlesource.com/718077
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/577e66b6485a7ba2aa3d6b9f5eaf0c891bd7cbfa/client/cros/cros_disks.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/b8f17731383e7104f2d0ad6f7c84758c4a525725

commit b8f17731383e7104f2d0ad6f7c84758c4a525725
Author: Ben Chan <benchan@chromium.org>
Date: Sat Oct 14 02:42:59 2017

cros-disks: use brillo::kLogToStderrIfTty flag for logging

Instead of setting the brillo::kLogToStderr flag based on whether
cros-disks is runninng with the --foreground option specified, this CL
modifies cros-disks to simply use the brillo::kLogToStderrIfTty flag
unconditionally.

BUG= chromium:767645 
TEST=Verify that cros-disks logs to both syslog and stderr when running
     with a tty, and logs to only syslog otherwise.

Change-Id: Ie5efcc56ab814698832f1a23f3869c93e1379cb6
Reviewed-on: https://chromium-review.googlesource.com/719968
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/b8f17731383e7104f2d0ad6f7c84758c4a525725/cros-disks/main.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/68de38d9afb279c36e0fc14020f4b54fe24a116b

commit 68de38d9afb279c36e0fc14020f4b54fe24a116b
Author: Ben Chan <benchan@chromium.org>
Date: Sat Oct 14 02:42:59 2017

cros-disks: use brillo::FlagHelper for handling command line options

This CL simplifies the handling of command line options in cros-disks by
switching from base::CommandLine to brillo::FlagHelper. The only
incompatible change is that the --log-level option is renamed to
--log_level as brillo::FlagHelper doesn't support the '-'char in command
line option names.

BUG= chromium:767645 
TEST=Verify that various cros-disks command line options work as intended.

Change-Id: I97d485a527805fd711083f30d21b169d63fbe3c8
Reviewed-on: https://chromium-review.googlesource.com/719969
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/68de38d9afb279c36e0fc14020f4b54fe24a116b/cros-disks/main.cc
[modify] https://crrev.com/68de38d9afb279c36e0fc14020f4b54fe24a116b/cros-disks/cros-disks.conf

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/4213f970e1f3cdcfc1552c313bb44358dd61f22a

commit 4213f970e1f3cdcfc1552c313bb44358dd61f22a
Author: Ben Chan <benchan@chromium.org>
Date: Thu Oct 19 06:14:17 2017

cros-disks: remove uses of cros-disks IsAlive D-Bus method

cros-disks's IsAlive D-Bus method will be removed (CL:727120) as it
doesn't provide much value. This CL removes uses of that method in
autotest code.

BUG= chromium:767645 
TEST=Run platform_CrosDisks{DBus,Filesystem,Format,Rename} tests.

Change-Id: Idd09657f9c9e80e5d7ffadc6817ba7b262a50e28
Reviewed-on: https://chromium-review.googlesource.com/726750
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/4213f970e1f3cdcfc1552c313bb44358dd61f22a/client/site_tests/platform_CrosDisksDBus/platform_CrosDisksDBus.py
[modify] https://crrev.com/4213f970e1f3cdcfc1552c313bb44358dd61f22a/client/cros/cros_disks.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/0214e30620ca403b41368c9ac7d03d43a438ebe4

commit 0214e30620ca403b41368c9ac7d03d43a438ebe4
Author: Ben Chan <benchan@chromium.org>
Date: Thu Oct 19 06:14:12 2017

cros-disks: simplify MountEntry

As cros-disks is being migrated to use the Chrome D-Bus binding instead
of dbus-c++, this CL removes dbus-c++ related code from MountEntry, and
further simplifies MountEntry to a passive data carrying struct.

BUG= chromium:767645 
TEST=Run unit tests.
TEST=Run platform_CrosDisks{DBus,Filesystem} tests.

Change-Id: I40a421281e44e38a7ecf6cf2c2aaa97bfff32e5c
Reviewed-on: https://chromium-review.googlesource.com/724366
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/0214e30620ca403b41368c9ac7d03d43a438ebe4/cros-disks/mount_manager_unittest.cc
[delete] https://crrev.com/9f9f66e916f5ebcfdf91cfce140e49e603aca046/cros-disks/mount_entry.cc
[modify] https://crrev.com/0214e30620ca403b41368c9ac7d03d43a438ebe4/cros-disks/mount_manager.cc
[modify] https://crrev.com/0214e30620ca403b41368c9ac7d03d43a438ebe4/cros-disks/mount_manager.h
[modify] https://crrev.com/0214e30620ca403b41368c9ac7d03d43a438ebe4/cros-disks/mount_entry.h
[modify] https://crrev.com/0214e30620ca403b41368c9ac7d03d43a438ebe4/cros-disks/cros_disks_server.cc
[modify] https://crrev.com/0214e30620ca403b41368c9ac7d03d43a438ebe4/cros-disks/cros-disks.gyp
[modify] https://crrev.com/0214e30620ca403b41368c9ac7d03d43a438ebe4/cros-disks/cros_disks_server.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/7dfb810cfec41c0189b7db44cf58f0a45e6d6515

commit 7dfb810cfec41c0189b7db44cf58f0a45e6d6515
Author: Ben Chan <benchan@chromium.org>
Date: Thu Oct 19 06:14:12 2017

cros-disks: simplify MountManager::GetMountEntries()

As MountManager::GetMountEntries() always returns a newly constructed
vector of MountEntry struct, this CL simplifies the code by having
MountManager::GetMountEntries() return the vector directly instead of
via an out argument. MountManager::GetMountEntries() is also marked as a
constant method.

BUG= chromium:767645 
TEST=Run unit tests.
TEST=Run platform_CrosDisks{DBus,Filesystem} tests.

Change-Id: Iaa9efbffb2498c8ddd643f3a3bf8aee0573e1377
Reviewed-on: https://chromium-review.googlesource.com/724367
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/7dfb810cfec41c0189b7db44cf58f0a45e6d6515/cros-disks/mount_manager_unittest.cc
[modify] https://crrev.com/7dfb810cfec41c0189b7db44cf58f0a45e6d6515/cros-disks/cros_disks_server.cc
[modify] https://crrev.com/7dfb810cfec41c0189b7db44cf58f0a45e6d6515/cros-disks/mount_manager.cc
[modify] https://crrev.com/7dfb810cfec41c0189b7db44cf58f0a45e6d6515/cros-disks/mount_manager.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/f49e8df15187cb1be7461aaa74a202076a1db293

commit f49e8df15187cb1be7461aaa74a202076a1db293
Author: Ben Chan <benchan@chromium.org>
Date: Thu Oct 19 06:14:12 2017

cros-disks: remove |Disk::is_mounted_| and Disk::set_is_mounted()

Disk::is_mounted() should simply be based on whether |Disk::mount_paths_| is
empty or not. This CL removes |Disk::is_mounted_| and Disk::set_is_mounted() to
avoid any potential out-of-sync issue between |Disk::is_mounted_| and
|Disk::mount_paths_|. As Disk::is_mounted() is no longer a trivial getter of a
member variable of Disk, it's renamed to Disk::IsMounted().

BUG= chromium:767645 
TEST=Run unit tests.
TEST=Run platform_CrosDisks{DBus,Filesystem} tests.

Change-Id: I04449f76e8af43a79beed7ea7c78fe57e5720127
Reviewed-on: https://chromium-review.googlesource.com/724368
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/f49e8df15187cb1be7461aaa74a202076a1db293/cros-disks/disk.cc
[modify] https://crrev.com/f49e8df15187cb1be7461aaa74a202076a1db293/cros-disks/disk.h
[modify] https://crrev.com/f49e8df15187cb1be7461aaa74a202076a1db293/cros-disks/udev_device_unittest.cc
[modify] https://crrev.com/f49e8df15187cb1be7461aaa74a202076a1db293/cros-disks/udev_device.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/ff92fa3941aa16ad9258a43b59252526731b5c1e

commit ff92fa3941aa16ad9258a43b59252526731b5c1e
Author: Ben Chan <benchan@chromium.org>
Date: Thu Oct 19 06:14:12 2017

cros-disks: simplify Disk

As cros-disks is being migrated to use the Chrome D-Bus binding instead
of dbus-c++, this CL removes dbus-c++ related code from Disk, and
further simplifies Disk to a passive data carrying struct.

BUG= chromium:767645 
TEST=Run unit tests.
TEST=Run platform_CrosDisks{DBus,Filesystem} tests.

Change-Id: I038eefe2f4cd41dd461be3ea2dbab9b2c0160533
Reviewed-on: https://chromium-review.googlesource.com/724369
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/ff92fa3941aa16ad9258a43b59252526731b5c1e/cros-disks/disk.h
[modify] https://crrev.com/ff92fa3941aa16ad9258a43b59252526731b5c1e/cros-disks/cros_disks_server.cc
[modify] https://crrev.com/ff92fa3941aa16ad9258a43b59252526731b5c1e/cros-disks/udev_device.cc
[modify] https://crrev.com/ff92fa3941aa16ad9258a43b59252526731b5c1e/cros-disks/disk_manager_unittest.cc
[modify] https://crrev.com/ff92fa3941aa16ad9258a43b59252526731b5c1e/cros-disks/udev_device_unittest.cc
[modify] https://crrev.com/ff92fa3941aa16ad9258a43b59252526731b5c1e/cros-disks/disk.cc
[modify] https://crrev.com/ff92fa3941aa16ad9258a43b59252526731b5c1e/cros-disks/disk_unittest.cc
[modify] https://crrev.com/ff92fa3941aa16ad9258a43b59252526731b5c1e/cros-disks/cros_disks_server.h
[modify] https://crrev.com/ff92fa3941aa16ad9258a43b59252526731b5c1e/cros-disks/disk_manager.cc
[modify] https://crrev.com/ff92fa3941aa16ad9258a43b59252526731b5c1e/cros-disks/disk_manager.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/b3b073e7e4cfc93efcd5ba13d1f6dccc56ed1b4c

commit b3b073e7e4cfc93efcd5ba13d1f6dccc56ed1b4c
Author: Ben Chan <benchan@chromium.org>
Date: Thu Oct 19 06:14:17 2017

cros-disks: use self-closing tag for empty elements in introspection XML

BUG= chromium:767645 
TEST=Run unit tests.
TEST=Run platform_CrosDisks{DBus,Filesystem,Format,Rename} tests.

Change-Id: Ib86551770581c146c1e534fa66cedf70b06dda6c
Reviewed-on: https://chromium-review.googlesource.com/727100
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/b3b073e7e4cfc93efcd5ba13d1f6dccc56ed1b4c/cros-disks/dbus_bindings/org.chromium.CrosDisks.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/9c3cf6daff472a710166b860cb8f22fd6043873a

commit 9c3cf6daff472a710166b860cb8f22fd6043873a
Author: Ben Chan <benchan@chromium.org>
Date: Thu Oct 19 06:14:17 2017

cros-disks: remove IsAlive D-Bus method

The IsAlive D-Bus method is provided to allow a D-Bus client of
cros-disks to check if the cros-disks D-Bus service is alive, which is
only used in the platform_CrosDisksDBus test. Given that a D-Bus client
can use other D-Bus methods exposed by cros-disks to determine if
cros-disks is alive, this CL simplfy remove the IsAlive D-Bus method.

BUG= chromium:767645 
CQ-DEPEND=CL:726750
TEST=Run platform_CrosDisks{DBus,Filesystem,Format,Rename} tests.

Change-Id: Iec77990c0d270dea76f523674d6801eb9111c359
Reviewed-on: https://chromium-review.googlesource.com/727120
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/9c3cf6daff472a710166b860cb8f22fd6043873a/cros-disks/dbus_bindings/org.chromium.CrosDisks.xml
[modify] https://crrev.com/9c3cf6daff472a710166b860cb8f22fd6043873a/cros-disks/cros_disks_server.cc
[modify] https://crrev.com/9c3cf6daff472a710166b860cb8f22fd6043873a/cros-disks/cros_disks_server.h
[modify] https://crrev.com/9c3cf6daff472a710166b860cb8f22fd6043873a/cros-disks/org.chromium.CrosDisks.conf

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/c6c061433cb6c02f1229e9cb4ab8436fb330b046

commit c6c061433cb6c02f1229e9cb4ab8436fb330b046
Author: Ben Chan <benchan@chromium.org>
Date: Sat Nov 11 02:45:46 2017

cros-disks: remove unused forward declaration

BUG= chromium:767645 
TEST=Run unit tests.

Change-Id: I6ba8e923eb5cbb997224b2606e8f923d33f4f6b5
Reviewed-on: https://chromium-review.googlesource.com/764411
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/c6c061433cb6c02f1229e9cb4ab8436fb330b046/cros-disks/rename_manager.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/e28dc4b28aa41994146376bb957cb4c2aed84893

commit e28dc4b28aa41994146376bb957cb4c2aed84893
Author: Ben Chan <benchan@chromium.org>
Date: Sat Nov 11 02:45:47 2017

cros-disks: remove unused ExternalMounter

ExternalMounter, which mounts a filesystem using the external 'mount'
program, is no longer used and thus can be removed.

BUG= chromium:767645 
TEST=Run unit tests.
TEST=Run platform_CrosDisks{DBus,Archive,Filesystem,Format,Rename} tests.

Change-Id: I101094b602fab7f750c447d94bc81b90ecef1312
Reviewed-on: https://chromium-review.googlesource.com/764412
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[delete] https://crrev.com/c6c061433cb6c02f1229e9cb4ab8436fb330b046/cros-disks/external_mounter.cc
[delete] https://crrev.com/c6c061433cb6c02f1229e9cb4ab8436fb330b046/cros-disks/external_mounter.h
[modify] https://crrev.com/e28dc4b28aa41994146376bb957cb4c2aed84893/cros-disks/disk_manager_unittest.cc
[delete] https://crrev.com/c6c061433cb6c02f1229e9cb4ab8436fb330b046/cros-disks/external_mounter_unittest.cc
[modify] https://crrev.com/e28dc4b28aa41994146376bb957cb4c2aed84893/cros-disks/cros-disks.gyp
[modify] https://crrev.com/e28dc4b28aa41994146376bb957cb4c2aed84893/cros-disks/disk_manager.cc
[modify] https://crrev.com/e28dc4b28aa41994146376bb957cb4c2aed84893/cros-disks/disk_manager.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/33f4066b32ce5d114d187fc66d1f3d33efc1217f

commit 33f4066b32ce5d114d187fc66d1f3d33efc1217f
Author: Ben Chan <benchan@chromium.org>
Date: Wed Dec 13 00:21:33 2017

chromeos-base/cros-disks: remove glib and dbus-c++ dependency

CL:820103 migrates cros-disks to use Chrome D-Bus binding instead of
dbus-c++, so cros-disks no longer depends on glib and dbus-c++.

A chromeos-base/session_manager-client dependency is added to allow
cros-disks to use the generated session manager D-Bus proxy to monitor
D-Bus signals emitted by the session manager.

BUG= chromium:767645 
CQ-DEPEND=CL:820103
TEST=Remote trybot runs.

Change-Id: Ib57751dc2c659633bdaab8c806c5ceade0c9f145
Reviewed-on: https://chromium-review.googlesource.com/820413
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>

[modify] https://crrev.com/33f4066b32ce5d114d187fc66d1f3d33efc1217f/chromeos-base/cros-disks/cros-disks-9999.ebuild

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/445852f1e39aa5de1e107b72e8edb901280a4ba0

commit 445852f1e39aa5de1e107b72e8edb901280a4ba0
Author: Ben Chan <benchan@chromium.org>
Date: Wed Dec 13 00:21:33 2017

cros-disks: migrate from dbus-c++ to Chrome D-Bus binding

BUG= chromium:767645 
CQ-DEPEND=CL:820413
TEST=Run unit tests.
TEST=Run platform_CrosDisks{DBus,Filesystem,Format,Rename} tests.
TEST=Test mounting USB and SD drives via Files.app.
TEST=Test opening RAR archives vis Files.app.

Change-Id: I94c5296c9cb5e38b5fcfe149b9713c683616f3cf
Reviewed-on: https://chromium-review.googlesource.com/820103
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/445852f1e39aa5de1e107b72e8edb901280a4ba0/cros-disks/cros_disks_server.cc
[modify] https://crrev.com/445852f1e39aa5de1e107b72e8edb901280a4ba0/cros-disks/daemon.h
[modify] https://crrev.com/445852f1e39aa5de1e107b72e8edb901280a4ba0/cros-disks/format_manager.cc
[modify] https://crrev.com/445852f1e39aa5de1e107b72e8edb901280a4ba0/cros-disks/dbus_bindings/org.chromium.CrosDisks.xml
[modify] https://crrev.com/445852f1e39aa5de1e107b72e8edb901280a4ba0/cros-disks/format_manager.h
[delete] https://crrev.com/6ff1fcb3496fd5957d9b551f88a17da4f2212a58/cros-disks/glib_process.cc
[modify] https://crrev.com/445852f1e39aa5de1e107b72e8edb901280a4ba0/cros-disks/daemon.cc
[modify] https://crrev.com/445852f1e39aa5de1e107b72e8edb901280a4ba0/cros-disks/main.cc
[modify] https://crrev.com/445852f1e39aa5de1e107b72e8edb901280a4ba0/cros-disks/device_ejector.h
[modify] https://crrev.com/445852f1e39aa5de1e107b72e8edb901280a4ba0/cros-disks/cros-disks.gyp
[modify] https://crrev.com/445852f1e39aa5de1e107b72e8edb901280a4ba0/cros-disks/cros_disks_server.h
[modify] https://crrev.com/445852f1e39aa5de1e107b72e8edb901280a4ba0/cros-disks/rename_manager_unittest.cc
[delete] https://crrev.com/6ff1fcb3496fd5957d9b551f88a17da4f2212a58/cros-disks/glib_process_unittest.cc
[modify] https://crrev.com/445852f1e39aa5de1e107b72e8edb901280a4ba0/cros-disks/rename_manager.cc
[add] https://crrev.com/445852f1e39aa5de1e107b72e8edb901280a4ba0/cros-disks/dbus_bindings/dbus-service-config.json
[modify] https://crrev.com/445852f1e39aa5de1e107b72e8edb901280a4ba0/cros-disks/format_manager_unittest.cc
[modify] https://crrev.com/445852f1e39aa5de1e107b72e8edb901280a4ba0/cros-disks/device_ejector.cc
[delete] https://crrev.com/6ff1fcb3496fd5957d9b551f88a17da4f2212a58/cros-disks/glib_process.h
[modify] https://crrev.com/445852f1e39aa5de1e107b72e8edb901280a4ba0/cros-disks/session_manager_proxy.h
[modify] https://crrev.com/445852f1e39aa5de1e107b72e8edb901280a4ba0/cros-disks/session_manager_proxy.cc
[modify] https://crrev.com/445852f1e39aa5de1e107b72e8edb901280a4ba0/cros-disks/file_reader.h
[modify] https://crrev.com/445852f1e39aa5de1e107b72e8edb901280a4ba0/cros-disks/disk_manager_unittest.cc
[modify] https://crrev.com/445852f1e39aa5de1e107b72e8edb901280a4ba0/cros-disks/rename_manager.h