New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 767643 link

Starred by 1 user
Status: Fixed
Owner:
lijeffrey@chromium.org
Closed: Sep 2017
Cc:
█ robert...@chromium.org
chanli@chromium.org
lijeffrey@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[Findit] Error checking/retry in swarming_util can get stuck

Project Member Reported by lijeffrey@chromium.org, Sep 21 2017 
in _SendRequestToServer, due to retry, if at any point an error is encountered, it will continue to retry even if eventually successful.

The root cause is the error isn't being reset on the next iteration of retry, causing it always to go into the error-checking branch first and thinking it needs another retry

Comment 1 by lijeffrey@chromium.org, Sep 21 2017

Status: Assigned (was: Assi)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/9ae77d7a1b1441247b5879e180569993b7aa679e

commit 9ae77d7a1b1441247b5879e180569993b7aa679e
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Fri Sep 22 18:56:02 2017

[Findit] Fixing swarming_util's retry logic to return results immediatly upon success

Bug:  767643 
Change-Id: I331aa0b5232708df2a18398444af69ac0ce18db7
Reviewed-on: https://chromium-review.googlesource.com/677887
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>

[modify] https://crrev.com/9ae77d7a1b1441247b5879e180569993b7aa679e/appengine/findit/waterfall/swarming_util.py
[modify] https://crrev.com/9ae77d7a1b1441247b5879e180569993b7aa679e/appengine/findit/waterfall/test/swarming_util_test.py

Comment 3 by lijeffrey@chromium.org, Sep 22 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment