find continuous build by revision |
|||
Issue descriptionscheduler now listens to gitiles and schedules builds with revision specified. Currently revision is not among tags, so one cannot find a build by a revision. If a continuous build triggers another one (Builder triggers Tester), it should propagate the revision pin and the triggered build should be findable the same way. by convention [1] buildset tag is used to group related builds. A set of builds with the same revision pin, potentially belonging to different builders, seem to match this concept well enough. Moreover build search by buildset is optimized internally. Proposal: make luci-scheduler specify absolute revision as "buildset" tag. For gitiles, the value can be "commit/gitiles/<gitiles URL without schema>", so e.g. for https://luci-scheduler.appspot.com/jobs/fuchsia/garnet-aarch64-linux-debug/9133238153988456800 it would be "commit/gitiles/fuchsia.googlesource.com/garnet/+/4df187af36385299a31a95aa88618f72a35f14a6" Note that other examples of buildset conventions are - patch/rietveld/<hostname>/<issue_id>/<patchset_id> - patch/gerrit/<hostname>/<numeric_change_id>/<numeric_patch_number> [1]: https://chromium.googlesource.com/infra/infra/+/master/appengine/cr-buildbucket/doc/index.md#buildset-tag
,
Sep 21 2017
do we have an example of "recipes controlling the build may do different things for different branches"?
,
Sep 21 2017
no example, but I recall intents to do this for branch-heads in chromium and v8. One rational for doing so was to upload artifacts only on release branches. In any case, filtering by buildset tag followed by filtering by branch (from parameters_json), will be totally efficient in those projects who care. So, I'm going with the original proposal.
,
Sep 21 2017
we could add branch as a tag too. Then if someone wants to filter by branch too, then can do so. Others will receive builds for all branches (for a given revision)
,
Sep 21 2017
I've added s/branch/ref tag instead.
,
Sep 21 2017
maybe gitiles_ref? or git_ref? there are cipd refs and someone else may use ref for something else
,
Sep 21 2017
Changed to gitiles_ref. CL //chromium-review.googlesource.com/#/c/infra/luci/luci-go/+/677784
,
Sep 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-go.git/+/b7a757f457487cd5cfe2dae83f65c5bc10e288b7 commit b7a757f457487cd5cfe2dae83f65c5bc10e288b7 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Fri Sep 22 19:31:49 2017 scheduler: set buildset tag on gitiles-triggered buildbucket builds. R=nodir@chromium.org, vadimsh@chromium.org Bug: 767615 Change-Id: I8c90d7bbf1e744c68d91e9b23e9fdc8838a87f48 Reviewed-on: https://chromium-review.googlesource.com/677784 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org> [modify] https://crrev.com/b7a757f457487cd5cfe2dae83f65c5bc10e288b7/scheduler/appengine/task/buildbucket/buildbucket.go [modify] https://crrev.com/b7a757f457487cd5cfe2dae83f65c5bc10e288b7/scheduler/appengine/task/buildbucket/buildbucket_test.go
,
Sep 22 2017
-dev deployed. First build scheduled as inteded: https://luci-scheduler-dev.appspot.com/jobs/infra/infra-continuous-trusty-64/9133147226060683056
,
Sep 22 2017
Deployed to prod @2078-b7a757f
,
Sep 22 2017
awesome |
|||
►
Sign in to add a comment |
|||
Comment 1 by tandrii@chromium.org
, Sep 21 2017