New issue
Advanced search Search tips

Issue 767608 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.3%-1.5% regression in media.android.tough_video_cases_tbmv2 at 502571:502600

Project Member Reported by crouleau@chromium.org, Sep 21 2017

Issue description

memory usage during seek regression.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Sep 21 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=767608

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=53a934c8af6d67df15a3a150798b16e71760f370f5c23397cd91d6a4c11ff418


Bot(s) for this bug's original alert(s):

android-nexus7v2
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Sep 22 2017

Cc: peter.wm...@gmail.com
Owner: peter.wm...@gmail.com
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author peter.wm.wong@gmail.com ===

Hi peter.wm.wong@gmail.com, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : peterwmwong
  Commit : 8dfdeae0f1c352b15238d0b9100f37956e16eaa9
  Date   : Sat Sep 16 07:18:32 2017
  Subject: [builtins] Convert String HTML functions (ex. anchor, big, bold) to CSA

Bisect Details
  Configuration: android_nexus7_perf_bisect
  Benchmark    : media.android.tough_video_cases_tbmv2
  Metric       : memory:chrome:all_processes:reported_by_chrome:v8:effective_size_avg/video.html?src_tulip2.vp9.webm_seek
  Change       : 1.39% | 2239506.66667 -> 2270643.33333

Revision                           Result                  N
chromium@502570                    2239507 +- 1293.26      6      good
chromium@502585                    2212848 +- 1743.07      6      good
chromium@502589                    2211841 +- 1761.11      6      good
chromium@502590                    2212185 +- 1155.5       6      good
chromium@502590,v8@ee5c31f335      2212155 +- 1049.73      6      good
chromium@502590,v8@3d046986f0      2212198 +- 911.206      6      good
chromium@502590,v8@8dfdeae0f1      2269099 +- 724.617      6      bad       <--
chromium@502590,v8@8c89502008      2270669 +- 1014.34      6      bad
chromium@502591                    2270593 +- 1040.15      6      bad
chromium@502593                    2270289 +- 610.932      6      bad
chromium@502600                    2270643 +- 1643.66      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=video.html.src.tulip2.vp9.webm.seek media.android.tough_video_cases_tbmv2

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8967807691427081120


For feedback, file a bug with component Speed>Bisection
Cc: jgruber@chromium.org
Hi Peter,

It looks like your change caused a memory usage regression. Is this expected?
Status: WontFix (was: Assigned)
This CL adds 13 new builtins with a total size of 4.5KB. I'm not sure how this ends up on the graphs as a larger regression on the graphs, but I assume it's because they're measuring multiple processes / isolates.

I think it's OK to take this hit, especially since the upcoming lazy builtin loading mechanism will only load these into memory if they're actually used. See  crbug.com/v8/6624 .
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Oct 15 2017

Issue 768034 has been merged into this issue.
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Oct 17 2017

Cc: ulan@google.com
 Issue 767710  has been merged into this issue.

Sign in to add a comment