VR: 'x' and gear icons are the wrong size on the S8/+ when DON flow is skipped. |
||||||
Issue descriptionWhen you re-enter VR shortly after leaving it on an S8/S8+ with the default density and the DON flow is skipped, the x and gear icons are drawn for the incorrect density and don't update. We can theoretically work around this in Chrome, but it'll require delaying VR entry to ensure you can't skip the DON flow.
,
Sep 21 2017
,
Sep 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6468d308139fe73549d203ebc0ff3e98d966a66f commit 6468d308139fe73549d203ebc0ff3e98d966a66f Author: Michael Thiessen <mthiesse@chromium.org> Date: Tue Sep 26 21:02:40 2017 VR: Work around GVR UI not updating when density changes. This is a hack around b/66493165 that should be removed when a GVR fix is released. We manually find the views GVR adds to the hierarchy and resize them/re-generate their Drawables for the new density. Bug: 767603 Change-Id: Iacf40d81281d2e1a9423c095935d861b15be68fa Reviewed-on: https://chromium-review.googlesource.com/682107 Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Yash Malik <ymalik@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#504479} [modify] https://crrev.com/6468d308139fe73549d203ebc0ff3e98d966a66f/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java [modify] https://crrev.com/6468d308139fe73549d203ebc0ff3e98d966a66f/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java [modify] https://crrev.com/6468d308139fe73549d203ebc0ff3e98d966a66f/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java [modify] https://crrev.com/6468d308139fe73549d203ebc0ff3e98d966a66f/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
,
Sep 26 2017
,
Sep 26 2017
,
Oct 5 2017
I verified this does not repro on 63.0.3226.0
,
Jul 4
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by mthiesse@chromium.org
, Sep 21 2017