[WPT Import] Importer fails to add a line to TestExpectations |
||||
Issue descriptionhttps://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/2118 https://chromium-review.googlesource.com/677267 This import is expected to introduce a new failure on mac bots. The import process ran as expected until writing new lines to TestExpectations. See the log: 2017-09-21 08:18:17,753 - Adding test expectations lines to LayoutTests/TestExpectations. 2017-09-21 08:18:28,870 - No tests to rebaseline. 2017-09-21 08:18:30,115 - Lines to write to TestExpectations: 2017-09-21 08:18:30,115 - crbug.com/626703 [ Mac ] external/wpt/assumptions/ahem.html [ Failure ] 2017-09-21 08:18:30,822 - Triggering CQ try jobs. It printed out the correct new line to add, but for some reason, either the line was not written to TestExpectations, or the change was not uploaded to Gerrit. The CL stayed at patchset 1 without this new expectation line. The CQ was triggered afterwards, and failed unsurprisingly.
,
Sep 22 2017
P2 as the manual import unblocked automatic imports as expected. Will look into the root cause.
,
Oct 3 2017
,
Oct 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6483150e3050742ae64920a6daf5ec9c186ef0f2 commit 6483150e3050742ae64920a6daf5ec9c186ef0f2 Author: Robert Ma <robertma@chromium.org> Date: Tue Oct 03 20:37:41 2017 Do not skip expectation lines with existing test names When adding new lines to TestExpectations during wpt-import, the tool used to skip the lines with test names that already exist in TestExpectations, which is unnecessary and causes bug: * The new lines are created from tests that did not run as expected, so if an expectation is already covered by TestExpectations, it shouldn't have appeared in the first place (otherwise we have a bug when fetching the unexpected results). * If the test name of a new line already exists, but the new line is for a different case (e.g. different platforms), then we should add this line to TestExpectations otherwise the import would fail ( bug 767597 ). Ideally we could extend the existing expectations to cover the new unexpected results, but that would probably need a larger refactor to make heavy use of layout_tests.models.test_expectations. Bug: 767597 Change-Id: I13d46865fa6e06b8c101864f07b2cdae6af95d6e Reviewed-on: https://chromium-review.googlesource.com/698784 Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#506160} [modify] https://crrev.com/6483150e3050742ae64920a6daf5ec9c186ef0f2/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py [modify] https://crrev.com/6483150e3050742ae64920a6daf5ec9c186ef0f2/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater_unittest.py
,
Oct 4 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Sep 21 2017