New issue
Advanced search Search tips

Issue 767594 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Proj-XR

Blocked on:
issue 753865



Sign in to add a comment

VR: S8/+ get stuck in the DON flow if we set VR mode on before triggering it with default density.

Project Member Reported by mthiesse@chromium.org, Sep 21 2017

Issue description

If we set the VR Mode on the Samsung S8/S8+ before we trigger the DON flow, and the device is in its default density, we get stuck in the DON flow before controller pairing (and eventually get booted back into Chrome).

This is because the DON flow turns VR mode off (yes, you read that correctly), which changes the display density, which triggers a recreation that the DON flow doesn't seem to handle properly, and it gets stuck preventing VR entry (this happens 100% of the time).

We have to be careful though, because if we create our VR UI before turning on VR mode, the render resolution isn't correct, as  issue 767589  points out. We'll probably have to call launchInVr to trigger VR Entry without creating VR UI or enabling VR mode...
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2cd2c54261df4f50727227c8e4def86ac26b8b8

commit a2cd2c54261df4f50727227c8e4def86ac26b8b8
Author: Michael Thiessen <mthiesse@chromium.org>
Date: Fri Sep 22 22:42:01 2017

VR: Work around S8 DON flow issues by calling launchInVr.

Bug:  767594 
Change-Id: I7b5468088d9912692cee0610ad172d3b91d51099
Reviewed-on: https://chromium-review.googlesource.com/677982
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Yash Malik <ymalik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503887}
[modify] https://crrev.com/a2cd2c54261df4f50727227c8e4def86ac26b8b8/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java

Status: Fixed (was: Assigned)
Blockedon: 753865
Components: Internals>XR

Sign in to add a comment